[Pkg-libvirt-commits] [Git][libvirt-team/libosinfo][debian/experimental] 448 commits: Use GTask instead of GSimpleAsyncResult

Guido Günther gitlab at salsa.debian.org
Mon Apr 15 15:48:34 BST 2019



Guido Günther pushed to branch debian/experimental at Libvirt Packaging Team / libosinfo


Commits:
0713ebef by Fabiano Fidêncio at 2016-01-11T12:48:38Z
Use GTask instead of GSimpleAsyncResult

Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
For using the new GTask API, let's bump GIO (part of GLib) dependency
version to 2.36.
what is safe based on major distro support:
- Debian Jessie: glib-2.42
- RHEL-7.1: glib-2.40
- SLES12: glib-2.38
- Ubuntu LTS 14.04: glib-2.40

- - - - -
8f683fbe by Fabiano Fidêncio at 2016-01-11T13:43:02Z
tree: Add an indentation level for the if block

- - - - -
72a9345d by Fabiano Fidêncio at 2016-01-11T13:43:08Z
Remove checks/code for GLib older than 2.35.1

As now we depend on GLib 2.36, let's remove all checks/code that depend
on an older version than the one we require.

- - - - -
447efb59 by Fabiano Fidêncio at 2016-01-11T13:44:46Z
Use GLIB_VERSION_MAX_ALLOWED

In order to avoid using a too new GLib API.

- - - - -
0076c4f9 by Fabiano Fidêncio at 2016-01-11T13:47:18Z
Use SOUP_VERSION_MAX_ALLOWED

In order to avoid using a too new libsoup API.

- - - - -
e0a83f53 by Fabiano Fidêncio at 2016-01-11T13:47:22Z
build: Don't set PKG_NAME

The following warning was shown when running autogen.sh:
***Warning*** PKG_NAME is deprecated, you may remove it from autogen.sh

- - - - -
16f58307 by Fabiano Fidêncio at 2016-01-11T13:47:22Z
build: Don't use USE_GNOME2_MACROS

The following warning was shown when running autogen.sh:
***Warning*** USE_GNOME2_MACROS is deprecated, you may remove it from
autogen.sh

- - - - -
a2d648e1 by Daniel P. Berrange at 2016-01-13T10:41:45Z
autobuild.sh: set a default value for AUTOBUILD_INSTALL_ROOT

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
a5dc9ac0 by Daniel P. Berrange at 2016-01-13T10:41:45Z
autobuild.sh: run parallel make for faster builds

Set MAKEFLAGS to use -j option matching number of available
CPUs.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
1d744140 by Daniel P. Berrange at 2016-01-13T10:41:45Z
autobuild.sh: fix flag to turn on werror

In commit 97091136bd037aa44da13873ac910320b9ad7e6b we changed
to use gnulib's compiler warnings code, but forgot to change
the autobuild.sh flag to match. It should be --enable-werror

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
b1f4cef9 by Daniel P. Berrange at 2016-01-13T11:23:06Z
autobuild.sh: enable gtk doc build when testing

- - - - -
8d8da3b0 by Daniel P. Berrange at 2016-01-13T11:23:06Z
build: fix VPATH based builds

The VPATH build fails because the enum generator is told to
look for two generated files in the $srcdir instead of builddir.
We should not in fact loom the generated files at all when building
enums, so they can be removed.

The g-ir-scanner is also missing a -I$(build_dir) to let it find
the generated files.

Finally the gtk-doc tools were not being told to look in the
$(build_dir)

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
a267020e by Daniel P. Berrange at 2016-01-13T11:23:06Z
don't include autogenerated enum files in dist

Previous commit 77cf2730eb6e5503a9bd40e6baf7cc0b393a9dc7
reverts 4e488678d4af0e54da7400851d554bc4c4497c76 (fixes
to the VPATH build) because it was said to break the
make distcheck.

After examining the problem, it seems this commit was not
in fact the problem - it merely exposed the existing bug
elsewhere.

The real problem is that we were including the autogenerated
enum files in the dist. So when doing builds from git those
files were in $builddir, but when doing builds from dist
those files were in $srcdir. Except that 'make distclean'
would delete the enum files, which would again cause them
to appear in $builddir.

So the real fix is stop including the enum files in the dist

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
5881c4b8 by Fabiano Fidêncio at 2016-01-21T09:25:36Z
build: Fix .vapi generation

After a267020e272a generation of the .vapi file broke. It no longer has
path_pattern property while get_path_pattern() is still there.
Adding nodist_libosinfo_1_0_include_HEADERS to the list of the files
passed to the .gir generation solves the problem.

- - - - -
202acfef by Guido Günther at 2016-02-05T10:46:24Z
Update CD URLs to latest Debian Jessie point release

- - - - -
f81f3570 by Roman Bogorodskiy at 2016-03-03T14:17:05Z
Fix build with older GCC

Build with older gcc fails with:

  CC       libosinfo_1_0_la-osinfo_avatar_format.lo
In file included from ../osinfo/osinfo_os.h:30,
                 from ../osinfo/osinfo.h:55,
                 from osinfo_avatar_format.c:28:
../osinfo/osinfo_media.h:68: error: redefinition of typedef 'OsinfoMedia'
../osinfo/osinfo_install_script.h:43: error: previous declaration of 'OsinfoMedia' was here

To avoid redefinition, use forward-declaration in a similar way
like it's done for OsinfoOs in osinfo/osinfo_os.h.

- - - - -
0ae4f0db by Charles Arnold at 2016-03-24T10:41:25Z
data: add missing SLES/SLED distro information

Add missing SLES/SLED distro information.

Added os data and isodata for the following distros:
SUSE Linux Enterprise Server 12 SP1
SUSE Linux Enterprise Desktop 12 SP1

Added isodata for the following distros:
SUSE Linux Enterprise Server 11 SP4
SUSE Linux Enterprise Desktop 11 SP4

- - - - -
92c55cab by Charles Arnold at 2016-03-24T10:44:18Z
data: add missing openSUSE distro information

Add missing openSUSE distro information.

Added os data and isodata for the following distros:
openSUSE Leap 42.1
openSUSE Tumbleweed

- - - - -
6b56b90c by Roman Bogorodskiy at 2016-04-19T08:01:43Z
README: update homepage

- - - - -
c1dc863d by Roman Bogorodskiy at 2016-04-19T08:02:39Z
README: adjust wording a little.

- - - - -
5838b0e5 by Roman Bogorodskiy at 2016-04-19T08:02:59Z
freebsd: use proper version value for 10.1

10.0 -> 10.1

- - - - -
762c774c by Christophe Fergeau at 2016-04-19T08:41:18Z
opensuse: Remove invalid upgrades/derives-from links

tumbleweed has upgrades and derives-from nodes using non-existent IDs.
This causes runtime warnings when running test-isodata.

- - - - -
ccaa457a by Roman Bogorodskiy at 2016-04-20T08:12:27Z
freebsd: add information about 10.2 and 10.3

- - - - -
2cbb3319 by Fabiano Fidêncio at 2016-05-04T21:04:55Z
win7: Remove two duplicated volume id entries

The entries removed are:
- GSP1RMCPRVOL (Windows 7 Professional x86)
- GSP1RMCPRXVOL (Windows 7 Professional x86_64)

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
55f9e34f by Fabiano Fidêncio at 2016-05-04T21:05:12Z
win8: Add missing cmd script for installer

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
8ec5b71a by Fabiano Fidêncio at 2016-05-04T21:05:14Z
win8: Add comment about the user avatar issue

User avatar is not set as expected after performing a unattended
installation of Windows 8 (or newer).

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
9f083122 by Fabiano Fidêncio at 2016-05-04T21:05:16Z
win8: Add installer-reboots value

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
12145674 by Fabiano Fidêncio at 2016-05-04T21:05:18Z
win8.1: Add one more enterprise iso data

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
1c23122e by Fabiano Fidêncio at 2016-05-04T21:05:19Z
win8.1: Add two more "no variant" volume ids

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
1962c88e by Fabiano Fidêncio at 2016-05-04T21:05:20Z
win8.1: Add a few more professional volume ids

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
8bc56204 by Fabiano Fidêncio at 2016-05-04T21:05:21Z
win8.1: Adjust the vol-id for enterprise x86

Use the same pattern of Volume ids used for enterprise x86_64.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
7f526e12 by Fabiano Fidêncio at 2016-05-04T21:05:22Z
win8.1: Clean up vol-id entries

- IR[M135]_CEN?NA_X*FRE is already covered by Enterprise Volume ids.
- IR[M3]_CCSN?A_X*FRE is now covered by No Variant Volume ids.
- IR[M15]_CPRN?A_X*FREV is now covered by Professional Volume Ids.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
91d39dae by Fabiano Fidêncio at 2016-05-04T21:05:24Z
win8.1,installer: Tune based on variants

So, I ended up doing tests with all ISOs that I have access from MSDN
and here is the conclusion:

Windows 8.1
 Problematic:
  en_windows_8_1_enterprise_debug_checked_x64_dvd_2756358.iso
  en_windows_8_1_enterprise_n_debug_checked_x64_dvd_2942525.iso
  en_windows_8_1_enterprise_n_x64_dvd_2971845.iso
  en_windows_8_1_enterprise_x64_dvd_2971902.iso
  en_windows_8_1_pro_n_vl_x64_dvd_2971969.iso

 Non-problematic:
  en_windows_8_1_n_debug_checked_x64_dvd_2707894.iso
  en_windows_8_1_debug_checked_x64_dvd_2707208.iso
  en_windows_8_1_n_x64_dvd_2707896.iso

Windows 8.1 with Updates:
 Problematic:
  en_windows_8.1_enterprise_n_with_update_x64_dvd_6050225.iso
  en_windows_8.1_enterprise_with_update_x64_dvd_6054382.iso
  en_windows_8.1_pro_n_vl_with_update_x64_dvd_6050969.iso
  en_windows_8.1_pro_vl_with_update_x64_dvd_6050880.iso

 Non-problematic:
  en_windows_8.1_n_with_update_x64_dvd_6051677.iso
  en_windows_8.1_with_update_x64_dvd_6051480.iso

Based on this info, the best way to go is:
- Set the ProductKey during the WindowsPE phase of the setup only in the
  following conditions:
  - any Windows media that is not Windows 8.1 (as it was before)
  - Windows 8.1 media has no variant
  - Windows 8.1 media contains on its variant debug but doesn't contain
    enterprise on it

  These rules will cover medias with no variant and with "debug" variant
  that are not enterprise. All the rest (Enterprise, Enterprise Debug
  and Professional) will have the ProductKey skipped during the
  WindowsPE phase of the setup.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
f2614c3f by Fabiano Fidêncio at 2016-05-04T21:05:25Z
win8.1,installer: Force Windows activation

I've noticed that when installing Windows 8.1 the activation is not done
by the end of the unattended installation and, actually, the serial
number shown in the Activate Windows program is different than the one
used to perform the installation. Also, when tring to activate the
software it fails with the "Windows can't be activate. Try again later"
message and no useful details about the error.

So, in order to avoid this issue, let's force the activation in the
FirstLogon phase of the installation script by directly editing the
Slmgr.vbs options for Volume Activation.

For more info about the Slmgr.vbs Options for Volume Activation, please,
take a look on:
https://technet.microsoft.com/en-us/library/dn502540.aspx

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
41bc4672 by Fabiano Fidêncio at 2016-05-04T21:05:26Z
installer: Use l10n-language as UI language

Since commit 57b459e09 we set 'EN-US' as UI language instead of 'EN-GB'.
However, this hack is only necessary for Windows 7 and can cause issues
when installing newer versions of the Windows, as the installer,
somehow, gets confused by having different values set to UI language,
System Locale and User Locale and ends up prompting a window for letting
the user to set these values.

By limiting the hack to Windows 7, this patch fixes the installation of
'EN-GB' ISOs of Windows 8 and 8.1 (the ones tested for now).

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
15a28f7b by Fabiano Fidêncio at 2016-05-04T21:05:27Z
win8.1: Re-enable unattended installation

Now the unattended installation works properly, apart from the user
avatar not being set for Windows 8 (or newer)[0].
Due to the Windows policy on hostname and therefore apps might need
to be patched for the installer scripts to work[1].

[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1328637
[1]: https://bugzilla.gnome.org/show_bug.cgi?id=765175

This reverts commit 49ae46cda4fbd2e95dc794cb64aec27117351c85.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak gnome org>

- - - - -
54ad95bd by Fabiano Fidêncio at 2016-05-04T21:05:28Z
win8.1: Add installer-reboots value

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
a0dd6f29 by Fabiano Fidêncio at 2016-05-09T16:42:24Z
opensuse-42.1: Fix volume-id match

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
ef6fbab8 by Fabiano Fidêncio at 2016-05-09T16:42:27Z
opensuse-42.1: Add AC97 device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
5dabad2c by Fabiano Fidêncio at 2016-05-09T16:42:33Z
opensuse-42.1: Add QXL device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
20f33179 by Fabiano Fidêncio at 2016-05-09T16:42:37Z
opensuse-42.1: Add virtio-block device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
bb98484e by Fabiano Fidêncio at 2016-05-09T16:42:40Z
opensuse-42.1: Add virtio-net device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
4554617d by Fabiano Fidêncio at 2016-05-09T16:42:44Z
opensuse-42.1: Add USB Tablet device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
ba658630 by Fabiano Fidêncio at 2016-05-09T16:42:48Z
opensuse-tumbleweed: Add AC97 device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
e6b89e00 by Fabiano Fidêncio at 2016-05-09T16:42:51Z
opensuse-tumbleweed: Add QXL device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
1df2fba5 by Fabiano Fidêncio at 2016-05-09T16:42:55Z
opensuse-tumbleweed: Add virtio-block device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
c239fd04 by Fabiano Fidêncio at 2016-05-09T16:42:58Z
opensuse-tumbleweed: Add virtio-net device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
2a903fe9 by Fabiano Fidêncio at 2016-05-09T16:43:15Z
opensuse-tumbleweed: Add USB Tablet device

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
96fb6ca5 by Fabiano Fidêncio at 2016-05-09T16:43:19Z
opensuse-tumbleweed: Bump recommended storage size

Although the values are correct, it is impossible to have a normal
(graphical) usage of a system with the storage's recommended size.

So, instead of using 5GB as recommended storage size, let's increase
this value to 20GB.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
60d4f995 by Fabiano Fidêncio at 2016-05-09T16:43:24Z
opensuse,installer: Add JEOS script

The script has been tested and works as expected for the most recent
releases of OpenSUSE (Leap 4.21 and Tumbleweed).

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
e08aa8aa by Fabiano Fidêncio at 2016-05-09T16:43:26Z
opensuse,installer: Add DESKTOP script

The script has been tested and works as expected for the most recent
releases of OpenSUSE (Leap 4.21 and Tumbleweed).

A big thanks to Lasse Schuirmann, who had worked on a similar script,
from which I got the chroot-scripts part, during his GSoC project.

Co-author: Lasse Schuirmann <lasse.schuirmann at gmail.com>

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
368b94e9 by Fabiano Fidêncio at 2016-05-09T16:43:27Z
opensuse-42.1: Enable express installation

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
b3ce3549 by Fabiano Fidêncio at 2016-05-09T16:43:30Z
opensuse-tumbleweed: Enable express installation

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
711254ef by Fabiano Fidêncio at 2016-05-09T16:43:32Z
win8: Add enterprise variant

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
6485005c by Fabiano Fidêncio at 2016-05-09T16:43:37Z
win8: Add enterprise-debug variant

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
b26d0a27 by Fabiano Fidêncio at 2016-05-09T16:43:42Z
win8: Add debug variant

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
4ded9a55 by Fabiano Fidêncio at 2016-05-09T16:43:46Z
win8: Add professional variant

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
f05a8a21 by Fabiano Fidêncio at 2016-05-09T17:02:00Z
win8: Generalize "No Variant" vol ID expression

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
190dbf2e by Fabiano Fidêncio at 2016-05-09T17:02:05Z
win8,installer: Tune based on variants

As Windows 8.1, Windows 8 (most likely) has to have the ProductKey
skipped during the WindowsPE phase of the script for the enterprise,
enterprise-debug and professional variants.

"Most likely" is said because I haven't been able to test the Windows 8
Professional variant as it needs a VLK and MSDN tells me that only
administrators can access keys in the Volume Licensing Service Center
(VLSC).

Also, I haven't been able to start an installation using none of the
debug ISOs, as the system reboots just a minute (or so) after booting
up. It seems to be a problem with the ISOs themselves, as I've
downloaded a few ISOs (different locales) and faced the same issue.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
b33ecba0 by Fabiano Fidêncio at 2016-05-10T19:13:51Z
win10: Add an Education x86_64 volume ID

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
45bcf744 by Fabiano Fidêncio at 2016-05-10T19:14:08Z
win10: Generalize "Education" volume ID expression

Let's generalize the x86 volume ID expression in order to cover more
volume IDs, based on the ones already covered in the x86_64 volume ID
expression.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
a5f36951 by Fabiano Fidêncio at 2016-05-10T19:14:41Z
win10: Add two Enterprise x86_64 volume IDs

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
512af564 by Fabiano Fidêncio at 2016-05-10T19:14:54Z
win10: Generalize "Enterprise" volume ID expression

Let's generalize the expression for x86 volume IDs in order to cover
more volume IDs.

The expression is based on the one used for the x86_64 volume IDs.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
f769e8af by Fabiano Fidêncio at 2016-05-10T19:15:23Z
win10: Add two Enterprise LTSB (x86_64) volume IDs

LTSB stands for Long Term Servicing Branch.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
c1c50c8c by Fabiano Fidêncio at 2016-05-10T19:15:31Z
win10: Generalize "Enterprise LTSB" volume ID expression

Let's generalize the x86 volume ID expression in order to cover more
volume IDs.

The expression is based on the one used for the x86_64 volume IDs.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
37e707c9 by Fabiano Fidêncio at 2016-05-10T19:15:43Z
win10: Add two x86_64 volume IDs

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
5f0eaa7b by Fabiano Fidêncio at 2016-05-10T19:15:48Z
win10: Generalize "No Variant" volume ID expression

Let's generalize the expression for x86 volume IDs in order to cover
more volume IDs.

The expression is based on the one used for the x86_64 volume IDs.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
17809d54 by Fabiano Fidêncio at 2016-05-10T19:15:54Z
win,installer: Improve "setting product key" logic

Only a few variants of Windows 8 and Windows 8.1, like Enterprise,
Enterprise Debug and Professional, have to have the ProductKey skipped
during the WindowsPE phase of the installation script.

This patch re-writes the "skipping ProductKey" logic in a cleaner way,
making it work also for Windows 10 (and all its variants).

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
b160aadf by Fabiano Fidêncio at 2016-05-10T19:15:59Z
win10: Enable unattended installation

Unattended installation works properly, apart from the user avatar not
being set for Windows 8 (or newer)[0].

[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1328637

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
e69f7e80 by Christophe Fergeau at 2016-05-11T12:44:48Z
media: Fix misplaced parenthesis in strncmp use

Due to a misplaced parenthesis, bootable media detection was doing
strncmp(.., .., sizeof(..) != 0)
instead of
strncmp(.., .., sizeof(..)) != 0

This means we were comparing 1 character from BOOTABLE_TAG rather than
the full string.

This was found when trying to compile libosinfo with CC=clang

- - - - -
c4d37904 by Fabiano Fidêncio at 2016-05-11T12:58:01Z
build: Fix "--no-undefined" linker's flag for OSX

Apple's linker doesn't have support to "--no-undefined" and we must use
something equivalent, like: "-undefined,error".

The patch was test by Programmingkid and his positive feedback can be
seen here:
https://www.redhat.com/archives/libosinfo/2016-May/msg00164.html

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1305016

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
587b7a62 by Andrew Stormont at 2016-05-11T13:27:31Z
build: Fix "--no-undefined" linker's flag for solaris

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1302339
Acked-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
489fe463 by Vladimir Beneš at 2016-05-11T16:17:35Z
debian,installer: Add ssh-server for installation

Installing ssh-server is needed for testing purposes.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1251668
Acked-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
f0c6ba83 by Fabiano Fidêncio at 2016-05-13T08:51:47Z
win,installer: Fix misplaced parenthesis

The commit 17809d54 inserted a wrong parenthesis in the test done for
skipping the ProductKey during the WindowsPE phase of the script.

In this patch, the bogus expression "count(media/variant != 0)" is
replaced by "count(media/variant) != 0".

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
501541a3 by Fabiano Fidêncio at 2016-05-13T08:52:12Z
win,installer: Fix "Windwos" typo

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
68108e39 by Programmingkid at 2016-05-13T08:55:13Z
configure.ac: Fix darwin detection code

The $host variable would be set to "x86_64-apple-darwin10.8.0" when using
Mac OS X. So to detect it, we need to add another asterisk to the case.

Signed-off-by: John Arbuckle <programmingkidx at gmail.com>
Acked-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
b218c071 by Fabiano Fidêncio at 2016-05-17T09:31:21Z
debian: Add Debian Testing info

Is worth mentioning that Debian Testing is a rolling release done every
week. That's the reason the upgrades/derives-from fields are omitted in
this patch and that the devices must be added here as well.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
21c828ae by Fabiano Fidêncio at 2016-05-18T21:39:16Z
debian,installers: Enable ftp mirror

Currently, after completing the installation, the users are not able to
install any software in the VM as the only entry in
/etc/apt/sources.list is the installation media itself.

Also, desktop installation's profile is broken as qemu-guest-agent is
not part of the installation media and we have no mirror set up for
downloading the package from.

Let's fix these issues enabling the ftp mirror and removing the DVD from
the /etc/apt/sources.list.

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1336110
https://bugzilla.redhat.com/show_bug.cgi?id=1336111

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
657758ce by Fabiano Fidêncio at 2016-05-18T21:39:33Z
debian,installer: Set user avatar

Set user avatar in the desktop installation's profile based on what is
done in Fedora and openSUSE scripts.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336112

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
05091691 by Fabiano Fidêncio at 2016-05-23T06:57:35Z
Revert "debian: Allow empty passwords"

The workaround that has been used so far doesn't work.

For the user account, the password is indeed removed in the end of the
installation, but then login in from GDM is impossible. Although it
works from a VT (depending on the installed version), this is not
something obvious that every user would try. So, requiring the user
password seems the best to do for now and when a proper solution is
found, the user password can be set to optional again.

For the root account, the password is not removed in the of the
installation and ends up being set as "dummyPa55w0rd", something that
the user would never guess, unless they have access to the libosinfo
code. So, requiring the admin password seems the best to do for now and
when a proper solution is found the admin password can be set to
optional again.

This reverts commit 087a8f8a23895e2d792b0f6d26a9d0c01a6c7e87.

 Conflicts:
	data/install-script/debian.org/debian-preseed-desktop.xml.in

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1336108
https://bugzilla.redhat.com/show_bug.cgi?id=1336109

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>

- - - - -
8e63a1e2 by Christophe Fergeau at 2016-06-02T11:22:50Z
rhel: Add RHEL Atomic 7.2 data

- - - - -
3b5950e9 by Christophe Fergeau at 2016-06-02T11:22:54Z
rhel: Add RHEL 6.8 data

- - - - -
bbe709b5 by Christophe Fergeau at 2016-06-02T11:22:56Z
ubuntu: Add Ubuntu 15.10 test cases

Detection was already present, but not the corresponding test files.

- - - - -
54375b15 by Christophe Fergeau at 2016-06-02T16:58:05Z
opensuse: Rename autoinst files according to their id

This causes warnings when running ./test/test-isodetect if they are not
named as expected:

** (process:28952): WARNING **: Entity http://opensuse.org/opensuse/autoyast/desktop
should be in file install-script/opensuse.org/opensuse-autoyast-desktop.xml not
install-script/opensuse.org/autoinst-desktop.xml

- - - - -
1406d5be by Christophe Fergeau at 2016-06-02T16:58:05Z
opensuse: Fix id of x11-keyboard datamap

The correct id is http://x.org/x11-keyboard and not
http://libosinfo.fedorahosted.org/x11-keyboard

- - - - -
2274644d by Christophe Fergeau at 2016-06-03T09:21:30Z
ubuntu: Add Ubuntu 16.04 data

- - - - -
f8280549 by Christophe Fergeau at 2016-06-03T09:21:30Z
ubuntu: Mark the sparc ISOs as sparc64

These ISOs only contain a 64 bit kernel.

- - - - -
356a2981 by Christophe Fergeau at 2016-06-03T11:39:23Z
ubuntu: Fix initrd/kernel paths

The initrd extensions are either .lz or .gz depending on the version
(server/desktop), and the base directory is either casper or install.

Some of the powerpc/parisc entries could be improved as the ISOs contain
multiple kernels and initrds (eg 32/64 bit versions).

- - - - -
bbb24e25 by Christophe Fergeau at 2016-06-03T11:40:13Z
test: Adjust test database directory layout

Since the database reorganization, the files must follow a directory
layout matching their id, otherwise a warning is emitted.

- - - - -
f0f3db1c by Christophe Fergeau at 2016-06-03T11:40:13Z
os: Fix invalid URLs

Some URLs have become obsolete since the last time
test-treeuris/test-mediauris were run, this fixes these 2 tests.

- - - - -
37386b02 by Christophe Fergeau at 2016-06-03T11:40:13Z
test: Silence expected warning in test-os

- - - - -
66cf014c by Christophe Fergeau at 2016-06-03T11:40:13Z
test: Make warnings fatal

Since standard output is hidden by default while we run make check, it's
very easy to miss test cases emitting new warnings. This commit uses
g_log_set_fatal_mask() to ensure that the test cases will abort if a
warning is emitted while they run. This matches the behaviour of the
GTest  framework.

- - - - -
fbe3dff2 by Fabiano Fidêncio at 2016-07-01T08:50:06Z
osinfo-query: return failure when no matches are found

According to `man osinfo-query`: "The exit status will be 0 if matching
entries were found, or 1 if not matches were found". So, let's adapt the
program in order to match the manual.

Also, this patch was written keeping the current behavior about printing
the Short ID, Name, Version, ID table.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1351718

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
5c7e96c9 by Christophe Fergeau at 2016-07-01T09:06:42Z
test-entity: Fix osinfo_entity_get_param_keys() leak

The list returned by osinfo_entity_get_param_keys() must be freed.

==20812== 24 bytes in 1 blocks are definitely lost in loss record 109 of 262
==20812==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==20812==    by 0x684FE58: g_malloc (gmem.c:94)
==20812==    by 0x6866D42: g_slice_alloc (gslice.c:1025)
==20812==    by 0x6846A13: g_list_append (glist.c:261)
==20812==    by 0x532BB88: osinfo_entity_get_param_keys (osinfo_entity.c:300)
==20812==    by 0x40160F: test_empty_props (test-entity.c:71)
==20812==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==20812==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==20812==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==20812==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==20812==    by 0x51178EB: srunner_run (check_run.c:782)
==20812==    by 0x40314A: main (test-entity.c:344)

- - - - -
bfb71822 by Christophe Fergeau at 2016-07-01T09:06:42Z
entity: Fix osinfo_entity_get_param_keys() leak

The content of the GList returned by osinfo_entity_get_param_key() is
not owned by the caller, but by OsinfoEntity. However, the "id" field
added to the list was owned by the caller, and could not be freed
properly. This commit adds a const char * to the GList rather than
adding a g_strdup'ed string in order to fix this leak.

==12129== 3 bytes in 1 blocks are definitely lost in loss record 7 of 269
==12129==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==12129==    by 0x684FE58: g_malloc (gmem.c:94)
==12129==    by 0x686889E: g_strdup (gstrfuncs.c:363)
==12129==    by 0x532BB81: osinfo_entity_get_param_keys (osinfo_entity.c:300)
==12129==    by 0x401AFF: test_multi_props_clear (test-entity.c:266)
==12129==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==12129==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==12129==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==12129==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==12129==    by 0x51178EB: srunner_run (check_run.c:782)
==12129==    by 0x401369: main (test-entity.c:344)

- - - - -
da5d9253 by Christophe Fergeau at 2016-07-01T09:06:42Z
test: Fix osinfo_list_get_elements() leak

The returned list must be freed after use.

This fixes:

==13583==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==13583==    by 0x684FE58: g_malloc (gmem.c:94)
==13583==    by 0x6866D42: g_slice_alloc (gslice.c:1025)
==13583==    by 0x68462B5: g_list_prepend (glist.c:311)
==13583==    by 0x683A06B: g_hash_table_get_values (ghash.c:1814)
==13583==    by 0x532D2CC: osinfo_list_get_elements (osinfo_list.c:212)
==13583==    by 0x401961: test_uris (test-mediauris.c:87)
==13583==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==13583==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==13583==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==13583==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==13583==    by 0x51178EB: srunner_run (check_run.c:782)
==13583==    by 0x4016A4: main (test-mediauris.c:146)

- - - - -
8974a9b7 by Christophe Fergeau at 2016-07-01T09:06:42Z
test-product: Fix two small leaks

This fixes:

==14496== 456 (48 direct, 408 indirect) bytes in 1 blocks are definitely lost in loss record 373 of 382
==14496==    at 0x65E1964: g_type_create_instance (gtype.c:1854)
==14496==    by 0x65C36AA: g_object_new_internal (gobject.c:1781)
==14496==    by 0x65C50CC: g_object_newv (gobject.c:1928)
==14496==    by 0x65C58B3: g_object_new (gobject.c:1621)
==14496==    by 0x53375FD: osinfo_productfilter_new (osinfo_productfilter.c:93)
==14496==    by 0x401982: test_supportdate (test-product.c:121)
==14496==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==14496==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==14496==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==14496==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==14496==    by 0x51178EB: srunner_run (check_run.c:782)
==14496==    by 0x40166E: main (test-product.c:219)
==14496==-
==14496== 1,964 (48 direct, 1,916 indirect) bytes in 1 blocks are definitely lost in loss record 379 of 382
==14496==    at 0x65E1964: g_type_create_instance (gtype.c:1854)
==14496==    by 0x65C36AA: g_object_new_internal (gobject.c:1781)
==14496==    by 0x65C55ED: g_object_new_valist (gobject.c:2040)
==14496==    by 0x65C58A0: g_object_new (gobject.c:1624)
==14496==    by 0x5338257: osinfo_productlist_new (osinfo_productlist.c:81)
==14496==    by 0x401946: test_supportdate (test-product.c:116)
==14496==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==14496==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==14496==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==14496==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==14496==    by 0x51178EB: srunner_run (check_run.c:782)
==14496==    by 0x40166E: main (test-product.c:219)

- - - - -
130a4005 by Christophe Fergeau at 2016-07-01T09:06:42Z
productfilter: Fix GDate leak

osinfo_productfilter_matches_default() was not freeing the GDate
instances returned by osinfo_product_get_{release,eol}_date().

This fixes:

==14496== 16 bytes in 2 blocks are definitely lost in loss record 141 of 382
==14496==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==14496==    by 0x684FE58: g_malloc (gmem.c:94)
==14496==    by 0x6830114: g_date_new_dmy (gdate.c:289)
==14496==    by 0x5337012: date_from_string (osinfo_product.c:345)
==14496==    by 0x533706D: osinfo_product_get_release_date (osinfo_product.c:354)
==14496==    by 0x5337F6F: osinfo_productfilter_matches_default (osinfo_productfilter.c:279)
==14496==    by 0x532CC8D: osinfo_filter_matches (osinfo_filter.c:288)
==14496==    by 0x532D51B: osinfo_list_add_filtered (osinfo_list.c:272)
==14496==    by 0x532DD52: osinfo_list_new_filtered (osinfo_list.c:443)
==14496==    by 0x401B35: test_supportdate (test-product.c:140)
==14496==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==14496==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==14496==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==14496==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==14496==    by 0x51178EB: srunner_run (check_run.c:782)
==14496==    by 0x40166E: main (test-product.c:219)
==14496==-
==14496== 16 bytes in 2 blocks are definitely lost in loss record 142 of 382
==14496==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==14496==    by 0x684FE58: g_malloc (gmem.c:94)
==14496==    by 0x6830114: g_date_new_dmy (gdate.c:289)
==14496==    by 0x5337012: date_from_string (osinfo_product.c:345)
==14496==    by 0x53370C8: osinfo_product_get_eol_date (osinfo_product.c:364)
==14496==    by 0x5337F92: osinfo_productfilter_matches_default (osinfo_productfilter.c:280)
==14496==    by 0x532CC8D: osinfo_filter_matches (osinfo_filter.c:288)
==14496==    by 0x532D51B: osinfo_list_add_filtered (osinfo_list.c:272)
==14496==    by 0x532DD52: osinfo_list_new_filtered (osinfo_list.c:443)
==14496==    by 0x401B35: test_supportdate (test-product.c:140)
==14496==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==14496==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==14496==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==14496==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==14496==    by 0x51178EB: srunner_run (check_run.c:782)
==14496==    by 0x40166E: main (test-product.c:219)

- - - - -
10d01b1b by Christophe Fergeau at 2016-07-01T09:06:42Z
productfilter: Free 'supportDate' in ::finalize()

This fixes:
==4878== 8 bytes in 1 blocks are definitely lost in loss record 8 of 319
==4878==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==4878==    by 0x6849E58: g_malloc (gmem.c:94)
==4878==    by 0x682A114: g_date_new_dmy (gdate.c:289)
==4878==    by 0x5335C6D: osinfo_productfilter_add_support_date_constraint (osinfo_productfilter.c:210)
==4878==    by 0x401E8B: test_supportdate (test-product.c:171)
==4878==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==4878==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==4878==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==4878==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==4878==    by 0x51178EB: srunner_run (check_run.c:782)
==4878==    by 0x40165E: main (test-product.c:221)

- - - - -
05d59019 by Christophe Fergeau at 2016-07-01T09:06:42Z
test-install-script: Fix various small leaks

The value returned by osinfo_install_script_generate_for_media_finish()
was not freed in several codepaths, and the mainloop was not destroyed when
no longer needed. Data read with g_file_load_contents was also not freed
when no longer used.

This fixes:
==12193== 528 bytes in 1 blocks are definitely lost in loss record 2,279 of 2,310
==12193==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==12193==    by 0x5F6D459: xmlStrndup (xmlstring.c:45)
==12193==    by 0x556EF95: xsltSaveResultToString (xsltutils.c:1780)
==12193==    by 0x53345C2: osinfo_install_script_apply_xslt (osinfo_install_script.c:824)
==12193==    by 0x53346EC: osinfo_install_script_apply_template (osinfo_install_script.c:853)
==12193==    by 0x5334A7A: osinfo_install_script_generate_async_common (osinfo_install_script.c:942)
==12193==    by 0x5335170: osinfo_install_script_generate_for_media_async (osinfo_install_script.c:1216)
==12193==    by 0x40298A: test_script_data (test-install-script.c:212)
==12193==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==12193==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==12193==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==12193==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==12193==    by 0x51178EB: srunner_run (check_run.c:782)
==12193==    by 0x401F82: main (test-install-script.c:345)

==12193== 16 bytes in 1 blocks are definitely lost in loss record 772 of 2,310
==12193==    at 0x4C2DA60: calloc (vg_replace_malloc.c:711)
==12193==    by 0x684FEB0: g_malloc0 (gmem.c:124)
==12193==    by 0x684ABF1: g_main_loop_new (gmain.c:3929)
==12193==    by 0x402373: test_script_datamap (test-install-script.c:284)
==12193==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==12193==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==12193==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==12193==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==12193==    by 0x51178EB: srunner_run (check_run.c:782)
==12193==    by 0x401F82: main (test-install-script.c:345)

==29859== 16,384 bytes in 1 blocks are definitely lost in loss record 2,295 of 2,295
==29859==    at 0x4C2BAEE: malloc (vg_replace_malloc.c:298)
==29859==    by 0x4C2DCA1: realloc (vg_replace_malloc.c:785)
==29859==    by 0x684FF1F: g_realloc (gmem.c:159)
==29859==    by 0x681DE68: g_array_maybe_expand (garray.c:779)
==29859==    by 0x681E783: g_array_set_size (garray.c:555)
==29859==    by 0x681F328: g_byte_array_set_size (garray.c:1752)
==29859==    by 0x62775AE: g_file_load_contents (gfile.c:6748)
==29859==    by 0x4025E9: test_script_data (test-install-script.c:195)
==29859==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==29859==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==29859==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==29859==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==29859==    by 0x51178EB: srunner_run (check_run.c:782)
==29859==    by 0x40303D: main (test-install-script.c:349)

- - - - -
145d0e7d by Christophe Fergeau at 2016-07-01T09:06:42Z
install-script: Fix GFile leaks

This fixes:

==12193== 89 (32 direct, 57 indirect) bytes in 1 blocks are definitely lost in loss record 1,826 of 2,310
==12193==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==12193==    by 0x684FE58: g_malloc (gmem.c:94)
==12193==    by 0x6866D42: g_slice_alloc (gslice.c:1025)
==12193==    by 0x686736D: g_slice_alloc0 (gslice.c:1051)
==12193==    by 0x65E1821: g_type_create_instance (gtype.c:1857)
==12193==    by 0x65C36AA: g_object_new_internal (gobject.c:1781)
==12193==    by 0x65C50CC: g_object_newv (gobject.c:1928)
==12193==    by 0x65C58B3: g_object_new (gobject.c:1621)
==12193==    by 0x6320EF9: _g_local_file_new (glocalfile.c:301)
==12193==    by 0x98512F7: g_daemon_vfs_get_file_for_path (gdaemonvfs.c:383)
==12193==    by 0x98513A1: g_daemon_vfs_get_file_for_uri (gdaemonvfs.c:407)
==12193==    by 0x5334B09: osinfo_install_script_generate_async_common (osinfo_install_script.c:959)
==12193==    by 0x5335170: osinfo_install_script_generate_for_media_async (osinfo_install_script.c:1216)
==12193==    by 0x402B8A: test_script_file (test-install-script.c:157)
==12193==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==12193==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==12193==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==12193==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==12193==    by 0x51178EB: srunner_run (check_run.c:782)
==12193==    by 0x401F82: main (test-install-script.c:345)

==12193== 89 (32 direct, 57 indirect) bytes in 1 blocks are definitely lost in loss record 1,827 of 2,310
==12193==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==12193==    by 0x684FE58: g_malloc (gmem.c:94)
==12193==    by 0x6866D42: g_slice_alloc (gslice.c:1025)
==12193==    by 0x686736D: g_slice_alloc0 (gslice.c:1051)
==12193==    by 0x65E1821: g_type_create_instance (gtype.c:1857)
==12193==    by 0x65C36AA: g_object_new_internal (gobject.c:1781)
==12193==    by 0x65C50CC: g_object_newv (gobject.c:1928)
==12193==    by 0x65C58B3: g_object_new (gobject.c:1621)
==12193==    by 0x6320EF9: _g_local_file_new (glocalfile.c:301)
==12193==    by 0x98512F7: g_daemon_vfs_get_file_for_path (gdaemonvfs.c:383)
==12193==    by 0x98513A1: g_daemon_vfs_get_file_for_uri (gdaemonvfs.c:407)
==12193==    by 0x402899: test_script_data (test-install-script.c:191)
==12193==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==12193==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==12193==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==12193==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==12193==    by 0x51178EB: srunner_run (check_run.c:782)
==12193==    by 0x401F82: main (test-install-script.c:345)
=

- - - - -
e32f5ca4 by Christophe Fergeau at 2016-07-01T09:06:42Z
install-script: Fix leak in error case in generate_entity_xml()

The key list returned by osinfo_entity_get_param_keys() was freed in the
nominal case, but not in the error case.

- - - - -
a1a3faf2 by Christophe Fergeau at 2016-07-01T09:06:42Z
install-script: Fix leak in _template_loaded()

The file content obtained through g_file_load_contents_finish() was
never freed.

This fixes:
==29859== 16,384 bytes in 1 blocks are definitely lost in loss record 2,294 of 2,295
==29859==    at 0x4C2DC57: realloc (vg_replace_malloc.c:785)
==29859==    by 0x684FF1F: g_realloc (gmem.c:159)
==29859==    by 0x681DE68: g_array_maybe_expand (garray.c:779)
==29859==    by 0x681E783: g_array_set_size (garray.c:555)
==29859==    by 0x681F328: g_byte_array_set_size (garray.c:1752)
==29859==    by 0x626F143: load_contents_read_callback (gfile.c:6885)
==29859==    by 0x6289129: async_ready_callback_wrapper (ginputstream.c:532)
==29859==    by 0x62B0342: g_task_return_now (gtask.c:1107)
==29859==    by 0x62B0378: complete_in_idle_cb (gtask.c:1121)
==29859==    by 0x684A702: g_main_dispatch (gmain.c:3154)
==29859==    by 0x684A702: g_main_context_dispatch (gmain.c:3769)
==29859==    by 0x684AAAF: g_main_context_iterate.isra.29 (gmain.c:3840)
==29859==    by 0x684ADD1: g_main_loop_run (gmain.c:4034)
==29859==    by 0x402442: test_script_file (test-install-script.c:165)
==29859==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==29859==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==29859==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==29859==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==29859==    by 0x51178EB: srunner_run (check_run.c:782)
==29859==    by 0x40303D: main (test-install-script.c:349)

- - - - -
752353f3 by Christophe Fergeau at 2016-07-01T09:06:42Z
install-script: Fix OsinfoOs leaks

The OsinfoOs instance returned by osinfo_media_get_os must be unref'ed
when no longer needed.

This fixes:

==29859== 3,926 (96 direct, 3,830 indirect) bytes in 1 blocks are definitely lost in loss record 2,286 of 2,295
==29859==    at 0x65E19D0: g_type_create_instance (gtype.c:1854
==29859==    by 0x65C36AA: g_object_new_internal (gobject.c:1781)
==29859==    by 0x65C55ED: g_object_new_valist (gobject.c:2040)
==29859==    by 0x65C58A0: g_object_new (gobject.c:1624)
==29859==    by 0x5339F69: osinfo_os_new (osinfo_os.c:201)
==29859==    by 0x5347FFD: osinfo_loader_get_os (osinfo_loader.c:464)
==29859==    by 0x534B439: osinfo_loader_os (osinfo_loader.c:1410)
==29859==    by 0x534BFB1: osinfo_loader_root (osinfo_loader.c:1599)
==29859==    by 0x534C399: osinfo_loader_process_xml (osinfo_loader.c:1680)
==29859==    by 0x534CFEE: osinfo_loader_process_file_reg_xml (osinfo_loader.c:1877)
==29859==    by 0x534DA1F: osinfo_loader_process_list (osinfo_loader.c:2160)
==29859==    by 0x534DCEA: osinfo_loader_process_path (osinfo_loader.c:2232)
==29859==    by 0x402310: test_script_file (test-install-script.c:146)
==29859==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==29859==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==29859==    by 0x51178EB: srunner_run_tcase (check_run.c:373)
==29859==    by 0x51178EB: srunner_iterate_suites (check_run.c:195)
==29859==    by 0x51178EB: srunner_run (check_run.c:782)
==29859==    by 0x40303D: main (test-install-script.c:349)
==29859==-
==29859== 3,926 (96 direct, 3,830 indirect) bytes in 1 blocks are definitely lost in loss record 2,287 of 2,295
==29859==    at 0x65E19D0: g_type_create_instance (gtype.c:1854)
==29859==    by 0x65C36AA: g_object_new_internal (gobject.c:1781)
==29859==    by 0x65C55ED: g_object_new_valist (gobject.c:2040)
==29859==    by 0x65C58A0: g_object_new (gobject.c:1624)
==29859==    by 0x5339F69: osinfo_os_new (osinfo_os.c:201)
==29859==    by 0x5347FFD: osinfo_loader_get_os (osinfo_loader.c:464)
==29859==    by 0x534B439: osinfo_loader_os (osinfo_loader.c:1410)
==29859==    by 0x534BFB1: osinfo_loader_root (osinfo_loader.c:1599)
==29859==    by 0x534C399: osinfo_loader_process_xml (osinfo_loader.c:1680)
==29859==    by 0x534CFEE: osinfo_loader_process_file_reg_xml (osinfo_loader.c:1877)
==29859==    by 0x534DA1F: osinfo_loader_process_list (osinfo_loader.c:2160)
==29859==    by 0x534DCEA: osinfo_loader_process_path (osinfo_loader.c:2232)
==29859==    by 0x402626: test_script_data (test-install-script.c:199)
==29859==    by 0x5117535: tcase_run_tfun_nofork.isra.9 (check_run.c:390)
==29859==    by 0x51178EB: srunner_iterate_tcase_tfuns (check_run.c:231)
==29859==    by 0x51178EB: srunner_run_tcase (check_run.c:373)

- - - - -
38ac8f24 by Christophe Fergeau at 2016-07-01T09:06:42Z
tools: Fix OsinfoOs leak in osinfo-install-script

The OsinfoOs instance returned by osinfo_media_get_os() must be unref'ed
when no longer needed.
osinfo-install-script has code doing:
if (media == NULL) {
        os = find_os();
} else {
        os = osinfo_media_get_os();
}

find_os() does not return a ref'ed OsinfoOs to the caller, while
osinfo_media_get_os() does. In order to make it possible to release the
ref returned by osinfo_media_get_os(), this commit changes find_os() to
always ref the OsinfoOs instance it returns.

Moreover, one of the codepaths in find_os() looks like it was
potentially returning an invalid pointer:

os = OSINFO_OS(osinfo_list_get_nth(OSINFO_LIST(filteredList), 0));
g_object_unref(filteredList);

The OsinfoOs instance was probably kept alive by references held outside
of the filtered list, but it's safer to keep a reference to ourselves,
which this commit is doing anyway in order to fix find_os() memory
handling.

- - - - -
cdc73317 by Christophe Fergeau at 2016-07-01T09:06:42Z
osinfo: Add GDestroyNotify callback to g_task_return_pointer calls

The GDestroyNotify callback passed to g_task_return_pointer() is used to
free the associated pointer in case g_task_propagate_pointer() is not
called (error cases, _finish() never called, ...).

When the GTask owns the pointer it's passed through
g_task_return_pointer() (for example the _finish() function is (transfer
full) and only calls g_task_propagate_pointer()), we need to set a
GDestroyNotify when calling g_task_return_pointer() or we may have leaks
in corner cases.

- - - - -
e6655895 by Christophe Fergeau at 2016-07-01T09:06:42Z
install-script: Return glib-allocated string from ::apply_xslt()

Strings created by libxml2 should be freed with xmlFree while glib ones
should be freed with g_free, so it's cleaner to allocate the string
returned from ::apply_xslt() with the glib allocator as it's meant to be
g_free'ed later on.

- - - - -
e3627732 by Christophe Fergeau at 2016-07-01T09:14:03Z
test: Remove empty line at end of XML test file

This fixes a make syntax-check failure.

- - - - -
4f2a7937 by Daniel P. Berrange at 2016-07-01T09:18:20Z
Update NEWS for 0.3.1 release

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
0c739241 by Daniel P. Berrange at 2016-07-01T14:46:14Z
Post-release version bump to 1.0.0

Bump major version to reflect that that we're splitting up
the codebase in next release

- - - - -
0263eabf by Marc-André Lureau at 2016-07-04T20:20:54Z
device: add virtio-gpu

virtio-gpu is a non-legacy device, so device_id is always 0x10 + 0x1040.

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>

- - - - -
af14fb13 by Marc-André Lureau at 2016-07-05T11:16:00Z
fedora: Add F24 info & testcases

Fedora 24 with virtio-gpu support.

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>

- - - - -
6a42e799 by Daniel P. Berrange at 2016-07-08T12:41:28Z
Add missing virtio PCI devices

We were missing virtio-rng and virtio-scsi, as well as
all the virtio 1.0 device variants, which have different
PCI IDS

The pci.ids file lists the following known devices

	1000  Virtio network device
	1001  Virtio block device
	1002  Virtio memory balloon
	1003  Virtio console
	1004  Virtio SCSI
	1005  Virtio RNG
	1009  Virtio filesystem
	1041  Virtio network device
	1042  Virtio block device
	1043  Virtio console
	1044  Virtio RNG
	1045  Virtio memory balloon
	1048  Virtio SCSI
	1049  Virtio filesystem
	1050  Virtio GPU
	1052  Virtio input

Of which, only 1001, 1001, 1002 and 1009 were recorded in
libosinfo. They would have appeared via pci.ids file loading,
but they would have lacked friendly names.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
20c91476 by Daniel P. Berrange at 2016-07-08T12:42:35Z
fedora: record when virtio devices were made available

We currently only record virtio-net, virtio-blk data against
Fedora. virtio-9p, virtio-balloon and virtio-console were
also all available in Fedora 9 kernels, with virtio-rng
added in Fedora 10 and virtio-scsi in Fedora 17.

The virtio-1.0 devices all appeared in Fedora 23 guest
kernels

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
dd68d8cc by Daniel P. Berrange at 2016-07-18T10:18:24Z
Fix mingw DLL version after bump to 1.0.0

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
cd51b8ad by Daniel P. Berrange at 2016-07-18T11:36:03Z
Assume availability of gobject introspection during RPM build

The gobject introspection support is available for all
currently targetted platforms, so remove RPM conditionals.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
364ba19d by Daniel P. Berrange at 2016-07-18T13:04:02Z
Remove osinfo-db-validate tool

Remove the osinfo-db-validate tool which is now available
via osinfo-db-tools. Add a RPM dep on osinfo-db-tools to
pull it in for upgradability.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
da709d73 by Daniel P. Berrange at 2016-08-10T08:57:22Z
loader: update to comply with new database install location

The new database locations are

  - System location

    This is determined by the env variable

      $OSINFO_SYSTEM_DIR

    If not set, then defaults to /usr/share/osinfo

    This location is intended for use by operating system
    distributors to install the initial data set via a
    package management system like RPM or Deb

  - Local location

    This is determined by the env variable

      $OSINFO_LOCAL_DIR

    If not set, then defaults to /etc/osinfo

    This location is intended for use by local system
    administrators to install custom local data that
    should be available to all users on a host

  - User location

    This is determined by the env variable

      $OSINFO_USER_DIR

    If not set, then defaults to $XDG_CONFIG_HOME/osinfo

    If that is not set, then defaults to $HOME/.config/osinfo

    This location is intended for use by unprivileged users
    wishing to install local data for use by their applications

Adapt to use those, but include temporary support for looking
at the legacy local & user directory locations, and the
OSINFO_DATA_DIR env variable for back-compat.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
3ed9a1d2 by Daniel P. Berrange at 2016-08-10T08:57:24Z
Remove database files

Remove the database files and add a dependency on the
osinfo-db RPM

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
8ec2de1f by Daniel P. Berrange at 2016-08-10T09:09:17Z
configure: fix accidental break in soname

The change in version from 0.3.0 to 1.0.0 triggered a latent
bug in our code which sets the library soname. This meant we
created libosinfo-1.0.so.1 instead of libosinfo-1.0.so.0

Pull in the fix from libvirt which is where the original logic
was copied from.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
f6a980c7 by Daniel P. Berrange at 2016-08-10T15:24:14Z
spec: display test results on failure

autotools hides detailed test output by default, so we must
cat test-suite.log on failure to actually see what went
wrong.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
ebf6a169 by Daniel P. Berrange at 2016-08-10T15:26:11Z
spec: preserve error exit code on test failure

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
4e0a9642 by Daniel P. Berrange at 2016-08-11T08:40:41Z
spec: fix path to test-suite.log - its in the test subdir

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
808c2900 by Daniel P. Berrange at 2016-10-07T09:59:45Z
Revert "Fix mingw DLL version after bump to 1.0.0"

This reverts commit dd68d8ccb0abb9cab7324da1b3a706dbf158870b.

This is not required after

  commit 8ec2de1ff44e47d189386cb5e83d26521fc76f29
  Author: Daniel P. Berrange <berrange at redhat.com>
  Date:   Wed Aug 10 10:09:17 2016 +0100

    configure: fix accidental break in soname

- - - - -
e086a3da by Daniel P. Berrange at 2016-10-07T11:54:25Z
Refresh PO files from zanata

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
b9c74386 by Daniel P. Berrange at 2016-10-07T15:48:39Z
Update NEWS for 1.0.0

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
acdf74d9 by Daniel P. Berrange at 2016-10-07T16:00:52Z
Post-release version bump

- - - - -
c27c85af by Daniel P. Berrange at 2016-10-10T10:02:20Z
Test suite requires osinfo-db to be installed

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
a11c4f9d by Guido Günther at 2016-10-29T20:39:24Z
examples: avoid PyGIWarning

This fixes

demo.py:3: PyGIWarning: Libosinfo was imported without specifying a version first. Use gi.require_version('Libosinfo', '1.0') before import
to ensure that the right version gets loaded.
  from gi.repository import Libosinfo as osinfo;

- - - - -
a979083f by Guido Günther at 2016-11-05T12:53:22Z
Reenable test suite.

We have osinfo-db in the archive now. Add necessary build-deps for that.

This also reverts commit de2311328f6ecd7e9b2a05d487eef95dd1bdc7f1.

- - - - -
059a0b6b by Guido Günther at 2016-11-05T12:57:31Z
Turn on all hardening flags

- - - - -
1b3d04bb by Guido Günther at 2016-11-05T13:00:57Z
loader: Fix typo in error message

- - - - -
e5e2fb81 by Guido Günther at 2016-11-05T13:08:11Z
d/control: Improve description a bit

- - - - -
d451cf04 by Guido Günther at 2016-11-05T13:12:42Z
Document changes and release 1.0.0-2

- - - - -
00754a50 by Guido Günther at 2016-11-06T14:29:50Z
test-isodetect: extend arch table

Reduces the output a bit when running under G_MESSAGES_DEBUG.

- - - - -
61959720 by Guido Günther at 2016-11-06T14:30:04Z
loader: Fix typo in error message

- - - - -
f2dc9588 by Christophe Fergeau at 2016-12-20T16:38:44Z
win10: Add test cases for recent Windows 10 builds

Recent Windows 10 builds (build 1607) seem to have dropped the J_ at the
beginning of the volume ID.
These additional files make sure we've got test cases for this kind of
win10 ISOs.

- - - - -
a75dc46e by Fabiano Fidêncio at 2016-12-23T08:27:21Z
media: Remove ISO header strings' padding

The strings in the ISO header ("volume-id", "system-id", "publisher-id"
and "application-id") have a predefined size and are padded with spaces,
but nothing in on_{pvd,svd}_read() removes these padding spaces from
those strings, which makes osinfo_media_get_volume_id() always return
[SOME-ISO-LABEL                  ] rather than the expected
[SOME-ISO-LABEL].

Resolves: rhbz#1408271

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reported-by: Allan Day <aday at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
adb54e5d by Fabiano Fidêncio at 2017-01-12T11:55:04Z
fedora: Add F25 data

Signed-off-by: Fabiano Fidêncio <fabianoo at fidencio.org>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
03a3cb47 by Charles Arnold at 2017-02-07T16:10:27Z
opensuse: Add openSUSE Leap 42.2 data

- - - - -
c9d4f430 by Charles Arnold at 2017-02-07T16:10:30Z
suse: Add SLES-12-SP2 data

- - - - -
bb189640 by Charles Arnold at 2017-02-07T16:10:33Z
suse: Add SLED-12-SP2 data

- - - - -
b2574d33 by Daniel P. Berrange at 2017-02-22T17:30:40Z
Disable -Wunsafe-loop-optimizations warnings

This warning option is not reporting broken code. Rather it is merely
identifying loops which GCC would not be able to optimize fully when
using -funsafe-loop-optimizations.  In GCC 7 this triggers on the
loader code

osinfo_loader.c: In function 'osinfo_loader_process_list':
osinfo_loader.c:2127:11: error: missed loop optimization, the loop counter may overflow [-Werror=unsafe-loop-optimizations]
     while (tmp && *tmp) {
           ^

The warning just needs to be turned off since the code is not broken,
and we don't care about the optimization level

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
a1acfe10 by Daniel P. Berrange at 2017-02-23T17:02:40Z
Remove reference to fedorahosted.org in spec files

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
241be1c9 by Roman Bogorodskiy at 2017-02-23T17:07:57Z
Improve Perl-related routines

 * Add a check for the 'perl' program to configure.ac as
   $(PERL) is used in various places
 * Do not hardcode '/usr/bin/perl' in perl scripts
   because on FreeBSD and maybe some other systems it's installed
   in a different prefix, so use '/usr/bin/env perl' instead.

- - - - -
809a5a3a by Pino Toscano at 2017-03-20T21:11:28Z
ubuntu: add Ubuntu 16.10 test data

Acked-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
92447ec1 by Pino Toscano at 2017-03-20T21:11:41Z
mageia: add Mageia 4 and 5 test data

Acked-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
ee34e802 by Guido Günther at 2017-03-20T21:11:45Z
Debian: Update Jessie test data

Acked-by: Fabiano Fidêncio <fabiano at fidnecio.org>

- - - - -
dd729822 by Pino Toscano at 2017-04-18T10:37:21Z
rhel: add RHEL 6.9 and 7.3 test data

- - - - -
7135ccc3 by Pino Toscano at 2017-04-18T10:37:21Z
centos: add CentOS 6.8 and 6.9 test data

- - - - -
29f88aad by Fabiano Fidêncio at 2017-04-21T17:07:21Z
Add 'eject-after-install' parameter to OsinfoMedia

If the media is an installer, thus specifies whether the media should be
ejected after the installation process. Default value is true.

This is mainly needed for applications like GNOME Boxes (and maybe
virt-install) to be able to decide whether the media should be ejected
or not when the final reboot happens during its installation process.

The latter case may happen when the installer leaves some packages to be
installed after rebooting the OS for the last time.

The issue solved by this patch is a corner-case faced when adding the
install scripts for SLES, as during its installation only one reboot is
performed (so, installer-reboots attribute doesn't help us) and the media
must not be ejected after the reboot in order to finish the installation.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Acked-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
37cd9186 by Michal Privoznik at 2017-04-21T22:15:36Z
docs: Fix couple of warnings

Firstly, two functions
(osinfo_install_script_has_config_param_{name,list}) don't
document their arguments.  Secondly, gtk-doc requires enum
documentation to be in one block with no empty lines in it.
Then at last, private enums are marked as <private> not <skip>.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
7a7829d5 by Michal Privoznik at 2017-04-21T22:15:48Z
gitignore: Ignore tags

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
7b671dcc by Daniel P. Berrange at 2017-04-24T08:23:21Z
Remove blank lines at end of file

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
b1a0db7a by Daniel P. Berrange at 2017-04-27T17:02:35Z
Fix error propagation in DB loader

When failing to read the pci/usb ID files we failed to
propagate the reported error.

We also had some dead code which would never be reached
due to earlier gotos.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
a409a71b by Daniel P. Berrange at 2017-04-28T14:31:54Z
Rename test/ to tests/ directory.

To simplify libvirt Jenkins CI setup, rename the test directory
to tests, so its name matches that used in other virt projects.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
b74a005a by Roman Bogorodskiy at 2017-05-02T10:15:48Z
freebsd: add FreeBSD 11.0 isodata

Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>

- - - - -
093d9cb7 by Daniel P. Berrange at 2017-05-02T14:00:11Z
Remove trailing whitespace from FreeBSD 11 data files

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
1ce25c34 by Daniel P. Berrange at 2017-05-02T15:43:34Z
Move FreeBSD 11 data into tests/ subdir

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
e3283549 by Roman Bogorodskiy at 2017-05-02T15:44:07Z
configure: add (usb|pci).ids locations on FreeBSD

Add default locations for usb.ids and pci.ids on FreeBSD,
i.e. paths used when installing this from misc/usbids
and misc/pciids ports.

This way users on FreeBSD don't need to explicitly set
these paths using --with-(usb|pci)-ids-path flag.

- - - - -
81e47825 by Pino Toscano at 2017-05-03T16:45:23Z
ubuntu: add Ubuntu 17.04 test data

Acked-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
ddd7dee2 by Christophe Fergeau at 2017-05-30T09:28:04Z
build: Don't use private headers for gir/vapi generation

Using private headers when generating the gir/vapi files mean that they
are listing private methods which are not exported by the shared
library, as well as types which are not present in public headers, and
not meant to be used by external users.

This was noticed with recent vala.git as it started erroring out on the
ProductForeachFlag which is only defined in osinfo_product_private.h

https://bugzilla.redhat.com/show_bug.cgi?id=1456709

- - - - -
b0fddfe6 by Guido Günther at 2017-07-11T06:19:09Z
tests: add Debian 9.0 test data

- - - - -
85a58d74 by Pino Toscano at 2017-07-12T17:21:59Z
fedora: add Fedora 26 test data

- - - - -
bf3f23bf by Guido Günther at 2017-07-12T18:23:11Z
test-isodetect: fix parsing of application, system and publisher id

- - - - -
14e84ccc by Guido Günther at 2017-07-13T16:48:26Z
test-isodetect: add Debian's arm flavours

to avoid "Unknown arch" debug messages

- - - - -
8ed2b8c0 by Roman Bogorodskiy at 2017-08-02T09:38:29Z
freebsd: add FreeBSD 11.1 isodata

Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>

- - - - -
86e9ca2e by Pino Toscano at 2017-08-02T09:38:29Z
mageia: add Mageia 6 test data

- - - - -
4c9c7185 by Pino Toscano at 2017-08-02T09:38:29Z
tests: test-mediauris: skip non-http URLs

The test uses libsoup, which supports only HTTP, and not other
protocols such as FTP.  Hence, allow only http and https URLs.

- - - - -
e9fd1baf by Pino Toscano at 2017-08-02T09:38:29Z
tests: test-mediauris: show status code on failure

It helps when debugging failures, to check what is actual error for an
URL.

- - - - -
b9aaafc4 by Pino Toscano at 2017-08-02T09:41:31Z
tests: make the network tests run

Load the default osinfo path, since the osinfo data are no more part of
the libosinfo sources.

The tests still fails though, but this is due to missing paths to ISOs
and trees.

- - - - -
1b142e9c by Pino Toscano at 2017-08-03T14:59:48Z
rhel: add RHEL 7.4 test data

- - - - -
5c929b0f by Daniel P. Berrange at 2017-08-10T14:47:50Z
Run glib-mkenums in en_US.UTF-8 locale

The new python based glib-mkenums crashes if run in the C
locale as python is (incorrectly) not 8-bit clean when
processing input.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
6b5d3f9f by Daniel P. Berrange at 2017-08-14T09:47:43Z
Unset LC_ALL, as LC_CTYPE doesn't override a previous LC_ALL setting

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
d01ddf90 by Daniel P. Berrange at 2017-08-15T10:26:52Z
Update NEWS for 1.1.0 release

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
a15586fd by Daniel P. Berrange at 2017-08-15T10:49:57Z
Post-release version bump

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
349b18f7 by Guido Günther at 2017-08-19T20:23:01Z
Upstream moved from fedorahosted to pagure

- - - - -
0dfd210f by Guido Günther at 2017-08-19T20:30:07Z
Use vcs-upstream-tag

- - - - -
2fbf08c3 by Guido Günther at 2017-08-19T20:30:22Z
New upstream version 1.1.0
- - - - -
e27573d7 by Guido Günther at 2017-08-19T20:34:01Z
Update upstream source from tag 'upstream/1.1.0'

Update to upstream version '1.1.0'
with Debian dir 0d79cfb9ac429c62f3bb7fa60c467d0f7a304fdc

- - - - -
4921ed0d by Guido Günther at 2017-08-19T20:34:27Z
libtool is sufficient

no need for libtool-bin.

Thanks: Helmut Grohne
Closes: #871703

- - - - -
c501be82 by Guido Günther at 2017-08-19T20:37:24Z
Drop loader-Fix-typo-in-error-message.patch: applied upstream

- - - - -
911d9a39 by Guido Günther at 2017-08-19T21:00:47Z
Bump sumbols

- - - - -
764448c1 by Guido Günther at 2017-08-19T21:00:47Z
Bump standards version

- - - - -
27a4fe09 by Guido Günther at 2017-08-19T21:01:08Z
Document changes and release 1.1.0-1

- - - - -
b61be040 by Pino Toscano at 2017-10-16T09:12:22Z
Switch from libsoup to libcurl

libsoup is used to check the validity of URLs in distributions in
osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to
that protocol.

To overcome this limitation, switch to libcurl: while it requires
slightly more code to do the same task, it provides a bit more
flexibility, and support for other protocols.  No version check is
performed, since the APIs used are old enough.

Adapt also the README, and the packaging files.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
93c54a31 by Pino Toscano at 2017-10-16T09:12:27Z
Revert "tests: test-mediauris: skip non-http URLs"

Now that test-mediauris uses libcurl, it can handle protocols different
than http(s), like ftp, just fine.

This reverts commit 4c9c7185475a9739af51a9fc680e5b8a97055467.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
8a19e519 by Pino Toscano at 2017-10-16T09:12:30Z
tests: test-mediauris: raise timeout to 5 minutes

With the growing amount of distros in osinfo-db, the test takes more
and more time to complete, hitting the 2 minutes timeout in case of any
network hiccup (or simply when a server takes more time to reply).

Hence, raise the timeout to 5 minutes, which ought to be enough now.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
641ded14 by Pierre-Alain TORET at 2017-10-16T09:12:32Z
openbsd: add OpenBSD 6.0 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
1b6c5f27 by Pierre-Alain TORET at 2017-10-16T09:12:36Z
openbsd: add OpenBSD 6.1 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
593a20ae by Pierre-Alain TORET at 2017-10-16T09:12:39Z
openbsd: add OpenBSD 6.2 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
5a741552 by Pierre-Alain TORET at 2017-10-18T09:02:27Z
openbsd: add OpenBSD 5.9 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>

- - - - -
206a5445 by Pino Toscano at 2017-10-19T10:56:12Z
build: fix disabling of tests

Actually use the result of the configure switch --enable-tests, enabling
or disabling the tests accordingly.

Signed-off-by: Pino Toscano <ptoscano at redhat.com>
Reviewed-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
cc5be3ae by Pino Toscano at 2017-10-19T10:56:20Z
build: make curl optional, and only for tests

Look for curl only when the tests are enabled, and as optional build
dependency.  If curl is missing, then the two network tests are not
built.  Also, limit the use of curl CFLAGS/LIBS only for the tests that
really need it.

As side result, it is possible to drop the curl BuildRequires from the
mingw spec, as it builds with --enable-tests=no.

Signed-off-by: Pino Toscano <ptoscano at redhat.com>
Reviewed-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
e51865eb by Pino Toscano at 2017-10-19T10:56:33Z
tests: convert from check to the GLib testing framework

GLib has shipped a testing framework for many years already, so we can
make use of it, replacing the external "check".

The conversion only switches framework without changing the structure of
the tests, making use of the more appropriate assertion in the various
places.

Signed-off-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
0520470d by Roman Bogorodskiy at 2017-10-20T08:34:39Z
freebsd: Add FreeBSD 10.4 isodata

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
f11a191c by Pavel Hrdina at 2017-11-01T13:54:48Z
tests: get the curl response code every time

This failed on FreeBSD with following error:

../../tests/test-mediauris.c:47:13: error: variable 'response_code' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

Reviewed-by: Daniel P. Berrange <berrange at redhat.com>
Signed-off-by: Pavel Hrdina <phrdina at redhat.com>

- - - - -
25a4aa05 by Pavel Hrdina at 2017-11-01T14:21:09Z
tests: get the curl response code every time (more)

This failed on FreeBSD with following error:

../../tests/test-treeuris.c:47:13: error: variable 'response_code' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
9955c547 by Debarshi Ray at 2017-11-06T13:40:26Z
Marginally simplify the code to create and run a GMainLoop

Even though g_main_loop_new accepts a is_running parameter, it isn't
very important since g_main_loop_run will set it to TRUE anyway. There
is no requirement that it should be set before calling g_main_loop_run.
The vast majority of GMainLoop users simply ignore the is_running
parameter unless they are doing something out of the ordinary.

- - - - -
75c19ba9 by Christophe Fergeau at 2017-11-06T13:40:26Z
tests: Add test case for Windows 10 1709 builds

These are currently missing from osinfo-db

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

https://bugzilla.redhat.com/show_bug.cgi?id=1509387

- - - - -
862b8c4b by Zeeshan Ali at 2017-11-22T18:10:17Z
Drop redundant 'const' keyword from object parameters

Use of 'const' parameter on object parameters is redundant, inconsistent
(both internally and against other GObject libraries) and currently breaks
the low-level Rust binding generator:

https://github.com/gtk-rs/glib/pull/249

Signed-off-by: Zeeshan Ali <zeeshan at kinvolk.io>

- - - - -
af47d32b by Pino Toscano at 2017-11-29T17:07:05Z
ubuntu: add Ubuntu 17.10 test data

Signed-off-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
03f4b905 by Daniel P. Berrange at 2017-12-04T16:45:30Z
Refresh translations from zanata

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

- - - - -
4ba5728d by Christophe Fergeau at 2018-01-15T12:07:00Z
test-isodetect: Improve error message on detection failures

Since the switch to the GTest framework, when the test suite fails to
identify an ISO, the error message is:
ERROR:test-isodetect.c:359:test_one: 'matched' should be TRUE
while it used to be the much more explicit:
ERROR **: ISO alpine-extended-3.7.0_rc2-x86_64.iso.txt was not matched by OS alpinelinux3.7

This commit readds the explicit message on this particular failure.

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
7c3ad866 by Felipe Borges at 2018-02-14T12:34:13Z
freedos: add freedos 1.2 test data

- - - - -
fd208b43 by Felipe Borges at 2018-02-15T08:52:06Z
opensuse: add OpenSUSE Leap 42.3 test data

- - - - -
24440199 by Christophe Fergeau at 2018-02-16T10:25:38Z
NetBSD: add NetBSD 6.x and 7.x tests isodata

Based on a patch from Vicente Chaves de Melo <vchaves at ymail.com>

- - - - -
da9e4887 by Christophe Fergeau at 2018-02-19T09:12:01Z
test-isodetect: Iterate over all isodata/ subdirs

When adding support for a new vendor, test-isodetect.c needs to be
updated to list it, which is too easy to forget.
This commit iterates over subdirs in tests/isodata/ and uses these as
the vendors to test for. This means no further modification of
test-isodetect.c is needed when adding a new vendor.

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
6103f7fa by Daniel P. Berrangé at 2018-02-23T11:34:29Z
m4: turn off -Wfunction-cast-type warning flag from gcc8

GCC 8 adds -Wfunction-cast-type to -Wextra, but this breaks when using
G_DEFINE_TYPE which does so called "bad" function casts.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
ec4fb588 by Christophe Fergeau at 2018-03-11T17:41:04Z
tests: Remove calls to g_log_set_always_fatal()

All tests call that method because they want g_warning() to be fatal.
Since the switch to GTest, this is no longer necessary as this is the
default  behaviour.

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
e6e33024 by Felipe Borges at 2018-03-11T19:41:51Z
pop_os: add Pop!_OS test data

Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
77d71d08 by Felipe Borges at 2018-03-11T19:41:51Z
windows: add win2k16 test data

Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
03398308 by Charles Arnold at 2018-03-11T19:41:51Z
sles: add SLE12 SP3 ISO Information

Add SLE12 SP3 ISO Information

Signed-off-by: Charles Arnold <carnold at suse.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
d3acf865 by Pierre-Alain TORET at 2018-03-11T19:41:51Z
fedora: add Fedora 27 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
55504f7c by Pierre-Alain TORET at 2018-03-18T19:27:13Z
fedora27: Add Atomic Workstation isodata

Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
aa06a8b2 by Daniel P. Berrangé at 2018-03-18T19:30:53Z
loader: process files in alphabetical order

Currently when loading DB files we process them in whatever order
readdir() returns them in, which is often inode order. This makes the
order of loading files non-deterministic across installs, and if there
are ambiguities in the data, we can in turn get different results.
eg ISO images match different OS entries depending on load order.

Alphabetically sorting the files doesn't remove any ambiguity that
may exist, but at least gives us consistent results on every host.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
f0b54300 by Vincent at 2018-04-10T09:39:59Z
asianux: add Asianux isodata

Signed-off-by: Vincent <vincent.dao at asianux.com>

- - - - -
1a907776 by Natanael Copa at 2018-04-10T09:39:59Z
alpinelinux: add Alpine Linux isodata

Signed-off-by: Natanael Copa <ncopa at alpinelinux.org>
Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
ab3f78d8 by Pierre-Alain TORET at 2018-04-10T09:39:59Z
openbsd: add OpenBSD 6.3 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>

- - - - -
f7d8a089 by Christophe Fergeau at 2018-04-10T10:36:15Z
loader: Fix leak in osinfo_loader_find_files()

'tmp' is used to iterate over the list of files, so it will be NULL at
the end of the iteration, and g_list_free() will be a no-op.
The initial list is stored in 'children', so free that instead.

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
fb26c24a by Fabiano Fidêncio at 2018-04-23T22:49:37Z
opensuse-42.3: Add "Network Image" isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Charles Arnold <carnold at suse.com>

- - - - -
74dcc9b4 by Fabiano Fidêncio at 2018-04-23T22:50:11Z
tumbleweed: Add "Network Image" isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Charles Arnold <carnold at suse.com>

- - - - -
3182ab0e by Fabiano Fidêncio at 2018-04-23T22:50:15Z
tumbleweed: Add "Kubic DVD/USB Stick" isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Charles Arnold <carnold at suse.com>

- - - - -
917ade1c by Felipe Borges at 2018-05-02T17:51:32Z
rhel: Add RHEL 7.5 isodata

Signed-off-by: Felipe Borges <feborges at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
106d8690 by Andrea Bolognani at 2018-05-04T14:22:13Z
rhel: Fix isodata for RHEL 7.5 on ppc64le

There is a spurious empty line at the end of the file that
causes 'make syntax-check' to fail with:

  [...]
  tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
  maint.mk: empty line(s) or no newline at EOF
  make: *** [maint.mk:927: sc_prohibit_empty_lines_at_EOF] Error 1

Get rid of it to solve the issue.

See also

  https://ci.centos.org/view/libvirt/job/libosinfo-master-syntax-check/123/

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Signed-off-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
fbfd66ba by Andrea Bolognani at 2018-05-08T13:41:56Z
maint: Rename autobuild.sh to prepare-release.sh

The script was originally used by the Test::AutoBuild
project to perform periodic automatic builds; however, that
effort has been abandoned a long time ago, and these days
libosinfo CI builds are happening on the Jenkins-based
CentOS CI environment under the libvirt umbrella[1], where
build recipes are maintained separately from the projects
themselves.

The script is still used to prepare releases, so it can't
be dropped from the repository: rename it so that its
purpose is more clearly communicated instead.

[1] https://ci.centos.org/view/libvirt/

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Signed-off-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
d829b942 by Andrea Bolognani at 2018-05-08T13:42:06Z
prepare-release: Drop references to Test::AutoBuild

They are misleading, and no longer relevant anyway.

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Signed-off-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
25b5bc35 by Andrea Bolognani at 2018-05-08T13:42:11Z
spec: Drop %{extra_release}

It was mainly meant to be used for automatic builds through
Test::AutoBuild, so it can be removed now.

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Signed-off-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
ca57ccbd by Daniel P. Berrangé at 2018-05-08T13:42:15Z
configure: fix HAVE_CURL conditional on Win32

AM_CONDITIONAL lines must always be executed, but HAVE_CURL was inside
an "if ...", which caused configure to fail when run on Win32.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
5e25cf65 by Andrea Bolognani at 2018-05-10T08:57:46Z
autogen: Don't hardcode --enable-gtk-doc

The usual behavior is for configure to detect the availability
of gtk-doc, along with other optional features, and only enable
it if found.

Hardcoding it this way is causing issues for MinGW builds,
where pkg-config is looking in the MinGW-specific paths and
can't locate the native gtk-doc.pc file, thus concluding
gtk-doc must not be present and aborting the build altogether
instead of simply skipping API reference generation.

Both 'make distcheck' (through the DISTCHECK_CONFIGURE_FLAGS
variable) and the prepare-release.sh script are already
enforcing the availability of gtk-doc when preparing releases,
so it's safe to use the default behavior for regular builds.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
481c3a32 by Andrea Bolognani at 2018-05-12T10:20:09Z
tools: Fix compilation with Clang 6

Clang 6 doesn't like the way the last item in a GOptionEntry
array is initialized:

  ../../tools/osinfo-install-script.c:87:12: error: missing field
  'short_name' initializer [-Werror,-Wmissing-field-initializers]
      { NULL }
             ^
  1 error generated.
  gmake[2]: *** [Makefile:540: osinfo-install-script.o] Error 1
  gmake[2]: *** Waiting for unfinished jobs....
  ../../tools/osinfo-detect.c:104:12: error: missing field
  'short_name' initializer [-Werror,-Wmissing-field-initializers]
      { NULL }
             ^
  1 error generated.
  gmake[2]: *** [Makefile:540: osinfo-detect.o] Error 1

Fix the issue by using the { 0 } initializer instead.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
Reviewed-by: Eric Blake <eblake at redhat.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
fce35487 by Pierre-Alain TORET at 2018-05-12T15:34:02Z
netbsd: Add NetBSD 7.1.2 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
e65cd1da by Fabiano Fidêncio at 2018-05-14T12:34:25Z
fedora: Add f28 isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
6a88a781 by Fabiano Fidêncio at 2018-05-31T19:18:20Z
tests: Add test-os-resources

test-os-resources has been written to avoid bug as having minimum
resources greater than the recommended resources in osinfo-db.

This problem was exposed by RHEL/CentOS data files, which caused some
really bad UI effect in clientes using those two attributes (as GNOME
Boxes).

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
2f4ab3f4 by Fabiano Fidêncio at 2018-05-31T19:18:35Z
opensuse: Add Leap 15.0 isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
ba054e4e by Fabiano Fidêncio at 2018-06-07T20:43:20Z
syms: Fix identation of 0.2.13 symbols

When adding the symbols for LIBOSINFO_0.2.13 I mistakenly added the
symbols not respecting default identation used (1 tab) and ended up
using 4 spaces instead.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

- - - - -
cf827433 by Fabiano Fidêncio at 2018-06-07T20:43:23Z
syms: Add missing "global" on 0.2.[7-10] versions

Reported-by: Michal Privoznik <mprivozn at redhat.com>
Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

- - - - -
545c695b by Fabiano Fidêncio at 2018-06-12T13:42:06Z
silverblue: Move isodata to its own folder

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
24f879d6 by Daniel P. Berrangé at 2018-06-20T09:40:14Z
Update NEWS for 1.2.0 release

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
d26612fb by Daniel P. Berrangé at 2018-06-20T09:49:44Z
Post release version bump

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
4ab6fe09 by Roman Bogorodskiy at 2018-07-03T20:28:20Z
freebsd: add FreeBSD 11.2 isodata

Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
7fe79d2c by Věra Cholasta at 2018-07-18T08:39:44Z
Add test files for Alpinelinux 3.8

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
3e86f56b by Charles Arnold at 2018-07-18T21:42:36Z
sles: Add SLE15 ISO Information

Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
dd05e683 by Věra Cholasta at 2018-07-18T21:42:36Z
rhel: Add RHEL6.10 iso test files

Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
4b22951d by Pierre-Alain TORET at 2018-07-20T08:13:49Z
dragonflybsd : Add DragonFlyBSD 5.x isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
91e9e7cc by Věra Cholasta at 2018-07-20T08:14:10Z
ubuntu: Add test files for Ubuntu18.04

Reviewed-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
dbf196a2 by Pierre-Alain TORET at 2018-07-24T09:01:01Z
netbsd: Add NetBSD 8.0 isodata

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
8bdfeff3 by Daniel P. Berrangé at 2018-09-05T09:07:33Z
Refresh translations from zanata

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
fc431d26 by Fabiano Fidêncio at 2018-09-06T06:19:00Z
loader: Replace strcmp() with g_str_equal()

https://bugzilla.redhat.com/show_bug.cgi?id=1335291

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
b7faaf96 by Fabiano Fidêncio at 2018-09-06T06:19:00Z
osinfo-detect: Replace strcmp() with g_str_equal()

https://bugzilla.redhat.com/show_bug.cgi?id=1335291

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
3ff066cb by Fabiano Fidêncio at 2018-09-06T06:19:00Z
maint.mk: Re-enable sc_prohibit_strcmp

https://bugzilla.redhat.com/show_bug.cgi?id=1335291

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
e22e1518 by Fabiano Fidêncio at 2018-09-06T06:19:00Z
maint.mk: Adjust sc_prohibit_strcmp

- There's no need to exclude STRN?EQ as those are not defined in
libosinfo;
- Adjust the comment and the halt message to suggest the usage of
g_str_equal() instead of the non existent STRN?EQ();

https://bugzilla.redhat.com/show_bug.cgi?id=1335291

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
ba57c18d by Fabiano Fidêncio at 2018-09-06T06:19:00Z
rhel-atomic: Add missing 7.2 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
3e153644 by Fabiano Fidêncio at 2018-09-06T06:19:00Z
rhel-atomic: Add 7.3 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
4dba904e by Fabiano Fidêncio at 2018-09-06T06:19:00Z
rhel-atomic: Add 7.4 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
fbdc7520 by Fabiano Fidêncio at 2018-09-07T07:09:56Z
gitignore: Add test-os-resources

test-os-resources has been added as part of 6a88a78143.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
857f503f by Fabiano Fidêncio at 2018-09-07T07:16:32Z
win10: Add LTSB Evaluation isodata

https://bugzilla.redhat.com/show_bug.cgi?id=1139394

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
b6cab49e by Fabiano Fidêncio at 2018-09-07T07:17:12Z
popos: Add 18.04 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
b9538712 by Fabiano Fidêncio at 2018-09-07T07:17:45Z
centos7: Add LiveGNOME isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
21b36fc8 by Fabiano Fidêncio at 2018-09-07T07:17:52Z
centos7: Add LiveKDE isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
5562da00 by Fabiano Fidêncio at 2018-09-07T07:17:56Z
centos7: Add another "DVD" isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
e6897cdb by Fabiano Fidêncio at 2018-09-07T07:18:00Z
centos7: Add another "DVD" isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
30cf6411 by Fabiano Fidêncio at 2018-09-07T07:18:04Z
centos7: Add "Minimal" isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
241c8809 by Fabiano Fidêncio at 2018-09-07T07:18:07Z
centos7: Add "NetInstall" isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
b9cb2278 by Fabiano Fidêncio at 2018-09-11T20:14:33Z
tests: Expand the arch's parser for isodetect

Some Windows ISOs isodata, as the ones added as part of commit 857f503,
uses X64 and X86 and load_iso() didn't take those into consideration.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
e6168463 by Fabiano Fidêncio at 2018-09-11T20:14:57Z
db: Force anchored patterns when matching regex

Without forcing anchored patterns some matches may be completely wrong
as "(J_)?CENN?A_X64FREV" (volume-id for Windows 10) that could be taken
as a match for "HRM_CENNA_X64FREV" (volume-id of a Windows 8 ISO).

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
4850bef2 by Fabiano Fidêncio at 2018-09-11T20:16:03Z
openbsd: Add 5.1 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
049fc58a by Fabiano Fidêncio at 2018-09-11T20:16:08Z
openbsd: Add 5.2 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
5a7e9f9a by Fabiano Fidêncio at 2018-09-11T20:16:11Z
openbsd: Add 5.3 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
08b97854 by Fabiano Fidêncio at 2018-09-11T20:17:31Z
haiku: Add R1/Alpha1 isodata

https://bugzilla.redhat.com/show_bug.cgi?id=1092627

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
16687f24 by Fabiano Fidêncio at 2018-09-11T20:17:40Z
haiku: Add R1/Alpha2 isodata

https://bugzilla.redhat.com/show_bug.cgi?id=1092627

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
5e6ecad5 by Fabiano Fidêncio at 2018-09-11T20:17:42Z
haiku: Add R1/Alpha3 isodata

https://bugzilla.redhat.com/show_bug.cgi?id=1092627

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
200ea8c0 by Fabiano Fidêncio at 2018-09-11T20:17:44Z
haiku: Add R1/Alpha4.1 isodata

https://bugzilla.redhat.com/show_bug.cgi?id=1092627

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
58d999e1 by Fabiano Fidêncio at 2018-09-11T20:17:47Z
haiku: Add Nightly isodata

https://bugzilla.redhat.com/show_bug.cgi?id=1092627

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
49bc9c89 by Guido Günther at 2018-09-17T07:23:19Z
d/control: swith VCS-* URLs to salsa

- - - - -
91628ff3 by Guido Günther at 2018-09-17T07:26:11Z
New upstream version 1.2.0
- - - - -
005c7b19 by Guido Günther at 2018-09-17T07:29:08Z
Update upstream source from tag 'upstream/1.2.0'

Update to upstream version '1.2.0'
with Debian dir b6105ac80290aeea01b9a2a3584fa090c084cb47

- - - - -
7fb3006f by Guido Günther at 2018-09-17T07:29:33Z
d/control: Drop build-dep libsoup-gnome-2.4

Thanks: Jeremy Bicha

- - - - -
32aea210 by Guido Günther at 2018-09-17T07:45:22Z
d/control: Switch to priority optional

- - - - -
7969c694 by Guido Günther at 2018-09-17T08:00:02Z
d/copyright: Avoid duplicate license paragraph

- - - - -
e9e08534 by Guido Günther at 2018-09-17T08:00:02Z
d/control: Bump standards version

- - - - -
2ba6951e by Guido Günther at 2018-09-17T08:00:02Z
debian/copyright: Fix upstream URL

Project moved to gitlab.

Thanks: Jeremy Bicha

- - - - -
ecacfc85 by Guido Günther at 2018-09-17T08:00:36Z
d/control: Move l10n package to localization section

- - - - -
dbf12226 by Guido Günther at 2018-09-17T08:00:55Z
Document changes and release 1.2.0-1

- - - - -
62b74c97 by Christophe Fergeau at 2018-09-21T06:21:55Z
loader: Rename OSINFO_ERROR to OSINFO_LOADER_SET_ERROR

This will be useful in the following commits where another OSINFO_ERROR
 #define will be introduced

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
90e65193 by Christophe Fergeau at 2018-09-21T06:22:45Z
loader: Use OSINFO_LOADER_SET_ERROR in a few more places

There are 2 calls to g_set_error(err, "%s", "constant string"); which
can be replaced with OSINFO_LOADER_SET_ERROR

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
7aef00fd by Christophe Fergeau at 2018-09-21T06:23:21Z
loader: Introduce OSINFO_ERROR

Since glib commit 2.31.10~16 [1], g_set_error() will issue a warning if
it's passed a NULL domain. libosinfo is doing this in a few places (try
for example 'osinfo-query os winxp'). This commit adds a generic OSINFO_ERROR
domain which will be used instead of NULL. It's a bit inconsistent with
OSINFO_MEDIA_ERROR and OSINFO_TREE_ERROR in that they both start with
"osinfo-*" while OSINFO_ERROR uses "libosinfo". However, since
OsinfoLoader already makes use of that quark, changing that would
arguably be an (very small) ABI break.

[1] https://gitlab.gnome.org/GNOME/glib/commit/6d9f874330

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
16321d0f by Christophe Fergeau at 2018-09-21T06:26:46Z
Use OSINFO_ERROR in more places

Passing a NULL error domain will trigger runtime warnings from glib.

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
e43b3f8a by Christophe Fergeau at 2018-09-21T06:26:55Z
install-script: Use g_set_error_literal where appropriate

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
9bd72383 by Christophe Fergeau at 2018-09-21T06:27:00Z
install-script: Add propagate_libxml_error() helper

This simplifies the code a bit.

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
93513264 by Fabiano Fidêncio at 2018-09-21T09:37:54Z
ubuntu: Add isodata for 18.10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
25057a35 by Fabiano Fidêncio at 2018-09-24T12:24:25Z
centos: Add 6.10 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
88747764 by Charles Arnold at 2018-10-03T20:15:59Z
Add SUSE CaaS Platform 1.0 isodata

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
d8622424 by Charles Arnold at 2018-10-03T20:16:13Z
Add SUSE CaaS Platform 2.0 isodata

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
d09ba2ab by Charles Arnold at 2018-10-03T20:16:17Z
Add SUSE CaaS Platform 3.0 isodata

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
2662c610 by Fabiano Fidêncio at 2018-10-08T13:06:47Z
Revert "db: Force anchored patterns when matching regex"

Daniel suggested that the fix should go to the osinfo-db entries that
are causing the issue instead of forcing anchored patterns in libosinfo.

This reverts commit e6168463f4fc659b9827b5c8694dc1c6d7d5239a.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
290b7484 by Fabiano Fidêncio at 2018-10-09T15:11:16Z
authors,maintainers: Add all gitlab's group members

Let's update the list of authors/maintainers accordingly to the
libosinfo's gitlab group members[0].

The list has been put in alphabetical order on purpose.

[0]: https://gitlab.com/groups/libosinfo/-/group_members

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
32e68971 by Fabiano Fidêncio at 2018-10-09T15:11:49Z
fedora: Add fedora29 (Beta) isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
ed8aaab1 by Fabiano Fidêncio at 2018-10-09T15:12:11Z
silverblue: Add silverblue29 (Beta) isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
b1718147 by Fabiano Fidêncio at 2018-10-15T13:21:51Z
Remove FSF address from source files

Let's follow what's already done for the most part of libosinfo and
recommended from http://www.gnu.org/licenses/gpl-howto.html and do not
put FSF address in the source files. Instead, just link to FSF website.

Based on:
https://gitlab.com/libosinfo/libosinfo/commit/3343d0f9c1b0937824bee2527612047bc2e75f84

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
3e2190ba by Věra Cholasta at 2018-10-18T14:10:30Z
test-isodetect: replace while loop with for loop

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
cc6dac84 by Věra Cholasta at 2018-10-18T14:10:44Z
test-isodetect: continue after failure

https://bugzilla.redhat.com/show_bug.cgi?id=1639108

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
c4f85e71 by Alexey Shabalin at 2018-10-19T15:53:11Z
alt: Add alt8.X, alt.p8 and alt.sisyphus isodata

Signed-off-by: Alexey Shabalin <shaba at altlinux.org>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
f88aae82 by Fabiano Fidêncio at 2018-11-01T15:51:30Z
tests: Update f29 isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Felipe Borges <feborges at redhat.com>

- - - - -
63c9e338 by Fabiano Fidêncio at 2018-11-01T15:51:44Z
tests: Update silverblue29 isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Felipe Borges <feborges at redhat.com>

- - - - -
99c5f0e4 by Felipe Borges at 2018-11-01T16:26:57Z
rhel: Add rhel7.6 isodata

Signed-off-by: Felipe Borges <feborges at redhat.com>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
300c4a95 by Fabiano Fidêncio at 2018-11-08T10:30:52Z
os: Don't leak scripts list

osinfo_list_get_elements() calls g_hash_table_get_values() which returns
a GList that must be freed after used.

For more info, please, refer to:
https://developer.gnome.org/glib/unstable/glib-Hash-Tables.html#g-hash-table-get-values

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
ca410f9f by Vera Cholasta at 2018-11-09T10:01:34Z
tests: continue after failure in mediauris & treeuris

https://bugzilla.redhat.com/show_bug.cgi?id=1639108

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
2f4847e6 by Vicente Chaves de Melo at 2018-11-15T21:18:40Z
NetBSD: add NetBSD 7.2 tests isodata

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
1e49fb06 by Fabiano Fidêncio at 2018-11-16T07:39:42Z
ubuntu18.10: Update isodata after release

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Didier Roche <didier.roche at canonical.com>

- - - - -
a26248be by Fabiano Fidêncio at 2018-11-16T07:54:52Z
ubuntu: Add 19.04 prerelease isodata

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>

- - - - -
b5274811 by Fabiano Fidêncio at 2018-11-16T10:15:13Z
rhel: Add rhel8.0 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
1040cf3f by Fabiano Fidêncio at 2018-11-16T10:54:27Z
test-os-resources: Fix typo in test_minimum_recommended_resources()

Thanks to this typo the test was iterating over a single OS, always.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Felipe Borges <feborges at redhat.com>

- - - - -
d5d60a01 by Fabiano Fidêncio at 2018-11-16T11:10:22Z
test-os: move test-os-resources tests

Let's have all OS related tests grouped together.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Felipe Borges <feborges at redhat.com>

- - - - -
4a0a1f3b by Fabiano Fidêncio at 2018-11-16T11:10:25Z
popos: Add popos18.10 isodata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Felipe Borges <feborges at redhat.com>

- - - - -
c1c112b1 by Fabiano Fidêncio at 2018-11-16T13:22:07Z
os: Deal with "maximum" resources

In the samw way OSes have minimum and recommended resources, let's add
support for "maximum" resources.

https://gitlab.com/libosinfo/osinfo-db/issues/11

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

- - - - -
17d14dd6 by Fabiano Fidêncio at 2018-11-16T13:22:13Z
test-os: Make test_resources_minimum_recommended generic

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

- - - - -
57f7815a by Fabiano Fidêncio at 2018-11-16T13:22:13Z
test-os: Cover maximum resources in tests

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

- - - - -
6b246cd9 by Fabiano Fidêncio at 2018-11-19T10:10:35Z
test-os: Fix test breakage

"for" loop initial declarations are only allowed in C99 mode but some
old compilers (like the ones in centos7 or debian8) just don't use it by
default.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
5bef741c by Fabiano Fidêncio at 2018-11-19T10:21:45Z
test-os: Add test_resources_uniqueness

This test enforces that we'll never have more than one resources entry
for the very same architecture in an OS entry.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
4c922488 by Fabiano Fidêncio at 2018-11-19T11:07:16Z
test-os: Add test_devices_duplication()

As devices are inherited from entries that "derives-from" or "clones"
any other entries, there's no reason to keep declaring those devices in
several places.

By adding this test, hopefully there'll be no more devices duplication
from now on.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
2d1ec04f by Fabiano Fidêncio at 2018-11-19T11:58:12Z
devicelinklist: Fix _get_devices()

osinfo_devicelinklist_get_devices() returns a list of OsinfoDevice
structs and in order to do so it has to iterate over the list of
OsinfoDeviceLink structs and get the device associated to each of the
OsinfoDeviceLink struct.

The current implementation was just trying to add the OsinfoDeviceLink
struct to the list, instead of getting the devices associated to it.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
673ae80a by Fabiano Fidêncio at 2018-11-19T12:11:59Z
tests: Add basic tests for devicelinklist

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
c38167a4 by Fabiano Fidêncio at 2018-11-19T12:12:08Z
test-devicelinklist: Add _get_devices() test

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
2c7855b1 by Fabiano Fidêncio at 2018-11-19T12:12:08Z
test-os: Add test_devices_inheritance_basic()

Devices are inherited from OSes that derives-from/clones some other OS.
Let's have a test case to ensure it's not going to break in the future.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
79d0039b by Fabiano Fidêncio at 2018-11-19T12:12:08Z
loader: Deal with "removed" devices for an OS

Let's make the loader aware of the "removed" attribute that can be set
for a device linked from an OS entry.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
46f2413c by Fabiano Fidêncio at 2018-11-19T12:12:08Z
os: Add osinfo_os_get_all_device_links()

This function is a helper for the commits that are about come related to
properly dealing with "removed" devices.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
9c9c7cee by Fabiano Fidêncio at 2018-11-19T12:12:08Z
os: Add osinfo_os_get_devices_internal()

The addition of this new function is basically preparing the ground for
the changes that are coming in the next commits where
osinfo_os_get_devices() will have to deal with "removed" devices.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
66bde062 by Fabiano Fidêncio at 2018-11-19T12:12:08Z
os: Add osinfo_os_get_device_links_internal()

The addition of this new function is basically preparing the ground for
the changes that are coming in the next commits where
osinfo_os_get_device_links() will have to deal with "removed" devices.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
0ae11ebf by Fabiano Fidêncio at 2018-11-19T12:12:08Z
os: Add osinfo_os_get_all_device_links_internal()

The addition of this new function is basically preparing the ground for
the changes that are coming in the next commits where
osinfo_os_get_all_device_links() will have to deal with "removed"
devices.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
29ca664b by Fabiano Fidêncio at 2018-11-19T12:12:08Z
os: Use get_devices_internal in _get_all callback

This commit is just preparing the ground for changes that will come in
the next commits where we'll start supporting "removed" devices and in
order to so, we'll have to explicitly call _get_devices_internal()
forcing it to return *all* devices, even the "removed" ones, as they'll
be filtered out later.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
2425d97c by Fabiano Fidêncio at 2018-11-19T12:12:08Z
os: Use get_device_links_internal in _get_all callback

This commit is just preparing the ground for changes that will come in
the next commits where we'll start supporting "removed" devices and in
order to so, we'll have to explicitly call _get_device_links_internal()
forcing it to return *all* devices, even the "removed" ones, as they'll
be filtered out later.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
08177784 by Fabiano Fidêncio at 2018-11-19T12:15:11Z
os: Add add_entity_to_list_check()

The addition of this new function is basically preparing the ground for
the changes that are coming in the next commits where we'll need to do
the very same check in both _get_device_links_internal() and
_get_devices_internal(). With that in mind, let's avoid code
duplication and have a single function that can be used in both methods.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
6ee09840 by Fabiano Fidêncio at 2018-11-19T12:16:11Z
os: Deal with "removed" devices

This commit introduces some logic to deal with "removed" devices and the
way chosen to do so was to filter out the "removed" devices from the
full list of devices (for both DeviceLinks and Device lists).

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
7a11a777 by Fabiano Fidêncio at 2018-11-19T12:18:20Z
test-os: Add test_devices_inheritance_removal()

now that OsinfoOs can deal with the conpect of a "removed" device, let's
add some tests covering the possible situations we may face and ensure
we won't regress here.

https://gitlab.com/libosinfo/osinfo-db/issues/13

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
d4a2795b by Fabiano Fidêncio at 2018-11-19T12:36:16Z
resources: Add osinfo_resources_{get,set}_inherit()

Those two private functions will help to keep track whether the
resources should be inherited or not.

https://gitlab.com/libosinfo/osinfo-db/issues/15

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
573fec6a by Fabiano Fidêncio at 2018-11-19T12:36:21Z
loader: Set "inherit" accordingly to the resources

"inherit" is the new attribute of the resources that means whether this
resources should have its (non filled) values inherited.

In case the "inherit" attribute is present and as is "true", let's set
it. Otherwise (the default option), there's no change from the current
behaviour.

https://gitlab.com/libosinfo/osinfo-db/issues/15

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
cdd07e30 by Fabiano Fidêncio at 2018-11-19T12:36:24Z
os: Add _get_.*_resources_without_inheritance()

Those two private methods have been added and those are part of the
field preparation for having Resources inherited in the same way we do
inherit devices.

https://gitlab.com/libosinfo/osinfo-db/issues/15

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
d90a5e3d by Fabiano Fidêncio at 2018-11-19T12:36:28Z
os: Support inherited resources

As resources are pretty much the same for new releases of a same OS,
having them explicitly set is a source of copy-and-paste error and
redundant information in our db.

The approach taken to properly support inheritance of OSes is a
explicitly set attribute to the resources indicating that they should be
inherited.

Here's an example of how the XML will look like:
foo:
  <resources arch="all">
    <minimum>
      <n_cpus>1</n_cpus>
      <storage>1</storage>
    </minimum>
  </resources>

bar (which derives-from/clones foo):
  <resources arch="all" inherit="true">
    <minimum>
      <n_cpus>3</n_cpus>
      <ram>3</ram>
    </minimum>
  </resources>

When querying for bar's minimum resources, we'll get:
n_cpus: 3
cpu: -1 (not set, by any of the OSes)
ram: 3
storage: 1

https://gitlab.com/libosinfo/osinfo-db/issues/15

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
be1f2def by Fabiano Fidêncio at 2018-11-19T12:36:32Z
test-os: Add test_resources_inheritance()

Now that resources are inherited between OSes that derives-from/clones
some other OS, let's have a test case to ensure it's not going to break
in the future.

https://gitlab.com/libosinfo/osinfo-db/issues/15

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
e1c3562a by Fabiano Fidêncio at 2018-11-19T12:41:46Z
os: Fix build breakage

Similarly to what was fixed by commit 6b246cd9e, let's do not use
variable declarations inside "for" loop as it's only allowed in C99
mode.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
f0114929 by Daniel P. Berrangé at 2018-11-19T13:07:35Z
tests: display info about what failed in media/tree URI tests

Make it possible to debug failures by displaying the URL,
curl error code/message and http code.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
d314db22 by Daniel P. Berrangé at 2018-11-19T13:07:46Z
tests: ignore transient failures in media/tree URI tests

Some times the media/tree URI tests will fail with a timeout trying
to connect to the server. Treat this as non-fatal since it will
usually just indicate a transient network or server failure.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
014a01e0 by Fabiano Fidêncio at 2018-11-19T13:58:07Z
test-os: Add missing XML files

Those XMLs should have been added as part be1f2def2 but unfortunately
something went wrong while rebasing the patches.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
5264b9fa by Fabiano Fidêncio at 2018-11-19T17:29:12Z
test-devicelinklist: Remove duplicated assert

Having a duplicated g_assert_true() on CentOS7 breaks `make check` as
the compiler tries to make the second assert into a constant.

As the second assert was a typo anyways, let's just remove it in order
to fix `make check`.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
33d4535a by Fabiano Fidêncio at 2018-11-20T20:36:12Z
devicelink: Rename "removed" to "supported"

After some discussion seems that a better name for the "removed"
attribute would be "supported" (as it'd be more coherent with features
that are about to come).

While there's still no release of libosinfo or osinfo-db with the
"removed" attribute, let's just rename it to "supported".

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
c0614357 by Fabiano Fidêncio at 2018-11-21T10:05:34Z
osinfo: Create an intermediate convenience library

Let's create libosinfo-impl.la which is nothing else than
libosinfo-1.0.la without stripping out its non-public symbols.

libosinfo-impl.la can be used to link directly against our tests (as
those may use private functions that we do *not* want to expose), while
the "official" one (libosinfo-1.0.la) will remain the same.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
Tested-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
f607186a by Fabiano Fidêncio at 2018-11-21T10:06:36Z
tests: Fix `make check` breakage for FreeBSD 11

Let's take advantage of the newly added libosinfo-impl.la that contains
all the symbols that we need and link our tests against it.

By doing so, we can remove the referrence to osinfo_product.c when
building test-os, which has been causing test-os binary to contain 2
copies of the very same code, one linked in the test and the other from
libosinfo.so.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
Tested-by: Andrea Bolognani <abologna at redhat.com>

- - - - -
13a38a99 by Christophe Fergeau at 2018-11-22T08:56:09Z
build: Use EXTRA_..._DEPENDENCIES rather than _DEPENDENCIES

This allows us to use the dependencies automatically generated by
automake while appending the additional one that we need.

https://www.gnu.org/software/automake/manual/automake.html#index-EXTRA_005fmaude_005fDEPENDENCIES-1

« The EXTRA_*_DEPENDENCIES variable may be useful for cases where you
merely want to augment the automake-generated _DEPENDENCIES variable
rather than replacing it. »

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
bd4e6c8b by Fabiano Fidêncio at 2018-11-30T15:30:36Z
Introduce OsinfoImage object

OsinfoImage object has been created to represent pre-installed images
distributed by the OSes.

We've decided to go for the simplespet approach possible that's just
exposing the Image URL for an existing OS and then Apps that want to
deal with the Image itself can just use libguestfs for that as they
already do a quite good job on this field.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
519481d7 by Fabiano Fidêncio at 2018-11-30T15:30:40Z
tests: Add test-image

test-image tests the basic functionally of OsImage APIs.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
c143c69d by Fabiano Fidêncio at 2018-11-30T15:30:44Z
Introduce OsinfoImageList object

OsinfoImageList object represents has been created to easily deal with
OsinfoImage objects.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
95bbfa87 by Fabiano Fidêncio at 2018-11-30T15:30:47Z
tests: Add test-imagelist

test-imagelist is totally based on test-devicelist.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
9fc7a027 by Fabiano Fidêncio at 2018-11-30T15:30:51Z
os: Introduce APIs to deal with images

Let's introduce the needed APIs on os side to deal will the images.
For now, there's no info being loaded as the loader part depends on one
of these APIs.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
bf73fba9 by Fabiano Fidêncio at 2018-11-30T15:30:54Z
loader: Load Images information

Now that we've OsinfoImage and OsinfoImageList objects in place and
OsinfoOs already provides us an API to add an OsinfoImage to an
OsinfoOS, let's properly load the images' information present in
osinfo-db.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
1a6cf01f by Fabiano Fidêncio at 2018-11-30T15:30:57Z
tests: Add test-imageuris

In a quite similar way than test-mediauris and test-treeuris, let's have
a test for the imageuris.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
81c43558 by Fabiano Fidêncio at 2018-11-30T15:31:01Z
image: Add "cloud-init" attribute to the image

Some images may support cloud init customization and for those we'd like
to explicitly indicate it.

The "cloud-init" attribute is similar to the "live" attribute for
medias, has its default value as FALSE and can be optinionally set in
the XML.

This commit also extends the basic image tests to also cover the
cloud-images attribute.

https://gitlab.com/libosinfo/osinfo-db/issues/10

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
272e41bd by Vera Cholasta at 2018-12-06T16:15:00Z
alpinelinux3.8: Add test files for 3.8.1

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
f2089fdd by Fabiano Fidêncio at 2018-12-10T13:26:53Z
os: Fix typo in _find_install_script()

osinfo_find_install_script() doesn't work as expected due to a typo when
getting the elements of the script list as an OsinfoList must be passed
instead of an OsinfoOs.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
e8c80ae8 by Fabiano Fidêncio at 2018-12-10T13:42:30Z
os: Do not crash when passing a NULL profile to _find_install_script()

Let's ensure we're not going to crash in case a NULL profile is passed
for osinfo_find_install_script(). Instead of crashing, though, we're
returning an error.

Also, document which are the expected values for @profile

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
c2436a00 by Fabiano Fidêncio at 2018-12-10T14:11:08Z
test-os: Add tests for osinfo_os_find_install_script()

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
d56e33b4 by Fabiano Fidêncio at 2018-12-10T14:11:08Z
loader: properly load the treeinfo attributes

treeinfo attributes haven't been loaded properly due to the change done
in ab2ab35f, changing the hardcoded 9 to sizeof("treeinfo-").

The problem here is that size("treeinfo-") is 10, causing that any
comparison to fail.

Let's change the sizeof("treeinfo-") to strlen("treeinfo-").

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
ccb453b4 by Fabiano Fidêncio at 2018-12-10T14:11:08Z
test-os: expand test_loader() to cover loading treeinfo

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
eb53f8d6 by Fabiano Fidêncio at 2018-12-10T14:11:08Z
tree: Add osinfo_tree_has_treeinfo()

As not all the "trees" we stored in osinfo-db have "treeinfo" data,
let's add a new method, osinfo_tree_has_treeinfo(), that can be used to
check whether the tree has treeinfo or not.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
a3e878f9 by Fabiano Fidêncio at 2018-12-10T14:11:08Z
test-os: Cover osinfo_tree_has_treeinfo()

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
705b08bb by Fabiano Fidêncio at 2018-12-10T14:11:08Z
db: improve _guess_os_from_tree() checks

Do not check against a distro which doesn't have treeinfo data as
match_regex() would just match whatever we compare to it.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
7dcafe00 by Fabiano Fidêncio at 2018-12-10T14:54:13Z
os: Fix _find_install_script() annotation

osinfo_os_find_install_script() returns an object which ownsership is
not transferred.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
6eab80ba by Fabiano Fidêncio at 2018-12-11T08:02:38Z
tree: cleanup load_key_info()

Instead of doing the same checks for key or group not found all over the
place, let's just add a new function that does that and replace the old
check for the new function.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
1c4deff7 by Fabiano Fidêncio at 2018-12-11T08:02:45Z
tree: cleanup non-fatal errors in load_key_info()

There are errors which are not fatal and just ignored in load_keyinfo.
However, as those have not been cleaned up, we could see messages like:
(lt-osinfo-detect:20658): GLib-WARNING **: GError set over the top of a
previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL
before it's set.
The overwriting error message was: Key file does not have key “boot.iso”
in group “images-x86_64”

In order to avoid this, let's just call g_clear_error() after situations
where an error may have been set but it can just be ignored.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
8205349a by Fabiano Fidêncio at 2018-12-14T11:27:07Z
dragonflybsd: Add 5.4.0 test data

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
e8482021 by Fabiano Fidêncio at 2018-12-14T11:27:29Z
loader: Deal with "installer-script" media attribute

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
afb72a93 by Fabiano Fidêncio at 2018-12-14T11:27:46Z
media: Add _supports_installer_script()

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
74d32de9 by Fabiano Fidêncio at 2018-12-14T11:27:50Z
tests: Add basic tests for OsinfoMedia

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
aa94c662 by Fabiano Fidêncio at 2018-12-14T11:27:53Z
test-media: Add tests for OsinfoMedia attributes

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
1a25b29f by Felipe Borges at 2018-12-14T14:09:08Z
android-x86: Add Android-x86 8.1 test data

Signed-off-by: Felipe Borges <felipeborges at gnome.org>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
c476bad5 by Roman Bogorodskiy at 2018-12-17T07:42:21Z
freebsd: add FreeBSD 12.0 isodata

Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
41850b25 by Fabiano Fidêncio at 2018-12-20T10:04:51Z
install-script: Add _(get|set)_preferred_injection_method()

Those new methods are going to be used to tell the install-scripts
whether the injection-method that's going to be used is. We have to do
so as the command-line may be different depending on the
injection-method used, for example:
- fedora using cdrom, disk or floppy: ks=hd:/(vda|sda)/fedora.ks
- fedora using initrd: ks=file:/fedora.ks

It's important to mention that although the methods are taking GFlags,
those are treated as GEnum and only one value is expected to be set, as
mentioned in the documentation.

Also, mind that the usage of osinfo_entity_set_param() to store the
nick of the OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_* is intentional as
the nick is exactly what's going to be used in the install-scripts to
generate the proper command-line.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
bba06cde by Fabiano Fidêncio at 2018-12-20T10:04:56Z
test-install-script: Cover _(get|set)_preferred_injection_method()

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
459a8472 by Fabiano Fidêncio at 2018-12-20T10:05:00Z
install-script: Add _(get|set)_installation_source()

As install-scripts may behave differently depending on their
installation source, let's add two new methods to properly set what's
the installation source being used with the script and then decide what
we should do depending on the installation-source value.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
7457f00b by Fabiano Fidêncio at 2018-12-20T10:05:03Z
test-install-script: Cover _(get|set)_installation_source()

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
c2c2e121 by Fabiano Fidêncio at 2018-12-20T10:05:06Z
tools,install-script: Add "installation-source" parameter

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
f977527c by Fabiano Fidêncio at 2018-12-20T10:05:52Z
media: Don't leak stream in case of errors

stream has to be freed whenever an error occurr on
osinfo_media_create_from_location_async() internals.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
580c7134 by Fabiano Fidêncio at 2018-12-20T10:05:54Z
media: Use better naming for goto labels

Let's replace EXIT for cleanup and ON_ERROR for error and follow a
normal naming convention for the labels.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
9cd70495 by Fabiano Fidêncio at 2018-12-20T10:05:56Z
media: Use G_STATIC_ASSERT()

Let's use G_STATIC_ASSERT() instead of creating a dummy array to check
the size of the _PrimaryVolumeDescriptor struct.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
9dd914d7 by Fabiano Fidêncio at 2018-12-20T10:05:58Z
media: Add create_from_location_async_data()

This is a helper to create the OsinfoMedia from the
CreateFromLocationAsyncData. It'll become really handy in the next few
patches in the series in order to avoid code duplication.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
26de9021 by Fabiano Fidêncio at 2018-12-20T10:06:00Z
media: Add set_non_bootable_media_error()

This is a helper to set the "non bootable" error for a media. It'll
become really handy in the next few patches in the series in order to
avoid code duplication.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
29f97cb7 by Fabiano Fidêncio at 2018-12-20T10:06:06Z
media: Check whether PPC ISOs are bootable

PPC ISOs do not have the "El Torito" extension that describes whether
the media is bootable or not. However, they have a "bootinfo.txt" file
placed under "ppc" directory in order to specify the media is bootable.

So, let's add a few more checks looking for "/ppc/bootinfo.txt" in case
the El Torito header is not found.

The whole implementation has been based on the following sources:
- The ISO 9660 (ECMA-119) specification:
  http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-119.pdf
- The ISO 9660 osdev wiki page:
  https://wiki.osdev.org/ISO_9660
- IBM's developer article:
  https://www.ibm.com/developerworks/linux/library/l-detecting-bootable-ibm-power-server-iso-images/index.html

And what the implementation does is:
- Access the *root* directory record, which has a fixed size of 33 bytes
  and is located at the bytes offset 156 of the PVD;
- Load the *root* directory record extent content into the memory and:
  - Search for the the dir/file we're looking at;
  - In the dir is present, we load its directory record extent content
    into the memory and search for the next dir/file;
    - In case the file is present, we return that the media is bootable;
    - Otherwise, we return the media is non bootable;

Mind, though, that this code is *not* generic enough to be adapted in
case we want to search for a different dir/file and the reason for that
is related to some ISOs using a TRANS.TBL table that translates the
given name of a file to the shown name of the same file.

If, for some reason, we ever want to take the path of having this code
more generic we'd have to:
- For each directory acessed, search for TRANS.TBL;
  - In case it's present, load its content into a hash table and, for
    each dir/file, check the name of the file we're looking for with the
    shown name (only present in the TRANS.TBL;
  - Otherwise, just follow the very same code we currently have;

The decision for not implementing this TRANS.TBL changes is, mainly,
because it'd make the code circa twice slower than it currently is
(as we'd have to search for the TRANS.TBL as the first thing ...)
without any specific gain for the needs we have right now. In case
there's the need, in the future, it could be implemented in the way
described here.

https://gitlab.com/libosinfo/libosinfo/issues/8

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
d2eabc06 by Fabiano Fidêncio at 2018-12-20T13:40:04Z
media: Don't try to unref a NULL entry

In case g_file_read_finish() fails, the stream will always be NULL.
The issue has been introduced as part of f977527c82.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
4ce0fcbd by Fabiano Fidêncio at 2018-12-20T13:40:34Z
media: Pass the source object to GTask new

When creating the new GTask in osinfo_media_create_from_location_async,
no source object has been passed. Consequently
search_ppc_bootinfo_callback receives NULL as its source object, causing
warnings when trying to unref it.

Let's just pass the stream as the source object of the GTask in
osinfo_media_create_from_location_async in order to avoid the issue.

The issue has been introduced as part of 29f97cb7648.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
4fe69c9f by Pino Toscano at 2018-12-20T15:12:43Z
Use g_list_free_full where easily possible

Use g_list_free_full instead of g_list_foreach + g_list_free, so the
lists are cleared with a single call.

test-isodetect gets a void* wrapper, so there is no need to add casts
everywhere.

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
e99d5263 by Felipe Borges at 2019-01-04T10:17:50Z
endlessos: Add Endless OS 3.4 isodata

Signed-off-by: Felipe Borges <feborges at redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
2081b21c by Fabiano Fidêncio at 2019-01-04T10:17:53Z
README: Update download link

Let's point to pagure instead of referring to the already sunset
fedorahosted.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
03f1f101 by Fabiano Fidêncio at 2019-01-04T10:17:58Z
README: Reword the patch submission paragraph

Just mention that the libosinfo's mailing list is the *preferred* way to
send patches. More info, as the one about the project accepting Merge
Request, can be found in the project's website.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
00f258a6 by Fabiano Fidêncio at 2019-01-04T10:20:04Z
loader: refuse to load non-compliant named files

There was a period of grace needed for backwards compatibility. After 3+
years, we can safely remove the code instroduced as part of 09ae3cf09
(which was released on 0.3.0).

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
9ffb7730 by Fabiano Fidêncio at 2019-01-04T10:20:07Z
dragonflybsd: Add 5.4.1 test data

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
4369e4ec by Fabiano Fidêncio at 2019-01-09T10:19:13Z
README: Update download information

Let's point to https://libosinfo.org/download/ instead of pointing to
pagure, as it could change again in the future.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
2a939482 by Fabiano Fidêncio at 2019-01-09T10:29:40Z
loader: improve warning message from loader_check_id()

"should" needs to be changed to "must" as since commit 00f258a6be
libosinfo refuses to load non-compliant named files.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
24b2a655 by Fabiano Fidêncio at 2019-01-15T20:45:02Z
tree: fix typo in the annotations: 'and' -> 'an'

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
8969c436 by Fabiano Fidêncio at 2019-01-15T20:45:02Z
db: improve _guess_os_from_media() checks

Do not check against a distro which doesn't have *any* of the values we
use to check as match_regex() would just match whatever we compare to
it.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
c47adccc by Fabiano Fidêncio at 2019-01-24T13:50:06Z
os: Fix typos in resources methods

methos -> method
*private! -> *private*!

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
50589d86 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
os: Remove extra line from _get_recommended_resources()

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
b6f3dab3 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
os: Group get_*_resources() together

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
cf9d20c3 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
os: Make get_maximum_resources() aware of inheritance

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
becc04a5 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
loader: Fix typo when loading maximum resources

osinfo_os_add_recommended_resources -> osinfo_os_add_maximum_resources

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
57624094 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
test-os: Fix typo in resources tests

osinfo_os_get_recommended_resources -> osinfo_os_get_maximum_resources

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
d87e9fab by Fabiano Fidêncio at 2019-01-24T13:50:06Z
os: Deal with network-install resources

network-install resources represent the resources to be used during a
network installation. It may differs from the minimum resources as the
network installers (not only the medias, but the trees) may download a
huge amount of data to the RAM* consuming way more than the minimum or
recommended RAM for the OS.

*: anaconda downloads the whole stage2 of the installer into the RAM in
order to perform a network installation.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
783df020 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
loader: Deal with network-install resources

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
c06bf702 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
os: Make get_resources_*_without_inheritance() static

With that we can get rid of osinfo_os_private.h

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
2c861242 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
test-os: Add basic test for resources

This test only ensures that libosinfo is able to properly load the
resource info from an OS entry.

Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
5d911b44 by Fabiano Fidêncio at 2019-01-24T13:50:06Z
tools: Remove a reference to fedorahosted.org

Although it's just the id used for the install script, let's remove the
reference to the already sunset fedorahosted.org and just use
"https://libosinfo.org/config" as the id.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
cc104fe3 by Fabiano Fidêncio at 2019-01-24T14:11:27Z
test-os: Fix make syntax-check

While applying the last patches a few trailing whitespaces have been
introduced, making `make syntax-check` fail.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
59fff9f3 by Daniel P. Berrangé at 2019-01-30T17:53:50Z
Refresh translations from zanata

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
15128a2d by Daniel P. Berrangé at 2019-01-30T18:10:30Z
Update NEWS for 1.3.0 release

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
1fa7e9b0 by Daniel P. Berrangé at 2019-01-30T18:31:22Z
Post release version bump to 1.4.0

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
661e980a by Daniel P. Berrangé at 2019-02-04T11:38:06Z
tests: add one test case per OS tested

The image, media & tree URIs test suites just register one test case for
all the work they do. As a result when they run they just sit there
printing no progress information for a long time.

This changes then to register one test case per OS in the database. As a
result we get progress information. An added benefit is that it is
possible to now run tests for individual OS by passing the -p argument.

  eg  test-mediauris -p /mediauris/uris/rhel3.9

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
56083c17 by Cole Robinson at 2019-02-04T14:05:04Z
ubuntu: Add 19.04 ppc64el test data

Signed-off-by: Cole Robinson <crobinso at redhat.com>
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
80afb0f0 by Fabiano Fidêncio at 2019-02-04T14:05:04Z
tests: Avoid re-using the curl handler on URIs tests

On CentOS, we've hit an issue that when a curl handler is re-used we end
up receiving malfunctioning responses from NetBSD CDN.

Dan investigated the issue found out that the problem is that libcurl in
CentOS 7 at least is not ignoring the body. Sometimes it closes the
keepalive connection so this doesn't matter, but other times it gives
us back the body that it should be ignoring.

In order to work the issue around, let's no re-use the curl handler but
always open a new one for each of the URIs.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
0f481f4a by Fabiano Fidêncio at 2019-02-04T14:05:04Z
tests: abort() in case curl misbehaves

Although the issue with curl should be fixed by the previous commit,
let's abort in case it misbehaves, avoiding then to have all the data
printed on stdout.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
ccae491c by Fabiano Fidêncio at 2019-02-12T19:22:57Z
media: Add installer to the media

Having the installer tied to the OS is something that has been shown not
optimal, unfortunately.

An OS may have a few different medias and each media may support a
specific type of script or, even, not support an installer script at
all. With this in mind, let's have the installer scripts tied to the
medias themselves.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
53e5dd13 by Fabiano Fidêncio at 2019-02-12T19:23:11Z
test-media: Add test for media installer script

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
410993d7 by Fabiano Fidêncio at 2019-02-12T19:24:58Z
media: Make _supports_installer_script() aware of media installers

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
af854f13 by Fabiano Fidêncio at 2019-02-18T08:53:27Z
pureos: Add test data for pureos8

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
6d789033 by Fabiano Fidêncio at 2019-02-18T08:53:58Z
media: Don't assume identifiers are null terminated

Identifiers as volume-id, application, publisher, and system are not
null terminated and cannot be assumed as so.

By assuming those are null terminated strings, libosinfo ends up not
counting the last character of a MAX_* string and, consequently, not
properly identifying medias that have their identifiers with the MAX_*
size.

One example is the ubuntu-18.04.1.0-live-server-amd64.iso media, which
has as volume-id 'Ubuntu-Server 18.04.1+ LTS amd64'. As the volume-id
has exactly 32 characters it's never been matched as when reading the
media's volume-id it'd be read as 'Ubuntu-Server 18.04.1+ LTS amd6'.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
98d3c44d by Fabiano Fidêncio at 2019-02-18T08:54:34Z
tests: Add ubuntu 18.04.1 and 18.04.1.0 test data

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>

- - - - -
d995f28d by Fabiano Fidêncio at 2019-02-18T10:35:09Z
tests: Reduce code duplication in URI tests

Let's introduce a common file that does the check of the URI for all the
URI related tests.

By doing this we can avoid code duplication while also avoiding to have
all the tests merged together into a single one, which is not so good as
limits the developer to run and wait for the whole set of tests instead
of having the ability to just run the a specific one.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
4f8303a9 by Pino Toscano at 2019-02-18T12:43:48Z
os: add OSINFO_RELEASE_STATUS_ROLLING

Add the OSINFO_RELEASE_STATUS_ROLLING value to the OsinfoReleaseStatus
enum, to track the new "rolling" release-status available in the osinfo
schema.

Signed-off-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
1998167c by Pino Toscano at 2019-02-18T12:43:48Z
archlinux: add Arch Linux test data

Signed-off-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
6a2868f7 by Pino Toscano at 2019-02-18T12:43:48Z
gentoo: add Gentoo Linux test data

Signed-off-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
d700e90f by Pino Toscano at 2019-02-18T12:43:48Z
voidlinux: add Void Linux test data

Signed-off-by: Pino Toscano <ptoscano at redhat.com>

- - - - -
9915eba1 by Fabiano Fidêncio at 2019-02-18T13:07:24Z
test-uris-common: remove empty line at EOF

The empty line caused:
tests/test-uris-common.c
maint.mk: empty line(s) or no newline at EOF
make: *** [maint.mk:926: sc_prohibit_empty_lines_at_EOF] Error 1

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
7558d382 by Fabiano Fidêncio at 2019-02-18T13:36:19Z
tests: Add test-uris-common.h to the SOURCES

Otherwise some breakage can be seen when building libosinfo's RPM

test-uris-common.c:24:10: fatal error: test-uris-common.h: No such file or directory
 #include "test-uris-common.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:1296: test_mediauris-test-uris-common.o] Error 1
make[2]: *** Waiting for unfinished jobs....
  CCLD     test-entity
test-mediauris.c:27:10: fatal error: test-uris-common.h: No such file or directory
 #include "test-uris-common.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:1282: test_mediauris-test-mediauris.o] Error 1
test-treeuris.c:27:10: fatal error: test-uris-common.h: No such file or directory
 #include "test-uris-common.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:1394: test_treeuris-test-treeuris.o] Error 1
test-uris-common.c:24:10: fatal error: test-uris-common.h: No such file or directory
 #include "test-uris-common.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:1408: test_treeuris-test-uris-common.o] Error 1
test-imageuris.c:27:10: fatal error: test-uris-common.h: No such file or directory
 #include "test-uris-common.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:1184: test_imageuris-test-imageuris.o] Error 1
test-uris-common.c:24:10: fatal error: test-uris-common.h: No such file or directory
 #include "test-uris-common.h"

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
9631ef7d by Martin Blanchard at 2019-02-19T18:16:34Z
build: Prefer autoreconf over gnome-autogen

gnome-common is completely deprecated:

https://wiki.gnome.org/Projects/GnomeCommon/Migration

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
3a2dd305 by Martin Blanchard at 2019-02-19T20:14:14Z
build: Prefer gettext over intltool

intltool is outdated:

https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
54ce2c48 by Fabiano Fidêncio at 2019-03-01T13:24:23Z
db: Add missing attributes to fill_media()

Some new attributes have been added to OsinfoMedia, as:
- the install-script list (during this cycle);
- installer-script (1.3.0);

However, none of those attributes have been filled in in the media
accordingly to matched media.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

- - - - -
76548a6a by Fabiano Fidêncio at 2019-03-01T13:24:31Z
tests: Add identify_media() tests

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
baf15f4e by Fabiano Fidêncio at 2019-03-01T13:24:59Z
syms: Add "global" to 1.4.0 symbols

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

- - - - -
1308df01 by Fabiano Fidêncio at 2019-03-01T15:05:59Z
Refresh translations from zanata

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
d116f7e3 by Fabiano Fidêncio at 2019-03-01T15:33:57Z
Update NEWS for 1.4.0 release

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

- - - - -
2808eb62 by Guido Günther at 2019-04-10T16:57:05Z
d/gbp.conf: Switch to experimental

- - - - -
b4b5f745 by Guido Günther at 2019-04-11T10:18:20Z
Minimize existing signing key and add new one

- - - - -
8ab1ba3b by Guido Günther at 2019-04-11T10:18:57Z
New upstream version 1.4.0
- - - - -
3a5783c0 by Guido Günther at 2019-04-11T10:19:28Z
Update upstream source from tag 'upstream/1.4.0'

Update to upstream version '1.4.0'
with Debian dir 4c3f037f08ddaa573b264c1f6426fbe811206d4a

- - - - -
07423fdb by Guido Günther at 2019-04-11T10:21:51Z
Unbreak arch parsing application id usage

- loader-Properly-load-the-arch-value-for-images.patch
- media-Fix-usage-of-application-id.patch

Thanks: Fabiano Fidêncio

- - - - -
d07d8600 by Guido Günther at 2019-04-11T11:58:52Z
d/control: Bump osinfo-db build-dep

We need a newer version for the tests

- - - - -
023e49ec by Guido Günther at 2019-04-15T14:33:13Z
Drop failing haiku test

- - - - -
f7e6c2e9 by Guido Günther at 2019-04-15T14:37:53Z
Update symbols file

- - - - -
fee1815b by Guido Günther at 2019-04-15T14:40:03Z
d/gbp.conf: Don't use patch numbers but id-length

- - - - -
c870376f by Guido Günther at 2019-04-15T14:41:26Z
Document changes and release 1.4.0-1

- - - - -


3 changed files:

- + ABOUT-NLS
- AUTHORS
- AUTHORS.in


The diff was not included because it is too large.


View it on GitLab: https://salsa.debian.org/libvirt-team/libosinfo/compare/292a8ab3199d2884eddf063cc843c74a441bbe5f...c870376f0ea8ed6f3c9127123acbc3f84977eeb7

-- 
View it on GitLab: https://salsa.debian.org/libvirt-team/libosinfo/compare/292a8ab3199d2884eddf063cc843c74a441bbe5f...c870376f0ea8ed6f3c9127123acbc3f84977eeb7
You're receiving this email because of your account on salsa.debian.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-commits/attachments/20190415/9656a970/attachment-0001.html>


More information about the Pkg-libvirt-commits mailing list