[Pkg-libvirt-commits] [Git][libvirt-team/libvirt][debian/latest] 2 commits: symbols: Drop non-existing symbols

Andrea Bolognani (@abologna) gitlab at salsa.debian.org
Sun May 21 15:00:49 BST 2023 


Andrea Bolognani pushed to branch debian/latest at Libvirt Packaging Team / libvirt


Commits:
c809b1e1 by Andrea Bolognani at 2023-05-11T21:58:39+02:00
symbols: Drop non-existing symbols

Comparing debian/libvirt0.symbols with src/libvirt_public.syms
and the libvirt-{admin,qemu,lxc}.so equivalents shows that we
are listing way more symbols than are actually exported by the
library.

This is not unexpected as most releases of libvirt, especially
now that the library is fairly mature, do not introduce any new
symbols.

dpkg-gensymbols reports this at build time by printing out a
massive diff, which is annoying and could potentially drown
out more important messages in the noise.

Solve the issue by dropping all the unnecessary entries.

Gbp-Dch: Ignore

- - - - -
502e2a53 by Andrea Bolognani at 2023-05-11T21:58:39+02:00
rules: Enable dpkg-gensymbols checks

We can catch some mistakes in the symbols file this way.

Unfortunately unnecessary entries like the ones we just
removed are not reported as errors yet. See #1034710.

Gbp-Dch: Ignore

- - - - -


2 changed files:

- debian/libvirt0.symbols
- debian/rules


Changes:

=====================================
debian/libvirt0.symbols
=====================================
@@ -21,26 +21,19 @@ libvirt.so.0 libvirt0 #MINVER#
  *@LIBVIRT_0.6.1 0.6.1
  *@LIBVIRT_0.6.3 0.6.3
  *@LIBVIRT_0.6.4 0.6.4
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_0.6.5 0.6.5
  *@LIBVIRT_0.7.0 0.7.0
  *@LIBVIRT_0.7.1 0.7.1
  *@LIBVIRT_0.7.2 0.7.2
  *@LIBVIRT_0.7.3 0.7.3
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_0.7.4 0.7.4
  *@LIBVIRT_0.7.5 0.7.5
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_0.7.6 0.7.6
  *@LIBVIRT_0.7.7 0.7.7
  *@LIBVIRT_0.8.0 0.8.0
  *@LIBVIRT_0.8.1 0.8.1
  *@LIBVIRT_0.8.2 0.8.2
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_0.8.3 0.8.3
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_0.8.4 0.8.4
  *@LIBVIRT_0.8.5 0.8.5
  *@LIBVIRT_0.8.6 0.8.6
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_0.8.7 0.8.7
  *@LIBVIRT_0.8.8 0.8.8
  *@LIBVIRT_0.9.0 0.9.0~rc1
- *@LIBVIRT_0.9.1 0.9.1
  *@LIBVIRT_0.9.2 0.9.2
  *@LIBVIRT_0.9.3 0.9.3
  *@LIBVIRT_0.9.4 0.9.4~rc1
@@ -50,7 +43,6 @@ libvirt.so.0 libvirt0 #MINVER#
  *@LIBVIRT_0.9.9 0.9.9
  *@LIBVIRT_0.9.10 0.9.10~rc1
  *@LIBVIRT_0.9.11 0.9.11~rc1
- *@LIBVIRT_0.9.12 0.9.12~rc2
  *@LIBVIRT_0.9.13 0.9.13~rc1
  *@LIBVIRT_0.10.0 0.10.0~rc2
  *@LIBVIRT_0.10.2 0.10.2
@@ -58,66 +50,37 @@ libvirt.so.0 libvirt0 #MINVER#
  *@LIBVIRT_1.0.1 1.0.1~rc1
  *@LIBVIRT_1.0.2 1.0.2~rc1
  *@LIBVIRT_1.0.3 1.0.3~rc2
- *@LIBVIRT_1.0.4 1.0.4
  *@LIBVIRT_1.0.5 1.0.5~rc1
  *@LIBVIRT_1.0.6 1.0.6
  *@LIBVIRT_1.1.0 1.1.0
  *@LIBVIRT_1.1.1 1.1.1
- *@LIBVIRT_1.1.2 1.1.2~rc1
  *@LIBVIRT_1.1.3 1.1.3~rc1
- *@LIBVIRT_1.1.4 1.1.4~rc1
- *@LIBVIRT_1.2.0 1.2.0~rc2
  *@LIBVIRT_1.2.1 1.2.1~rc1
- *@LIBVIRT_1.2.2 1.2.2
  *@LIBVIRT_1.2.3 1.2.3
- *@LIBVIRT_1.2.4 1.2.4~rc2
  *@LIBVIRT_1.2.5 1.2.5
  *@LIBVIRT_1.2.6 1.2.6
  *@LIBVIRT_1.2.7 1.2.7~rc2
  *@LIBVIRT_1.2.8 1.2.8~rc2
  *@LIBVIRT_1.2.9 1.2.9~rc1
- *@LIBVIRT_1.2.10 1.2.10~rc1
  *@LIBVIRT_1.2.11 1.2.11~rc1
  *@LIBVIRT_1.2.12 1.2.12~rc1
- *@LIBVIRT_1.2.13 1.2.13
  *@LIBVIRT_1.2.14 1.2.14~rc2
  *@LIBVIRT_1.2.15 1.2.15~rc1
  *@LIBVIRT_1.2.16 1.2.16~rc1
  *@LIBVIRT_1.2.17 1.2.17~rc2
- *@LIBVIRT_1.2.18 1.2.18
  *@LIBVIRT_1.2.19 1.2.19~rc1
- *@LIBVIRT_1.2.20 1.2.20
- *@LIBVIRT_1.2.21 1.2.21~rc1
- *@LIBVIRT_1.3.0 1.3.0~rc1
- *@LIBVIRT_1.3.1 1.3.1~rc1
  *@LIBVIRT_1.3.3 1.3.3~rc1
- *@LIBVIRT_1.3.4 1.3.4~rc1
- *@LIBVIRT_1.3.5 1.3.5~rc1
  *@LIBVIRT_2.0.0 2.0.0~rc1
- *@LIBVIRT_2.1.0 2.1.0~rc1
  *@LIBVIRT_2.2.0 2.2.0~rc1
- *@LIBVIRT_2.3.0 2.3.0~rc1
- *@LIBVIRT_2.4.0 2.4.0~rc1
- *@LIBVIRT_2.5.0 2.5.0
  *@LIBVIRT_3.0.0 3.0.0
  *@LIBVIRT_3.1.0 3.1.0~rc2
  *@LIBVIRT_3.4.0 3.4.0
- *@LIBVIRT_3.5.0 3.5.0
- *@LIBVIRT_3.6.0 3.6.0
  *@LIBVIRT_3.7.0 3.7.0
- *@LIBVIRT_3.8.0 3.8.0~rc1
  *@LIBVIRT_3.9.0 3.9.0~rc1
- *@LIBVIRT_3.10.0 3.10.0
- *@LIBVIRT_4.0.0 4.0.0~rc2
  *@LIBVIRT_4.1.0 4.1.0
- *@LIBVIRT_4.2.0 4.2.0
- *@LIBVIRT_4.3.0 4.3.0
  *@LIBVIRT_4.4.0 4.4.0
  *@LIBVIRT_4.5.0 4.5.0
- *@LIBVIRT_4.6.0 4.6.0
- *@LIBVIRT_4.7.0 4.7.0
  *@LIBVIRT_4.10.0 4.10.0
- *@LIBVIRT_5.0.0 5.0.0
  *@LIBVIRT_5.2.0 5.2.0~rc1
  *@LIBVIRT_5.5.0 5.6.0
  *@LIBVIRT_5.6.0 5.6.0
@@ -139,11 +102,6 @@ libvirt.so.0 libvirt0 #MINVER#
 
 libvirt-qemu.so.0 libvirt0 #MINVER#
  *@LIBVIRT_QEMU_0.8.3 0.8.3
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_QEMU_0.8.4 0.8.4
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_QEMU_0.8.5 0.8.5
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_QEMU_0.8.6 0.8.6
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_QEMU_0.8.7 0.8.7
-#MISSING: 0.8.8-1# (symver|optional)LIBVIRT_QEMU_0.8.8 0.8.8
  *@LIBVIRT_QEMU_0.9.4 0.9.4~rc1
  *@LIBVIRT_QEMU_0.10.0 0.10.0~rc2
  *@LIBVIRT_QEMU_1.2.3 1.2.3
@@ -155,7 +113,6 @@ libvirt-lxc.so.0 libvirt0 #MINVER#
  *@LIBVIRT_LXC_2.0.0 2.0.0~rc2
 
 libvirt-admin.so.0 libvirt0 #MINVER#
- *@LIBVIRT_ADMIN_1.3.0 1.2.18
  *@LIBVIRT_ADMIN_2.0.0 2.0.0~rc1
  *@LIBVIRT_ADMIN_3.0.0 3.0.0
  *@LIBVIRT_ADMIN_8.6.0 8.9.0


=====================================
debian/rules
=====================================
@@ -12,6 +12,10 @@ DEB_LDFLAGS_MAINT_STRIP = -Wl,-Bsymbolic-functions
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/default.mk
 
+# Fail if the symbols file contains certain mistakes
+DPKG_GENSYMBOLS_CHECK_LEVEL = 4
+export DPKG_GENSYMBOLS_CHECK_LEVEL
+
 ARCHES_CEPH = amd64 arm64 armel armhf i386 mips64el mipsel powerpc ppc64el riscv64 s390x
 ARCHES_LXC  = alpha amd64 arm64 armel armhf hppa i386 m68k mips64el mipsel powerpc ppc64 ppc64el riscv64 s390x sh4 sparc64 x32
 ARCHES_XEN  = amd64 arm64 armhf



View it on GitLab: https://salsa.debian.org/libvirt-team/libvirt/-/compare/f6187b48f8b7d1e129b8e49f24e024d1b01e33ab...502e2a53d82efe6963b1d69933447472e4cca149

-- 
View it on GitLab: https://salsa.debian.org/libvirt-team/libvirt/-/compare/f6187b48f8b7d1e129b8e49f24e024d1b01e33ab...502e2a53d82efe6963b1d69933447472e4cca149
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-commits/attachments/20230521/bb7a3d43/attachment-0001.htm>

More information about the Pkg-libvirt-commits mailing list