[Pkg-libvirt-commits] [Git][libvirt-team/libvirt][lgarrett/fix-logic-when-tainting-domain] 2 commits: README.source: Update information

[Lee Garrett (@lgarrett)]

Lee Garrett pushed to branch lgarrett/fix-logic-when-tainting-domain at Libvirt Packaging Team / libvirt


Commits:
efd54b30 by Andrea Bolognani at 2024-08-15T22:28:49+02:00
README.source: Update information

Some of it is no longer accurate.

Gbp-Dch: Ignore
(cherry picked from commit 2efc5d77257b4b6dbebb52be49dfd1b364701162)

- - - - -
2b62dda1 by Lee Garrett at 2024-08-15T22:35:07+02:00
qemu_domain: Fix logic when tainting domain

Closes: #1052405

- - - - -


3 changed files:

- debian/README.source
- + debian/patches/backport/fix-logic-when-tainting-domain.patch
- debian/patches/series


Changes:

=====================================
debian/README.source
=====================================
@@ -1,6 +1,6 @@
-This package is maintained with git-buildpackage(1). It follows DEP-14
-for branch naming (e.g. using debian/sid for the current version
-in Debian unstable).
+This package is maintained with git-buildpackage(1). It follows
+DEP-14 for branch naming (e.g. using debian/latest for the current
+development target).
 
 It uses pristine-tar(1) to store enough information in git to generate
 bit identical tarballs when building the package without having
@@ -22,7 +22,7 @@ For information on how to set up a pbuilder environment see the
 git-pbuilder(1) manpage. In short:
 
     DIST=sid git-pbuilder create
-    gbp clone https://anonscm.debian.org/git/pkg-libvirt/libvirt.git
+    gbp clone https://salsa.debian.org/libvirt-team/libvirt.git
     cd libvirt
     gbp buildpackage --git-pbuilder
 


=====================================
debian/patches/backport/fix-logic-when-tainting-domain.patch
=====================================
@@ -0,0 +1,37 @@
+From 9134b40d0b43a5e1a9928b0a0d948205941d9807 Mon Sep 17 00:00:00 2001
+From: Peter Krempa <pkrempa at redhat.com>
+Date: Wed, 1 Mar 2023 17:09:42 +0100
+Subject: [PATCH] qemu: domain: Fix logic when tainting domain
+
+Originally the code was skipping all repeated taints with the same taint
+flag but a logic bug introduced in commit 30626ed15b239c424ae inverted
+the condition. This caused that actually the first occurence was NOT
+logged but any subsequent was.
+
+This was noticed when going through oVirt logs as they use custom guest
+agent commands and the logs are totally spammed with this message.
+
+Fixes: 30626ed15b239c424ae891f096057a696eadd715
+Signed-off-by: Peter Krempa <pkrempa at redhat.com>
+Reviewed-by: Laine Stump <laine at redhat.com>
+
+Forwarded: not-needed
+Origin: https://gitlab.com/libvirt/libvirt/-/commit/9134b40d0b43a5e1a9928b0a0d948205941d9807
+Bugs-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052405
+---
+ src/qemu/qemu_domain.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git src/qemu/qemu_domain.c src/qemu/qemu_domain.c
+index da7a869..6484349 100644
+--- a/src/qemu/qemu_domain.c
++++ b/src/qemu/qemu_domain.c
+@@ -6576,7 +6576,7 @@ void qemuDomainObjTaintMsg(virQEMUDriver *driver,
+     const char *extrasuffix = "";
+     va_list args;
+ 
+-    if (virDomainObjTaint(obj, taint)) {
++    if (!virDomainObjTaint(obj, taint)) {
+         /* If an extra message was given we must always
+          * emit the taint warning, otherwise it is a
+          * one-time only warning per VM


=====================================
debian/patches/series
=====================================
@@ -10,6 +10,7 @@ backport/rpc-client-Don-t-check-return-value-of-virNetMessageNew.patch
 backport/rpc-Don-t-warn-about-max_client_requests-in-single-thread.patch
 backport/conf-Fix-migration-in-some-firmware-autoselection-scenari.patch
 backport/virpci-Resolve-leak-in-virPCIVirtualFunctionList-cleanup.patch
+backport/fix-logic-when-tainting-domain.patch
 forward/Skip-vircgrouptest.patch
 forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch
 forward/Pass-GPG_TTY-env-var-to-the-ssh-binary.patch



View it on GitLab: https://salsa.debian.org/libvirt-team/libvirt/-/compare/41c16b2edea2677a4a9301ebb31ba3944a90591e...2b62dda1175e803830b7fdc3ede131936be5ad90

-- 
View it on GitLab: https://salsa.debian.org/libvirt-team/libvirt/-/compare/41c16b2edea2677a4a9301ebb31ba3944a90591e...2b62dda1175e803830b7fdc3ede131936be5ad90
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-commits/attachments/20240815/cceb65e7/attachment-0001.htm>