[Pkg-libvirt-commits] [Git][libvirt-team/libvirt][debian/latest] patches: Drop forward/Reduce-udevadm-settle-timeout-[...]

[Andrea Bolognani (@abologna)]

Andrea Bolognani pushed to branch debian/latest at Libvirt Packaging Team / libvirt


Commits:
49e84557 by Andrea Bolognani at 2024-11-07T23:03:36+01:00
patches: Drop forward/Reduce-udevadm-settle-timeout-[...]

This was added in 2012 to work around an issue (#663931) where
running pool-refresh took too long, causing virt-manager to
fail connecting because of a timeout.

I'm assuming that things have improved in the 10+ years since,
both on the kernel and udev side, and that this workaround is
no longer needed at this point. As far as I can tell, no other
distro is carrying a similar patch either.

If we get further reports in the future, indicating that this
is indeed still a problem, we should look into a proper
upstream fix instead of a Debian-only workaround.

- - - - -


2 changed files:

- − debian/patches/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch
- debian/patches/series


Changes:

=====================================
debian/patches/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch deleted
=====================================
@@ -1,24 +0,0 @@
-From: =?utf-8?q?Guido_G=C3=BCnther?= <agx at sigxcpu.org>
-Date: Mon, 4 Jun 2012 16:18:52 +0200
-Subject: Reduce udevadm settle timeout to 10 seconds
-
-This isn't a proper fix but it will make virt-manager at least start.
-
-Closes: #663931
----
- src/util/virutil.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/util/virutil.c b/src/util/virutil.c
-index 2abcb28..b4805c9 100644
---- a/src/util/virutil.c
-+++ b/src/util/virutil.c
-@@ -1332,7 +1332,7 @@ void virWaitForDevices(void)
-     if (!(udev = virFindFileInPath(UDEVADM)))
-         return;
- 
--    if (!(cmd = virCommandNewArgList(udev, "settle", NULL)))
-+    if (!(cmd = virCommandNewArgList(udev, "settle", "--timeout=10", NULL)))
-         return;
- 
-     /*


=====================================
debian/patches/series
=====================================
@@ -1,4 +1,3 @@
-forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch
 debian/Debianize-libvirt-guests.patch
 debian/apparmor_profiles_local_include.patch
 debian/Use-sensible-editor-by-default.patch



View it on GitLab: https://salsa.debian.org/libvirt-team/libvirt/-/commit/49e8455738b77c25b842faa835b3aa70eb7d5898

-- 
View it on GitLab: https://salsa.debian.org/libvirt-team/libvirt/-/commit/49e8455738b77c25b842faa835b3aa70eb7d5898
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-commits/attachments/20241108/6f555043/attachment-0001.htm>