[Pkg-libvirt-maintainers] Bug#549949: Bug#549949: Bug#549949: libvirt-bin: starting network failed because of iptables rule

[Guido Günther]

On Wed, Nov 04, 2009 at 10:52:26PM +0100, Rob S. Wolfram wrote:
> Hi Guido,
> 
> On Tue, Oct 06, 2009 at 10:14:10PM +0200, Guido Günther wrote:
> > Could you check if this helps (untested):
> > 
> > 
> > diff --git a/src/network_driver.c b/src/network_driver.c
> > index 49855bf..d673921 100644
> > --- a/src/network_driver.c
> > +++ b/src/network_driver.c
> > @@ -751,16 +751,15 @@ static void
> >  networkRemoveIptablesRules(struct network_driver *driver,
> >                           virNetworkObjPtr network) {
> >      if (network->def->forwardType != VIR_NETWORK_FORWARD_NONE) {
> > -        iptablesRemoveForwardMasquerade(driver->iptables,
> > -                                        network->def->network,
> > -                                        network->def->forwardDev);
> > -
> > -        if (network->def->forwardType == VIR_NETWORK_FORWARD_NAT)
> > +        if (network->def->forwardType == VIR_NETWORK_FORWARD_NAT) {
> > +            iptablesRemoveForwardMasquerade(driver->iptables,
> > +                                                network->def->network,
> > +                                                network->def->forwardDev);
> >              iptablesRemoveForwardAllowRelatedIn(driver->iptables,
> >                                                  network->def->network,
> >                                                  network->def->bridge,
> >                                                  network->def->forwardDev);
> > -        else if (network->def->forwardType == VIR_NETWORK_FORWARD_ROUTE)
> > +        } else if (network->def->forwardType == VIR_NETWORK_FORWARD_ROUTE)
> >              iptablesRemoveForwardAllowIn(driver->iptables,
> >                                           network->def->network,
> >                                           network->def->bridge,
> 
> This patch works. I applied it to 0.7.1-2 and compiled it in squeeze.
> Please include the patch in following versions :)
Applied. Thanks a lot for testing!
 -- Guido