[Pkg-libvirt-maintainers] Bug#579208: USB Class/Number/... is base 16, not base 10 (Failed to convert 'ff' to unsigned int)

[Klaus Ethgen]

Package: libvirt-bin
Version: 0.8.0-2
Severity: normal
Tags: patch

Hi,

in node_device_udev.c is the base 10 used for conversion of USB values.
But they are hex values so that the conversion fail in the most of time.

Funny is that the upstream did know that but didn't fix it (comment in
line 551).

The patch will fix that. But it do not remove the comment.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (800, 'unstable'), (700, 'stable'), (600, 'oldstable'), (60, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32.9
Locale: LANG=de_DE, LC_CTYPE=de_DE (charmap=ISO-8859-1) (ignored: LC_ALL set to de_DE)
Shell: /bin/sh linked to /bin/dash

Versions of packages libvirt-bin depends on:
ii  adduser                   3.112          add and remove users and groups
ii  libavahi-client3          0.6.25-3       Avahi client library
ii  libavahi-common3          0.6.25-3       Avahi common library
ii  libc6                     2.10.2-6       Embedded GNU C Library: Shared lib
ii  libcap-ng0                0.6.3-1        An alternate posix capabilities li
ii  libdevmapper1.02.1        2:1.02.45-1    The Linux Kernel Device Mapper use
ii  libgcrypt11               1.4.5-2        LGPL Crypto library - runtime libr
ii  libgnutls26               2.8.6-1        the GNU TLS library - runtime libr
ii  libparted0                2.2-5          The GNU Parted disk partitioning s
ii  libpciaccess0             0.11.0-2       Generic PCI access library for X
ii  libreadline6              6.1-2          GNU readline and history libraries
ii  libsasl2-2                2.1.23.dfsg1-5 Cyrus SASL - authentication abstra
ii  libudev0                  153-1          libudev shared library
ii  libuuid1                  2.16.2-0       Universally Unique ID library
ii  libvirt0                  0.8.0-2        library for interfacing with diffe
ii  libxenstore3.0            3.4.3~rc3-2    Xenstore communications library fo
ii  libxml2                   2.7.7.dfsg-2   GNOME XML library
ii  logrotate                 3.7.8-6        Log rotation utility

Versions of packages libvirt-bin recommends:
ii  bridge-utils               1.4-5         Utilities for configuring the Linu
ii  dnsmasq-base               2.52-1        A small caching DNS proxy and DHCP
ii  iptables                   1.4.6-2       administration tools for packet fi
ii  netcat-openbsd             1.89-4        TCP/IP swiss army knife
ii  qemu                       0.12.3+dfsg-4 fast processor emulator

Versions of packages libvirt-bin suggests:
ii  policykit-1                   0.96-2     framework for managing administrat

-- no debconf information

-- 
Klaus Ethgen                            http://www.ethgen.de/
pub  2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <Klaus at Ethgen.de>
Fingerprint: D7 67 71 C4 99 A6 D4 FE  EA 40 30 57 3C 88 26 2B
-------------- next part --------------
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -559,28 +559,28 @@ static int udevProcessUSBInterface(struc
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceNumber",
                              &data->usb_if.number,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceClass",
                              &data->usb_if._class,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceSubClass",
                              &data->usb_if.subclass,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceProtocol",
                              &data->usb_if.protocol,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20100426/3d7600a5/attachment.pgp>