[Pkg-libvirt-maintainers] Bug#559298: Bug#559298: virt-manager: problems with multiple windows

[Gabor Gombas]

On Tue, Dec 08, 2009 at 06:32:38PM +0100, Guido Günther wrote:

> This might be caused by nc calls needing a "-q 0" argument. Could you
> try adding these, it would involve adding this to libvirt in
> src/remote/remote_driver.c as well as virt-manager in
> src/virtManager/console.py (the later one only for console usage).

That indeed seems to do the trick. See below for the patches I've used.

Gabor

diff -u -r libvirt-0.7.5/src/remote/remote_driver.c libvirt-0.7.5.new/src/remote/remote_driver.c
--- libvirt-0.7.5/src/remote/remote_driver.c	2009-12-22 17:45:39.000000000 +0100
+++ libvirt-0.7.5.new/src/remote/remote_driver.c	2010-01-08 09:59:38.219846339 +0100
@@ -730,7 +730,7 @@
     }
 
     case trans_ssh: {
-        int j, nr_args = 6;
+        int j, nr_args = 8;
 
         if (username) nr_args += 2; /* For -l username */
         if (no_tty) nr_args += 5;   /* For -T -o BatchMode=yes -e none */
@@ -764,6 +764,8 @@
         }
         cmd_argv[j++] = strdup (priv->hostname);
         cmd_argv[j++] = strdup (netcat ? netcat : "nc");
+        cmd_argv[j++] = strdup ("-q");
+        cmd_argv[j++] = strdup ("0");
         cmd_argv[j++] = strdup ("-U");
         cmd_argv[j++] = strdup (sockname ? sockname :
                                 (flags & VIR_CONNECT_RO

diff -u -r virt-manager-0.8.2/src/virtManager/console.py virt-manager-0.8.2.new/src/virtManager/console.py
--- virt-manager-0.8.2/src/virtManager/console.py	2009-12-14 23:40:30.000000000 +0100
+++ virt-manager-0.8.2.new/src/virtManager/console.py	2010-01-08 09:16:08.723346250 +0100
@@ -506,7 +506,7 @@
         if username:
             argv += ['-l', username]
 
-        argv += [ server, "nc", vncaddr, str(vncport) ]
+        argv += [ server, "nc", "-q", "0", vncaddr, str(vncport) ]
 
         logging.debug("Creating SSH tunnel: %s" % argv)
 
-- 
     ---------------------------------------------------------
     MTA SZTAKI Computer and Automation Research Institute
                Hungarian Academy of Sciences
     ---------------------------------------------------------