[Pkg-libvirt-maintainers] Bug#637548: Bug#637548: virt-viewer: should not hardcode SSH port 22, but read from ~/.ssh/config

[Guido Günther]

tags 637548 +patch

On Fri, Aug 12, 2011 at 04:42:39PM +0200, Guido Günther wrote:
> Hi Luca,
> 
> On Fri, Aug 12, 2011 at 03:23:17PM +0200, Luca Capello wrote:
> > Package: virt-viewer
> > Version: 0.4.0-1
> > Severity: important
> > Tags: upstream
> > Usertags: pca-virtualization
> > 
> > Hi there!
> > 
> > 0.4.0-1 is supposed to solve this issue thanks to:
> > 
> >   <http://anonscm.debian.org/gitweb/?p=pkg-libvirt/virt-viewer.git;a=commitdiff;h=2376c067bd80cf68c425d51982deece3e6129e1a>
> 
> This looks like a brown paper bag for me. It has 
> 
> if (!sshport) 
> 
> while it should have 
> 
> if (sshport)
> 
> in virt-viewer-app.c:322. Sorry for that. I'll roll out a new version
> but will wait for your patch.

The attached patch works for me with:

* no port given
* port specified in .ssh/config
* port given in the URL

Are you seeing any other problems?
Cheers,
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-reversed-logic-for-ssh-port-setting.patch
Type: text/x-diff
Size: 722 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20110812/e8503b5f/attachment-0001.patch>