[Pkg-libvirt-maintainers] Bug#637548: Bug#637548: Bug#637548: virt-viewer: should not hardcode SSH port 22, but read from ~/.ssh/config

[Guido Günther]

Hi Luca,

On Fri, Aug 12, 2011 at 05:30:12PM +0200, Luca Capello wrote:
[..snip..] 
> Well, I seem to remember I tested your patch at DebConf11, but maybe it
> was not the case, so blame on me as well for that ;-)

My error was that I had ssh on 2222 and on 22 ;) and I messed up the if
statement when moving from 0.4.0 to 0.4.1. I've cherry-picked the
changes from your patch and also cleaned up the debugging part so it
will now always print the correct ssh connection information and not
guess values for unset port. Hopefully this eases debugging in the
future.
Thanks again for the patch,
 -- Guido

> 
> The package used to test the patch attached below is available at the
> following link, it includes an extra debug patch that shows each value
> used to construct the SSH/nc tunnel:
> 
>   <http://people.debian.org/~gismo/tmp/virt-viewer_0.4.1-2~637548.dsc>