[Pkg-libvirt-maintainers] Bug#647953: libvirt: Libvirt logrotate files not installed

[Serge Hallyn]

Package: libvirt
Version: 0.9.6-2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu precise ubuntu-patch


Version: 0.9.6-2

debian/rules tries to copy the logrotate files from $(CURDIR)/daemon/*,
but the files exist in $(CURDIR)/debian/build/daemon/*.

Also, the /var/log/libvirt/qemu (and such) files are created using
libvirt-bin.dirs, but that means that, if they are empty, they are
removed when we apt-get remove libvirt-bin.  The logrotate files are
not, which then raises errors on subsequent logrotate runs.

*** /tmp/tmpwWRd8m
In Ubuntu, the attached patch was applied to achieve the following:

## ---------------- REPLACE THIS WITH ACTUAL INFORMATION ---------------------
## Please add all necessary information about why the change needed to go in
## Ubuntu, quote policy, spec or any other background material and why it can
## and should be used in Debian too.  If the patch is composed of multiple
## independent pieces, please send them as separate bug reports.
## ---------------- REPLACE THIS WITH ACTUAL INFORMATION ---------------------


  * Move creation of /var/log/libvirt/{lxc,uml,qemu} dirs from libvirt-bin.dirs
    to libvirt-bin.postinst.  Otherwise after a 'apt-get remove libvirt-bin',
    that dir will be removed (if empty) but /etc/logrotate.d/libvirtd will 
    still try to rotate it and raise errors. (LP: #886770)
  * debian/rules: Fix a bug in the new logic for installing upstream-supplied
    logrotate files.  (LP: #887312)


Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-12-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmpsSI0VR
Type: text/x-diff
Size: 1499 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20111107/e8dd53a0/attachment-0001.diff>