[Pkg-libvirt-maintainers] Bug#676345: libvirt: [Patch] Enable sanlock

[Guido Günther]

Hi David,
On Wed, Jun 06, 2012 at 12:17:15PM +0200, David Weber wrote:
> Package: libvirt0
> Version: 0.9.12-1.1
> Severity: wishlist
> File: libvirt
> 
> Hi,
> 
> please apply the attached patch to enable sanlock in libvirt

Thanks for the patch some quick questions:

> + libsanlock-dev,
> + libsanlock-client1,

Shouldn't libsanlock-dev pull in libsanlock-client1?

>  # For "make check"
>   dwarves,
>   libxml2-utils,
> @@ -95,6 +97,18 @@ Description: library for interfacing with different virtualization systems
>   .
>   This package contains the debugging symbols.
>  
> +Package: libvirt-sanlock
> +Architecture: any
> +Depends: ${shlibs:Depends}, ${misc:Depends}, libvirt0 (= ${binary:Version}), augeas-tools

What is augeas-tools needed for?

[..snip..] 
>  usr/share/man/man8/*
> diff --git a/debian/libvirt-sanlock.cron.weekly b/debian/libvirt-sanlock.cron.weekly
> new file mode 100644
> index 0000000..170d91b
> --- /dev/null
> +++ b/debian/libvirt-sanlock.cron.weekly
> @@ -0,0 +1,10 @@
> +#!/bin/sh
> +
> +#Disabled by default, uncomment to enable
> +exit 0

Why would we disable this by default?

> +
> +
> +/usr/sbin/virt-sanlock-cleanup -q 2>/dev/null

Why would we discard stderr here?

Cheers,
 -- Guido