[Pkg-libvirt-maintainers] Bug#676345: Re-2: Bug#676345: libvirt: [Patch] Enable sanlock

[David Weber]

> Hi David,
> On Wed, Jun 06, 2012 at 12:17:15PM +0200, David Weber wrote:
> > Package: libvirt0
> > Version: 0.9.12-1.1
> > Severity: wishlist
> > File: libvirt
> > 
> > Hi,
> > 
> > please apply the attached patch to enable sanlock in libvirt
> 
> Thanks for the patch some quick questions:
> 
> > + libsanlock-dev,
> > + libsanlock-client1,
> Shouldn't libsanlock-dev pull in libsanlock-client1?

You're right, the line can be dropped. 

> 
> >  # For "make check"
> >   dwarves,
> >   libxml2-utils,
> >  -95,6 +97,18  Description: library for interfacing with different 
> > virtualization systems
> >   .
> >   This package contains the debugging symbols.
> >  
> > +Package: libvirt-sanlock
> > +Architecture: any
> > +Depends: ${shlibs:Depends}, ${misc:Depends}, libvirt0 (= ${binary:Version})
> > , augeas-tools
> 
> What is augeas-tools needed for?

It is needed for the cleanup cronjob, it uses augeas-tools to read the config
files. See /usr/sbin/virt-sanlock-cleanup

> 
> [..snip..] 
> >  usr/share/man/man8/*
> > diff --git a/debian/libvirt-sanlock.cron.weekly b/debian/libvirt-sanlock.
> > cron.weekly
> > new file mode 100644
> > index 0000000..170d91b
> > --- /dev/null
> > +++ b/debian/libvirt-sanlock.cron.weekly
> >  -0,0 +1,10 
> > +#!/bin/sh
> > +
> > +#Disabled by default, uncomment to enable
> > +exit 0
> 
> Why would we disable this by default?

I experienced some problems like crashing the sanlock deamon when running
the script. It was with a bit older version so it maybe works better
now but I wouldn't recommend it. I hope I can re-test it soon.

Fedora btw. also doesn't enable it as far as I can see.

> 
> > +
> > +
> > +/usr/sbin/virt-sanlock-cleanup -q 2>/dev/null
> 
> Why would we discard stderr here?

Fixed.

Updated patch attached.

> 
> Cheers,
>  -- Guido
> 


To: agx at sigxcpu.org
    676345 at bugs.debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt_enable_sanlock.diff
Type: application/octet-stream
Size: 7243 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20120611/38557ee1/attachment-0001.obj>