[Pkg-libvirt-maintainers] Bug#720623: virt-manager: System tray displayed with broken icon

[Flos Lonicerae]

Package: virt-manager
Version: 0.9.5-1
Severity: normal

Dear Maintainer,

Please check the reproducer below:

1. Add some debug information to systray.py

 61         # Are we using Application Indicators?
 62         if appindicator is not None:
 63             logging.debug("DBG: imported") <======= HERE
 64             self.systray_indicator = True
 65


2. Run 'virt-manager --debug' to watch debug output, the following message can
be found

2013-08-24 12:05:52,333 (systray:63): DBG: imported

3. Select 'Edit'-->'Preference'-->'General'-->'Enable system tray icon', the
system tray can be displayed but the icon is broken.

4. Back to the code, the root cause is the 'virt-manager-icon' cannot be found
while systray_indicator is using:

116     def init_systray(self):
117         # Build the systray icon
118         if self.systray_icon:
119             return
120
121         if self.systray_indicator:
122             self.systray_icon = appindicator.Indicator("virt-manager",
123                                 "virt-manager-icon", <============== No
icon with name "virt-manager-icon" found
124                                 appindicator.CATEGORY_OTHER)
125             self.systray_icon.set_status(appindicator.STATUS_ACTIVE)
126             self.systray_icon.set_menu(self.systray_menu)
127
128         else:
129             self.systray_icon = gtk.StatusIcon()
130             self.systray_icon.set_visible(True)
131             self.systray_icon.set_property("icon-name", "virt-manager")
132             self.systray_icon.connect("activate", self.systray_activate)
133             self.systray_icon.connect("popup-menu", self.systray_popup)
134             self.systray_icon.set_tooltip(_("Virtual Machine Manager"))
135
136     def show_systray(self, ignore1=None, ignore2=None, ignore3=None,
137                      ignore4=None):
138         do_show = self.config.get_view_system_tray()
139         logging.debug("Showing systray: %s", do_show)
140
141         if not self.systray_icon:
142             if do_show:
143                 self.init_systray()
144         else:
145             if self.systray_indicator:
146                 if do_show:
147
self.systray_icon.set_status(appindicator.STATUS_ACTIVE)
148                 else:
149
self.systray_icon.set_status(appindicator.STATUS_PASSIVE)
150             else:
151                 self.systray_icon.set_visible(do_show)

5. Currently I can fix this issue by ugly hacking the 'virt-manager-icon' to
'virt-manager'. But do we miss something while packaging or it is really a bug
in upstream?

*PS* file 'systray.py' debsums changed due to adding the debug line above.



-- System Information:
Debian Release: jessie/sid
  APT prefers testing-proposed-updates
  APT policy: (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.10-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages virt-manager depends on:
ii  gconf2             3.2.6-1
ii  librsvg2-common    2.36.4-2
ii  python             2.7.5-4
ii  python-dbus        1.2.0-2+b1
ii  python-glade2      2.24.0-3+b1
ii  python-gnome2      2.28.1+dfsg-1
ii  python-gtk-vnc     0.5.2-2
ii  python-gtk2        2.24.0-3+b1
ii  python-ipy         1:0.75-1
ii  python-libvirt     0.9.12-11+deb7u1
ii  python-support     1.0.15
ii  python-urlgrabber  3.9.1-4
ii  python-vte         1:0.28.2-5
ii  virtinst           0.600.4-2

Versions of packages virt-manager recommends:
ii  gnome-icon-theme         3.8.2-2
ii  libvirt-bin              0.9.12-11+deb7u1
ii  python-spice-client-gtk  0.12-5

Versions of packages virt-manager suggests:
ii  gnome-keyring                    3.4.1-5
ii  python-gnomekeyring              2.32.0+dfsg-3
pn  python-guestfs                   <none>
ii  ssh-askpass                      1:1.2.4.1-9
ii  ssh-askpass-gnome [ssh-askpass]  1:6.2p2-6
ii  virt-viewer                      0.5.3-1

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/virt-manager/virtManager/systray.py (from virt-manager package)