[Pkg-libvirt-maintainers] Bug#701570: Bug#701570: libvirt-bin: please document hook error 512

[Guido Günther]

On Sun, Feb 24, 2013 at 05:05:35PM +0100, Luca Capello wrote:
> Package: libvirt-bin
> Version: 0.9.12-6~bpo60+1
> Severity: wishlist
> Usertags: pca.it-virtualization
> 
> Hi there!
> 
> After a reboot, the virtual XP hosted on a Debian squeeze did not come
> up automatically, with the following error:
> =====
> root at tinello:/etc# tail /var/log/libvirt/libvirtd.log
> 2013-02-24 15:19:46.076+0000: 11560: error : virCommandWait:2306 : internal error Child process (tc qdisc del dev virbr0 root) status unexpected: exit status 2
> 2013-02-24 15:19:46.077+0000: 11560: error : virCommandWait:2306 : internal error Child process (tc qdisc del dev virbr0 ingress) status unexpected: exit status 2
> 2013-02-24 15:19:46.106+0000: 11560: error : virCommandWait:2306 : internal error Child process (/sbin/iptables --table mangle --delete POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill) status unexpected: exit status 2
> 2013-02-24 15:20:00.307+0000: 11739: info : libvirt version: 0.9.12
> 2013-02-24 15:20:00.307+0000: 11739: error : virCommandWait:2306 : internal error Child process (/sbin/iptables --table mangle --insert POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill) status unexpected: exit status 2
> 2013-02-24 15:20:00.307+0000: 11739: warning : networkAddGeneralIptablesRules:1301 : Could not add rule to fixup DHCP response checksums on network 'default'.
> 2013-02-24 15:20:00.307+0000: 11739: warning : networkAddGeneralIptablesRules:1302 : May need to update iptables package & kernel to support CHECKSUM rule.
> 2013-02-24 15:20:00.810+0000: 11739: error : virHookCall:280 : Hook script execution failed: Hook script /etc/libvirt/hooks/qemu qemu failed with error code 512
> 2013-02-24 15:20:00.829+0000: 11739: error : virHookCall:280 : Hook script execution failed: Hook script /etc/libvirt/hooks/qemu qemu failed with error code 512
> 2013-02-24 15:20:00.830+0000: 11739: error : qemuAutostartDomain:177 : Failed to autostart VM 'tinello-xp.pca.it': Hook script execution failed: Hook script /etc/libvirt/hooks/qemu qemu failed with error code 512
> root at tinello:/etc#
> =====
> 
> First, the CHECKSUM problem is an old one (see #598330): while this is
> simply a warning, IMHO it should be fixed in the backports as well.
> 
> Second, after some debugging I discovered that I forgot to close a case
> statement for the GUEST_NAME in the hook script I provided in:

Help on maintaining the squeeze-backports version is welcome since
properly maintaining 5 versions isn't something I'm able to do in a
timely manner at the moment.

> 
>   <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=637219#52>
> 
> However, the fact that there is no mention of the meaning of 'error code
> 512' in the official libvirt wiki means that it is almost impossible to
> understand if the error is in the hook script or in libvirt-bin.  FTR, I
> was expecting 'error code 256' instead:
> 
>   <http://www.libvirt.org/hooks.html#return_codes>

It seems recent versions propagate the hooks error code verbatim. I've
sent a patch upstream to update the docs to get some input whether this
is desired (preferred since masking the error code makes no sense) or a
bug.
Cheers,
 -- Guido