[Pkg-libvirt-maintainers] Bug#712563: Bug#712563: virtinst with xen is brocken in wheezy

[Guido Günther]

HI Oliver,
On Mon, Jun 17, 2013 at 10:18:01AM +0200, Oliver wrote:
> Package: virtinst
> Version: 0.600.1-3
> Severity: normal
> 
> Dear Maintainer,
> 
> the path for the xen binaries in virtinst is brocken in wheezy and so it
> cannot be used for xen systems. I attached a patch which will fix this problem.
> This problem also exists in unstable.

Thanks a lot for this! Note that this patch unbreaks Debian but might
break using virtinst for other hosts accessed via remote URIs but that's
not worse that it was before. I'll try to squash this into a unstable 
and then into a wheezy point release.
Cheers,
 -- Guido

> 
> -- System Information:
> Debian Release: 7.1
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
> Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages virtinst depends on:
> ii  python             2.7.3-4
> ii  python-libvirt     0.9.12-11+deb7u1
> ii  python-libxml2     2.8.0+dfsg1-7+nmu1
> ii  python-support     1.0.15
> ii  python-urlgrabber  3.9.1-4
> 
> Versions of packages virtinst recommends:
> pn  qemu         <none>
> pn  virt-viewer  <none>
> 
> virtinst suggests no packages.
> 

> diff --git a/debian/patches/0001-fix-path-to-hvmloader.patch b/debian/patches/0001-fix-path-to-hvmloader.patch
> index fc4a349..a3f926f 100644
> --- a/debian/patches/0001-fix-path-to-hvmloader.patch
> +++ b/debian/patches/0001-fix-path-to-hvmloader.patch
> @@ -1,8 +1,8 @@
> -From: Guido Guenther <agx at sigxcpu.org>
> -Date: Tue, 24 Jun 2008 15:24:21 +0200
> +From: Oliver Seufer <debian at seufer.de>
> +Date: Sat, 01 Jun 2013 22:41:07 +0200
>  Subject: fix path to hvmloader
>  
> -Closes: #487682
> +Closes: #685749
>  ---
>   virtinst/Installer.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> @@ -16,7 +16,7 @@ index 796cc86..61f6387 100644
>   
>           if not loader and self.is_hvm() and hvxen:
>  -            loader = "/usr/lib/xen/boot/hvmloader"
> -+            loader = "/usr/lib/xen-default/boot/hvmloader"
> ++            loader = "hvmloader"
>   
>           # Use older libvirt 'linux' value for back compat
>           if os_type == "xen" and hvxen:
> diff --git a/debian/patches/0002-Fix-path-to-pygrub.patch b/debian/patches/0002-Fix-path-to-pygrub.patch
> index f46a770..be46af1 100644
> --- a/debian/patches/0002-Fix-path-to-pygrub.patch
> +++ b/debian/patches/0002-Fix-path-to-pygrub.patch
> @@ -1,7 +1,8 @@
> -From: Marco Sinhoreli <msinhore at gmail.com>
> -Date: Thu, 26 Jun 2008 18:07:13 +0200
> +From: Oliver Seufer <debian at seufer.de>
> +Date: Sat, 01 Jun 2013 22:41:07 +0200
>  Subject: Fix path to pygrub
>  
> +Closes: #685749
>  ---
>   virtinst/util.py |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> @@ -15,12 +16,12 @@ index d012692..1d2a1f6 100644
>               return "/usr/lib/xen/bin/pygrub"
>           else:
>  -            return "/usr/bin/pygrub"
> -+            return "/usr/lib/xen-default/bin/pygrub"
> ++            return "pygrub"
>   
>       if platform.system() == "SunOS":
>           return "/usr/lib/xen/bin/pygrub"
>  -    return "/usr/bin/pygrub"
> -+    return "/usr/lib/xen-default/bin/pygrub"
> ++    return "pygrub"
>   
>   def uri_split(uri):
>       """

> _______________________________________________
> Pkg-libvirt-maintainers mailing list
> Pkg-libvirt-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-libvirt-maintainers