[Pkg-libvirt-maintainers] Bug#691784: [virt-manager] make spice optional (on !linux-{i386, amd64})

[Guido Günther]

On Fri, Sep 20, 2013 at 11:16:37AM +0200, Guido Günther wrote:
> On Wed, Sep 18, 2013 at 06:30:09PM -0700, Vagrant Cascadian wrote:
> > On Tue, Sep 03, 2013 at 10:44:08PM +0200, Guido Günther wrote:
> > > On Tue, Sep 03, 2013 at 01:18:39PM -0700, Vagrant Cascadian wrote:
> > > > Would it be feasible to upload this fix to wheezy-proposed-updates, since the
> > > > package is uninstallable on non-x86 arches? Is it a simple change in the
> > > > Depends/Recommends, or does it require code changes that would be too invasive
> > > > for wheezy?
> > > 
> > > It should be only the dependency change. Spice should be optional one
> > > would have to test if this holds true for the version in wheezy too.
> > > Could you test that?
> > 
> > Tested and works for me on wheezy armhf... 
> > 
> > I suspect it would work with other arches as well, although could change
> > behavior when recommends are disabled on i386 and amd64...
> 
> Well, what about this then:
> 
> Subject: [PATCH] spice is only available on i386 and amd64
> 
> so don't depend on it on other architectures

...won't work since it's arch all - sorry for the noise. We'll use the
recommends then.
Cheers,
 -- Guido

> ---
>  debian/control | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/control b/debian/control
> index a16aff7..8c21f1b 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -16,7 +16,8 @@ Architecture: all
>  Depends: ${misc:Depends}, ${python:Depends}, python-gtk2,
>   python-glade2, python-gnome2, python-dbus, python-urlgrabber, python-vte,
>   librsvg2-common, python-libvirt (>= 0.7.1), virtinst (>= 0.600.1),
> - python-gtk-vnc (>= 0.3.8), python-ipy (>= 0.70), python-spice-client-gtk
> + python-gtk-vnc (>= 0.3.8), python-ipy (>= 0.70),
> + python-spice-client-gtk [i386 amd64]
>  Recommends: libvirt-bin (>= 0.4.6), gnome-icon-theme
>  Suggests: virt-viewer, ssh-askpass, gnome-keyring, python-gnomekeyring, hal,
>   python-guestfs
> -- 
> 1.8.4.rc3
>