[Pkg-libvirt-maintainers] Bug#757293: Bug#757293: libvirt-daemon-system (1.2.7-3) fails to start

[Guido Günther]

On Thu, Aug 07, 2014 at 09:24:32AM +0200, Laurent Bigonville wrote:
> Package: libvirt-daemon-system
> Followup-For: Bug #757293
> 
> Hello,
> 
> MMMh, my bad I guess
> 
> As the libvirt-bin package has been renamed to libvirt-daemon-system,
> the preinst script part that stop the daemon cleanly is not executed
> since libvirt-daemon-system was not installed before...
> 
> What could be done:
> 
>  - Remove the -nl part of the version comparaison, this will execute the
>    stop and the deb-systemd-helper actions even if the package was not
>    installed before (we need to be sure that d-s-h is not giving us an
>    error if the old service file is inexistant)

Aargh...I already removed the -nl part when doing the upgrade tests
and everything was in the postinst but the move to the preinst brought
it back in, see:

   daf46feb8a165dbb1e2f6afd157bdc5ec11a4351

Sorry for not spotting this when reviewing the patch. Since we're
using a pidfile in the start-stop-daemon invocation and that one
doesn't exit if the package wasn't installed just removeing the '-ne'
should be enough. 

d-s-h also returns 0 if the service file is not there. I'll remove the
-nl then and reupload. Thanks!
 -- Guido