[Pkg-libvirt-maintainers] Bug#739096: Bug#739096: libvirt-bin: Inconsistency between dh_systemd_start and dh_installinit calls

[Laurent Bigonville]

Le Sat, 15 Feb 2014 22:04:17 +0100,
Guido Günther <agx at sigxcpu.org> a écrit :

> On Sat, Feb 15, 2014 at 08:27:32PM +0100, Laurent Bigonville wrote:
> >   dh_installinit --name=libvirt-bin --no-restart-on-upgrade --
> > defaults 28 72 dh_installinit --name=libvirt-guests
> > --no-restart-on-upgrade -- defaults 29 71 dh_systemd_start
> > --restart-after-upgrade
> > 
> > "--restart-after-upgrade" is passed to dh_systemd_start while
> This means we restart the daemon in the postinst without stopping it
> in the preinst.
> 
> > "--*no*-restart-on-upgrade" is passed to dh_installinit.
> And this one too. We're not stopping the daemon in the preinst and
> only restart it in the postinst.

OK I see now, you are stopping the daemon only if you are upgrading
from 0.6.0 or later. 0.6.0 is quite old now, the postinstall script
should maybe be cleanup a bit, see my attached patch.

Cheers,

Laurent Bigonville
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 739096.patch
Type: text/x-patch
Size: 1793 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20140216/9f05a180/attachment-0001.bin>