[Pkg-libvirt-maintainers] Bug#730604: Bug#730604: libvirt-bin: Please rename libvirt-bin.service back to libvirtd.service and use symlink or Alias= instead

[Laurent Bigonville]

Le Wed, 27 Nov 2013 08:08:22 +0100,
Guido Günther <agx at sigxcpu.org> a écrit :

> On Wed, Nov 27, 2013 at 07:36:31AM +0100, Laurent Bigonville wrote:
> > Package: libvirt-bin
> > Version: 1.1.4-1
> > Severity: normal
> > 
> > Hi,
> > 
> > Could you please rename back the libvirt-bin.service systemd service
> > file to libvirtd.service and use a symlink (libvirtd.service ->
> > libvirt-bin.service) or add Alias=libvirt-bin.service in the service
> > file instead.
> 
> I've actually done this already here a couple of weeks ago to reduce
> the upstream diff but didn't get around to test if the upgrade works
> as expected when the unit name changes (since we don't stop the
> service in the preinst). Now that I read the below it was a good idea
> to not upload without proper testing.

OK, we had an issue in quasi-similar situation with network-manager, see
#734460)

systemd when stopping the service, is looking in the cgroups for the
canonical name of the .service file. If it cannot find it, it thinks
the service is dead. The canonical name of the service would change
during the upgrade and systemd will be confused.

So you'll have to stop libvirt on upgrade if you are upgrading from a
previous version and that the user is running systemd. The proper way
to test this is to test:

[ -d /run/systemd/system ]

Cheers,

Laurent Bigonville