[Pkg-libvirt-maintainers] Bug#594444: Bug#594444: libvirt-bin: "virsh edit <domain>" should fall back to /usr/bin/editor if $EDITOR is not set

[Guido Günther]

On Fri, Jul 18, 2014 at 09:16:17PM +1000, Dmitry Smirnov wrote:
> Please use the attached patch.

Good idea! But shouldn't this be sensible-editor on Debian as per
11.4. of policy.
Cheers,
 -- Guido

> 
> Thank you.
> 
> -- 
> All the best,
>  Dmitry Smirnov
>  GPG key : 4096R/53968D1B

> Last-Update: 2014-07-14
> Forwarded: not-needed
> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594444
> Author: Dmitry Smirnov <onlyjob at member.fsf.org>
> Description: Use default system editor instead of `vi` (respect Debian alternatives system).
> 
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -764,9 +764,9 @@
>      editor = virGetEnvBlockSUID("VISUAL");
>      if (!editor)
>          editor = virGetEnvBlockSUID("EDITOR");
>      if (!editor)
> -        editor = "vi"; /* could be cruel & default to ed(1) here */
> +        editor = "editor"; /* could be cruel & default to ed(1) here */
>  
>      /* Check that filename doesn't contain shell meta-characters, and
>       * if it does, refuse to run.  Follow the Unix conventions for
>       * EDITOR: the user can intentionally specify command options, so




> _______________________________________________
> Pkg-libvirt-maintainers mailing list
> Pkg-libvirt-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-libvirt-maintainers