[Pkg-libvirt-maintainers] Bug#730604: Bug#730604: Bug#730604: libvirt-bin: Please rename libvirt-bin.service back to libvirtd.service and use symlink or Alias= instead

[Laurent Bigonville]

Le Thu, 31 Jul 2014 17:03:23 +0200,
Guido Günther <agx at sigxcpu.org> a écrit :

> On Thu, Jul 31, 2014 at 04:18:24PM +0200, Laurent Bigonville wrote:
> > Le Fri, 25 Apr 2014 20:29:08 +0200,
> > Guido Günther <agx at sigxcpu.org> a écrit :
> > 
> > > Hi Laurent,
> > > On Fri, Apr 25, 2014 at 01:53:52PM +0200, Laurent Bigonville
> > > wrote:
> > > > Package: libvirt-bin
> > > > Followup-For: Bug #730604
> > > > 
> > > > Hello,
> > > > 
> > > > Are you still OK with this patch? Uploading it to experimental
> > > > might be a good idea show people can test if everything is
> > > > going OK with the restart of the daemon?
> > > 
> > > Patch is still fine I'm just lagging in libvirt work (didn't get
> > > around to look into the FTBFS on i386 even). The plan was to add
> > > this to with 1.2.4.
> > 
> > OK, so apparently, the service file is now containing
> > "Restart=on-failure" which mean that we cannot just blindly kill the
> > process in the postinst script.
> > 
> > I guess the patch needs to be updated to stop libvirt cleanly in the
> > preinst script instead but this will result in an longer downtime. I
> > guess that we need to do this before jessie release to not impact
> > people upgrading between jessie and jessie+1
> 
> Yeah, it's there since 1.1.2 as I just checked. I do wonder why I
> didn't trip on it during my tests though. The version including your
> patch is sitting in NEW since a couple of days. Do you intend to
> send an updated patch?

OK here is the patch that you can apply on the top of the experimental
branch.

I didn't test it though, but it looks OK to me.

BTW, libvirt just got accepted.

Cheers,

Laurent Bigonville
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Stop-the-daemon-in-the-preinst-script-when-renaming-.patch
Type: text/x-patch
Size: 3189 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20140731/6d18c178/attachment.bin>