[Pkg-libvirt-maintainers] Bug#833745: Bug#833745: libvirt-daemon-system: Please use SIGUSR1 to restart virtlockd and virtlogd on upgrade

[Guido Günther]

On Tue, Aug 09, 2016 at 12:44:41AM +0200, Laurent Bigonville wrote:
> Le 08/08/16 à 18:59, Guido Günther a écrit :
> > We should be doing this for virtlockd already since ages, we have:
> > 
> >    dh_systemd_start -p libvirt-daemon-system --no-restart-on-upgrade libvirt-guests.service virtlockd.socket virtlockd.service
> > 
> > so this should work. virtlogd is indeed missing. Do you have a log of
> > the virtlockd restart?
> Looking at /var/lib/dpkg/info/libvirt-daemon-system.postinst, virtlockd is
> not restarted or reloaded at all, only started the first time:
> 
> # End automatically added section
> # Automatically added by dh_systemd_start
> if [ -d /run/systemd/system ]; then
>         systemctl --system daemon-reload >/dev/null || true
>         if [ -n "$2" ]; then
>                 _dh_action=try-restart
>         else
>                 _dh_action=start
>         fi
>         deb-systemd-invoke $_dh_action virtlockd.socket >/dev/null || true
> fi
> # End automatically added section
> # Automatically added by dh_systemd_start
> if [ -d /run/systemd/system ]; then
>         systemctl --system daemon-reload >/dev/null || true
>         deb-systemd-invoke start virtlockd.service virtlockd.socket >/dev/null || true
> fi

I'm not talking about the automatically added stuff. I mean

$ git show debian/sid:debian/libvirt-daemon-system.postinst | grep -C2 reload
        # Force virtlockd to reexec if enabled
        if [ -d /run/systemd/system ] && systemctl is-active -q virtlockd.service; then
           systemctl reload virtlockd.service
        fi

Cheers,
 -- Guido