[Pkg-libvirt-maintainers] Bug#848247: Bug#848247: Collection of fixes for libvirt smoke tests

[Guido Günther]

On Thu, Dec 15, 2016 at 05:16:33PM +0100, Christian Ehrhardt wrote:
> Package: libvirt
> Version: 2.5.0-1
> Severity: normal

Thanks for these. I've pulled parts in but I thins some are not needed:
> 
> d/t/control, d/t/smoke-qemu-session, d/t/smoke-lxc: fix up smoke tests
> 
> ERR: error: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No
>      such file or directory
> FIX: install libvirt-daemon-system

No, we run as non-root so (so we can use qemu:///session)

> 
> ERR: error: Failed to connect socket to '/var/run/libvirt/libvirt-sock':
>      Permission denied
> FIX: set needs-root

See above.

> ERR: arch can be <arch>x86_64</arch>
> FIX: modify grep "arch name='x86_64'" -> "arch.*x86_64""

Which versions did you see this with?

> ERR: no os_type hvm in capabilities
> FIX: install qemu-system

Applied.

> ERR: /usr/bin/virt-xml-validate: cannot determine schema type for
>      smoke-qemu-session.xml
> FIX: libxml2-utils is "only" recommend which is right, but that means it is
>      needed as a test dependency here, so install libxml2-utils

Applied.

> 
> ERR: error: Cannot check QEMU binary /usr/bin/kvm: No such file or directory
> FIX: again only recommend, so test dependency to install qemu-kvm

Applied.

> 
> ERR: potential race, guest dies on most non bare metal platforms after a few
>      seconds
> FIX: well, not a fix but add FIXME comment on 2nd level virtualization
>      issues

I'm not sure how this helps here.

> 
> ERR: not all autopkgtest platforms can host containers
> FIX: use the existing call to virt-host-validate lxc as early exit

Nice idea, applied.

> ERR: /usr/bin/virt-xml-validate: cannot determine schema type for smoke-lxc.xml
> FIX: again libxml2-utils test dependency

Applied.

> ERR: potential race on the check of lxc log after start
> FIX: lacking a better fix a sleep and sync to closen the remaining
> race window

Hmm...did you see this? If so we should rather check for running again
with virsh and then check the log.

Thanks!
 -- Guido