[Pkg-libvirt-maintainers] Bug#848314: Bug#848314: Further fix for discussion in the scope of smoke-qemu-session

[Guido Günther]

On Fri, Dec 16, 2016 at 10:31:58AM +0100, Christian Ehrhardt wrote:
> On Fri, Dec 16, 2016 at 10:07 AM, Guido Günther <agx at sigxcpu.org> wrote:
> 
> > The fix is to use qemu not kvm in the domain XML in this case.
> 
> 
> If that is the way to go - to focus on testing qemu:/// - that is right.
> The current call to virt-host-validate qemu already has a || true so it is
> not fatal which is good.
> 
> What do you think of something like the following then (untested so far):
> (this is based on my current d/t/control so your diff might be slightly
> different.
> That gets more similar again when I rebase to your latest code early next
> week.)
> 
> diff --git a/debian/tests/control b/debian/tests/control
> index c4f5244..cd15424 100644
> --- a/debian/tests/control
> +++ b/debian/tests/control
> @@ -4,7 +4,7 @@ Restrictions: allow-stderr
> 
> Tests: smoke-qemu-session
> Depends: libvirt-daemon-system, libvirt-clients, qemu-system,
> libxml2-utils,
> -         qemu-kvm
> +         qemu-user

You want qemu-system running as non root not qemu-user.

> Restrictions: allow-stderr, isolation-machine, needs-root
> 
> Tests: smoke-lxc
> diff --git a/debian/tests/smoke-qemu-session.xml
> b/debian/tests/smoke-qemu-session.xml
> index 47b33d5..c471ff2 100644
> --- a/debian/tests/smoke-qemu-session.xml
> +++ b/debian/tests/smoke-qemu-session.xml
> @@ -1,4 +1,4 @@
> -<domain type='kvm'>
> +<domain type='qemu'>
>   <name>sqs</name>
>   <memory unit='KiB'>256000</memory>
>   <currentMemory unit='KiB'>256000</currentMemory>
> @@ -18,7 +18,7 @@
>   <on_reboot>destroy</on_reboot>
>   <on_crash>destroy</on_crash>
>   <devices>
> -    <emulator>/usr/bin/kvm</emulator>
> +    <emulator>/usr/bin/qemu-x86_64</emulator>

Like this but using qemu-system-x86_64.

Thanks for looking into this!
 -- Guido

>     <controller type='virtio-serial' index='0'>
>       <alias name='virtio-serial0'/>
>       <address type='pci' domain='0x0000' bus='0x00' slot='0x04'
> function='0x0'/>
> 
> 
> -- 
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd