[Pkg-libvirt-maintainers] Bug#837995: libvirt: please run tests on arm architectures

[Riku Voipio]

Source: libvirt
Version: 2.2.0-1
Severity: wishlist
Tags: patch

In my tests, libvirt tests pass fine on armhf/arm64. I take we
have newer kernel than debian builders, so it could fail in Debian.
To play safe, I suggest running tests but not failing them on arm/arm64.
This what the patch below does, being minimum impact.

The more ambitious way would be to enable tests on all platforms,
upload to experimental, and then set FAIL_CHECK for all architectures
that pass.

diff --git a/debian/rules b/debian/rules
index cf50336..0885cd6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,11 +7,12 @@ DEB_BUILDUSER=$(shell dpkg-parsechangelog -SMaintainer)
 ifneq (,$(findstring $(DEB_HOST_ARCH_OS), linux))
   ifneq (,$(findstring $(DEB_HOST_ARCH), i386 amd64))
     WITH_VBOX         = --with-vbox
-    MAKE_CHECK        = 1
+    FAIL_CHECK        = 1
   else
     WITH_VBOX         = --without-vbox
   endif
   ifneq (,$(findstring $(DEB_HOST_ARCH), i386 amd64 armhf arm64))
+    MAKE_CHECK        = 1
     WITH_XEN          = --with-xen
     WITH_LIBXL        = --with-libxl
     XEN_ENABLED       = 1
@@ -154,7 +155,7 @@ override_dh_auto_test:
 	if ! dh_auto_test -O--builddirectory=$(DEB_BUILDDIR); then \
 	    cat ./debian/build/gnulib/tests/test-suite.log \
 	        ./debian/build/tests/test-suite.log; \
-	    exit 1; \
+	    [ -n "$(FAIL_CHECK)" ] || exit 1; \
 	fi
 
 override_dh_install-arch:

-- System Information:
Debian Release: 8.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-0.bpo.1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)