[Pkg-libvirt-maintainers] Bug#862697: virt-manager: Fails to rename UEFI VMs

[Lee Garrett]

Package: virt-manager
Version: 1:1.4.0-5
Severity: normal
Tags: patch

Hi libvirt maintainers,

Running virt-manager in stretch, I can't rename VMs that where installed via
UEFI:

---8<------8<------8<------8<------8<------8<------8<------8<------8<---

[Mon, 15 May 2017 23:15:17 virt-manager 4377] DEBUG (libvirtobject:123) Changing <class 'virtManager.domain.vmmDomain'> name from debian9_template to debian9template
[Mon, 15 May 2017 23:15:17 virt-manager 4377] ERROR (domain:1423) libvirt undefineFlags failed, falling back to old style
Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/domain.py", line 1421, in delete
    self._backend.undefineFlags(flags)
  File "/usr/lib/python2.7/dist-packages/libvirt.py", line 2606, in undefineFlags
    if ret == -1: raise libvirtError ('virDomainUndefineFlags() failed', dom=self)
libvirtError: Requested operation is not valid: cannot delete inactive domain with nvram
[Mon, 15 May 2017 23:15:17 virt-manager 4377] DEBUG (error:99) error dialog message:
summary=Error apply changes: Requested operation is not valid: cannot delete inactive domain with nvram
details=Error apply changes: Requested operation is not valid: cannot delete inactive domain with nvram

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/details.py", line 1841, in config_apply
    ret = self.config_overview_apply()
  File "/usr/share/virt-manager/virtManager/details.py", line 1933, in config_overview_apply
    self.vm.define_name(self.widget("overview-name").get_text())
  File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 130, in define_name
    self.conn.rename_object(self, origxml, newxml, oldconnkey)
  File "/usr/share/virt-manager/virtManager/connection.py", line 698, in rename_object
    obj.delete(force=False)
  File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 83, in newfn
    ret = fn(self, *args, **kwargs)
  File "/usr/share/virt-manager/virtManager/domain.py", line 1425, in delete
    self._backend.undefine()
  File "/usr/lib/python2.7/dist-packages/libvirt.py", line 2581, in undefine
    if ret == -1: raise libvirtError ('virDomainUndefine() failed', dom=self)
libvirtError: Requested operation is not valid: cannot delete inactive domain with nvram

---8<------8<------8<------8<------8<------8<------8<------8<------8<---

The bug seems to be known upstream and is fixed with this commit:

> commit 92c230d1113403b506e115416dff1218479b7116
> Author: Pavel Hrdina <phrdina at redhat.com>
> Date:   Mon Mar 6 09:43:10 2017 +0100
> 
>     domain: add support to rename domain with nvram vars file

Could you cherrypick this patch? Thanks in advance!

Regards,
Lee

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (101, 'unstable'), (1, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages virt-manager depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.26.0-2+b1
ii  gconf2                                       3.2.6-4+b1
ii  gir1.2-gtk-3.0                               3.22.11-1
ii  gir1.2-gtk-vnc-2.0                           0.6.0-2
ii  gir1.2-libosinfo-1.0                         1.0.0-2
ii  gir1.2-libvirt-glib-1.0                      1.0.0-1
ii  gir1.2-vte-2.91                              0.46.1-1
ii  librsvg2-common                              2.40.16-1+b1
ii  python-dbus                                  1.2.4-1+b1
ii  python-gi                                    3.22.0-2
ii  python-gi-cairo                              3.22.0-2
ii  python-libvirt                               3.0.0-2
ii  python-requests                              2.12.4-1
pn  python2.7:any                                <none>
pn  python:any                                   <none>
ii  virtinst                                     1:1.4.0-5

Versions of packages virt-manager recommends:
ii  gir1.2-spice-client-gtk-3.0  0.33-3.3
ii  gnome-icon-theme             3.12.0-2
ii  libvirt-daemon-system        3.0.0-4

Versions of packages virt-manager suggests:
ii  gir1.2-secret-1  0.18.5-3.1
ii  gnome-keyring    3.20.0-3
ii  python-guestfs   1:1.34.6-2
ii  ssh-askpass      1:1.2.4.1-9+b2
pn  virt-viewer      <none>

-- no debconf information