[Pkg-libvirt-maintainers] Bug#875766: Don't fail if bridge port already exists

[martin f krafft]

Package: libvirt-daemon
Version: 3.0.0-4
Severity: wishlist

virt-install failed on me with this error:

  [Thu, 14 Sep 2017 13:10:14 virt-install 16798] DEBUG (cli:307)   File "/usr/share/virt-manager/virt-install", line 996, in <module>
      sys.exit(main())
    File "/usr/share/virt-manager/virt-install", line 990, in main
      start_install(guest, options)
    File "/usr/share/virt-manager/virt-install", line 716, in start_install
      fail(e, do_exit=False)
    File "/usr/share/virt-manager/virtinst/cli.py", line 307, in fail
      logging.debug("".join(traceback.format_stack()))

  [Thu, 14 Sep 2017 13:10:14 virt-install 16798] ERROR (cli:308) Unable to add bridge wan port vnet0: Device or resource busy
  [Thu, 14 Sep 2017 13:10:14 virt-install 16798] DEBUG (cli:310) 
  Traceback (most recent call last):
    File "/usr/share/virt-manager/virt-install", line 695, in start_install
      transient=options.transient)
    File "/usr/share/virt-manager/virtinst/guest.py", line 461, in start_install
      doboot, transient)
    File "/usr/share/virt-manager/virtinst/guest.py", line 396, in _create_guest
      self.domain = self.conn.createXML(install_xml or final_xml, 0)
    File "/usr/lib/python2.7/dist-packages/libvirt.py", line 3523, in createXML
      if ret is None:raise libvirtError('virDomainCreateXML() failed', conn=self)
  libvirtError: Unable to add bridge wan port vnet0: Device or resource busy

I tracked this down to the fact that systemd (presumably) had
already added vnet0 to the bridge, thanks to the following line in
/etc/network/interfaces:

  iface wan inet static
    […]
    bridge_ports enp3s0f0 regex vnet[0-9]+

The reason I want this is because if I ever take an interface down
and bring it back up, I want the existing vnet interfaces to be
automatically added.

So I suggest that the libvirt code adding the bridge should not fail
if the very port it's trying to add already exists in the bridge. Or
maybe it'd be better made configurable…

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_NZ, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libvirt-daemon depends on:
ii  libapparmor1        2.11.0-10
ii  libaudit1           1:2.7.7-1+b2
ii  libavahi-client3    0.6.32-2
ii  libavahi-common3    0.6.32-2
ii  libblkid1           2.29.2-4
ii  libc6               2.24-14
ii  libcap-ng0          0.7.7-3+b1
ii  libcurl3-gnutls     7.55.0-1
ii  libdbus-1-3         1.11.16+really1.10.22-1
ii  libdevmapper1.02.1  2:1.02.142-1
ii  libfuse2            2.9.7-1
ii  libgnutls30         3.5.14-2
pn  libnetcf1           <none>
ii  libnl-3-200         3.2.27-2
ii  libnl-route-3-200   3.2.27-2
ii  libnuma1            2.0.11-2.1
ii  libparted2          3.2-17
ii  libpcap0.8          1.8.1-3
ii  libpciaccess0       0.13.4-1+b2
pn  librados2           <none>
pn  librbd1             <none>
ii  libsasl2-2          2.1.27~101-g0780600+dfsg-3
ii  libselinux1         2.6-3+b2
ii  libssh2-1           1.8.0-1
ii  libudev1            234-2
ii  libvirt0            3.6.0-1
ii  libxen-4.8          4.8.1-1+deb9u1
ii  libxenstore3.0      4.8.1-1+deb9u1
ii  libxml2             2.9.4+dfsg1-3
ii  libyajl2            2.1.0-2+b3

Versions of packages libvirt-daemon recommends:
ii  libxml2-utils   2.9.4+dfsg1-3
ii  netcat-openbsd  1.178-3
ii  qemu            1:2.8+dfsg-7
ii  qemu-kvm        1:2.8+dfsg-7

Versions of packages libvirt-daemon suggests:
pn  libvirt-daemon-system  <none>
pn  numad                  <none>

-- 
 .''`.   martin f. krafft <madduck at d.o> @martinkrafft
: :'  :  proud Debian developer
`. `'`   http://people.debian.org/~madduck
  `-  Debian - when you have better things to do than fixing systems
-------------- next part --------------
A non-text attachment was scrubbed...
Name: digital_signature_gpg.asc
Type: application/pgp-signature
Size: 1118 bytes
Desc: Digital GPG signature (see http://martin-krafft.net/gpg/sig-policy/999bbcc4/current)
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20170914/bbdc1f6a/attachment-0001.sig>