[Pkg-libvirt-maintainers] Bug#895898: Bug#895898: virt-install adds "method=" boot parameter, which is copied to Grub config

[Raphaël Halimi]

Le 18/04/2018 à 08:45, Guido Günther a écrit :
> Check _kernelFetchHelper where it adds the method arg. I doubt this is
> needed at all on Debian but rather a leftover of other distros.

Hi again,

Thanks to your hint, and after a bit of fiddling (remember I don't know
python), I came up with the simple patch attached.

It implements the second solution (remove "method=" altogether if the
distribution is detected as "Debian").

It should be tested with other guest distributions though.

Also, I think you could also check if self.name is equal to "Ubuntu",
but I'm not sure if ubuntu-installer needs (or support) "method=" or not.

Do you want me to create and forward a bug upstream ?

Regards,

-- 
Raphaël Halimi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: urlfetcher.diff
Type: text/x-patch
Size: 551 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20180418/1ae7c9e6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20180418/1ae7c9e6/attachment.sig>