[Pkg-libvirt-maintainers] Bug#893330: Syntax error in virtlock-admin.socket can break upgrades
Ben Hutchings
ben at decadent.org.uk
Sun Mar 18 03:07:26 UTC 2018
Package: libvirt-daemon-system
Version: 4.1.0-1
Severity: important
Tags: patch
An upgrade to this version failed:
Setting up libvirt-daemon-system (4.1.0-1) ...
Installing new version of config file /etc/init.d/libvirt-guests ...
Installing new version of config file /etc/libvirt/libvirtd.conf ...
Installing new version of config file /etc/libvirt/virtlockd.conf ...
Created symlink /etc/systemd/system/sockets.target.wants/virtlockd-admin.socket → /lib/systemd/system/virtlockd-admin.socket.
Created symlink /etc/systemd/system/sockets.target.wants/virtlogd-admin.socket → /lib/systemd/system/virtlogd-admin.socket.
virtlockd.service is a disabled or a static unit, not starting it.
A dependency job for virtlogd.service failed. See 'journalctl -xe' for details.
invoke-rc.d: initscript virtlogd, action "start" failed.
● virtlogd.service - Virtual machine log manager
Loaded: loaded (/lib/systemd/system/virtlogd.service; indirect; vendor preset: enabled)
Active: active (running) since Fri 2018-03-09 02:30:19 GMT; 1 weeks 2 days ago
Docs: man:virtlogd(8)
https://libvirt.org
Main PID: 15811 (virtlogd)
Tasks: 2 (limit: 4915)
Memory: 3.1M
CGroup: /system.slice/virtlogd.service
└─15811 /usr/sbin/virtlogd
Mar 18 02:32:45 deadeye systemd[1]: Reloading Virtual machine log manager.
Mar 18 02:32:45 deadeye systemd[1]: Reloaded Virtual machine log manager.
Mar 18 02:32:48 deadeye systemd[1]: Dependency failed for Virtual machine log manager.
Mar 18 02:32:48 deadeye systemd[1]: virtlogd.service: Job virtlogd.service/start failed with result 'dependency'.
Warning: Journal has been rotated since unit was started. Log output is incomplete or unavailable.
dpkg: error processing package libvirt-daemon-system (--configure):
installed libvirt-daemon-system package post-installation script subprocess returned error exit status 1
virtlockd.service depends on virtlockd-admin.socket, and
virtlock-admin.socket cannot be started:
Mar 18 02:51:12 deadeye systemd[1]: virtlockd-admin.socket: Socket service virtlockd-admin.service not loaded, refusing.
Patch attached. (I haven't been able to rebuild the package with this
change due to dependency problems in unstable, but making the same
change to the installed file /lib/systemd/system/virtlockd-admin.socket
allowed me to start it and complete installation.)
Ben.
-- System Information:
Debian Release: buster/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages libvirt-daemon-system depends on:
ii adduser 3.117
ii debconf [debconf-2.0] 1.5.66
ii gettext-base 0.19.8.1-4
ii iptables 1.6.2-1
ii libacl1 2.2.52-3+b1
ii libapparmor1 2.12-3
ii libaudit1 1:2.8.2-1
ii libblkid1 2.31.1-0.5
ii libc6 2.27-2
ii libcap-ng0 0.7.7-3.1+b1
ii libdbus-1-3 1.12.6-2
ii libdevmapper1.02.1 2:1.02.145-4.1
ii libgnutls30 3.5.18-1
ii libnl-3-200 3.2.27-2
ii libnl-route-3-200 3.2.27-2
ii libnuma1 2.0.11-2.1
ii libselinux1 2.7-2+b1
ii libvirt-clients 4.1.0-1
ii libvirt-daemon 4.1.0-1
ii libvirt0 4.1.0-1
ii libxml2 2.9.4+dfsg1-6.1
ii libyajl2 2.1.0-2+b3
ii logrotate 3.11.0-0.1
ii lsb-base 9.20170808
ii policykit-1 0.105-18
Versions of packages libvirt-daemon-system recommends:
ii bridge-utils 1.5-15
ii dmidecode 3.1-1
ii dnsmasq-base 2.78-3
ii ebtables 2.0.10.4-3.5+b1
ii iproute2 4.15.0-3
ii parted 3.2-20
Versions of packages libvirt-daemon-system suggests:
ii apparmor 2.12-3
pn auditd <none>
ii nfs-common 1:1.3.4-2.2
ii pm-utils 1.4.1-17
pn radvd <none>
ii systemd 238-2
ii systemtap 3.1-3
pn zfsutils <none>
-- Configuration Files:
/etc/libvirt/nwfilter/allow-arp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-arp.xml'
/etc/libvirt/nwfilter/allow-dhcp-server.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-dhcp-server.xml'
/etc/libvirt/nwfilter/allow-dhcp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-dhcp.xml'
/etc/libvirt/nwfilter/allow-incoming-ipv4.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-incoming-ipv4.xml'
/etc/libvirt/nwfilter/allow-ipv4.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-ipv4.xml'
/etc/libvirt/nwfilter/clean-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/clean-traffic.xml'
/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml'
/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml'
/etc/libvirt/nwfilter/no-arp-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-spoofing.xml'
/etc/libvirt/nwfilter/no-ip-multicast.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-ip-multicast.xml'
/etc/libvirt/nwfilter/no-ip-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-ip-spoofing.xml'
/etc/libvirt/nwfilter/no-mac-broadcast.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-mac-broadcast.xml'
/etc/libvirt/nwfilter/no-mac-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-mac-spoofing.xml'
/etc/libvirt/nwfilter/no-other-l2-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-other-l2-traffic.xml'
/etc/libvirt/nwfilter/no-other-rarp-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-other-rarp-traffic.xml'
/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml'
/etc/libvirt/nwfilter/qemu-announce-self.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/qemu-announce-self.xml'
/etc/libvirt/qemu.conf [Errno 13] Permission denied: '/etc/libvirt/qemu.conf'
/etc/libvirt/qemu/networks/default.xml [Errno 13] Permission denied: '/etc/libvirt/qemu/networks/default.xml'
-- debconf information:
libvirt-daemon-system/id_warning: true
-- debsums errors found:
debsums: changed file /lib/systemd/system/virtlockd-admin.socket (from libvirt-daemon-system package)
-------------- next part --------------
From: Ben Hutchings <ben at decadent.org.uk>
Date: Sun, 18 Mar 2018 02:55:09 +0000
Subject: virtlock-admin.socket: Fix syntax error
The service name for a systemd socket is specified using the field
"Service", not "Server".
---
--- a/src/locking/virtlockd-admin.socket.in
+++ b/src/locking/virtlockd-admin.socket.in
@@ -4,7 +4,7 @@ Before=libvirtd.service
[Socket]
ListenStream=@localstatedir@/run/libvirt/virtlockd-admin-sock
-Server=virtlockd.service
+Service=virtlockd.service
[Install]
WantedBy=sockets.target
More information about the Pkg-libvirt-maintainers
mailing list