[Pkg-libvirt-maintainers] Bug#893484: -admin sockets not started on installation.

Laurent Bigonville bigon at debian.org
Mon Mar 19 10:15:24 UTC 2018


Package: libvirt-daemon-system
Version: 4.1.0-2
Severity: important
Tags: patch

Hi,

On installation, the admin socket units are not started.

Please find a patch attached that fixes this.

The patch also make the package uses dh-systemd sequence instead abusing
the dh_installinit one.

Kind regards,

Laurent Bigonville

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: SELinux: enabled - Mode: Permissive - Policy name: refpolicy

Versions of packages libvirt-daemon-system depends on:
ii  adduser                3.117
ii  debconf [debconf-2.0]  1.5.66
ii  firewalld              0.4.4.6-1
ii  gettext-base           0.19.8.1-4
ii  iptables               1.6.2-1
ii  libacl1                2.2.52-3+b1
ii  libapparmor1           2.12-4
ii  libaudit1              1:2.8.2-1
ii  libblkid1              2.31.1-0.5
ii  libc6                  2.27-2
ii  libcap-ng0             0.7.7-3.1+b1
ii  libdbus-1-3            1.12.6-2
ii  libdevmapper1.02.1     2:1.02.145-4.1
ii  libgnutls30            3.5.18-1
ii  libnl-3-200            3.2.27-2
ii  libnl-route-3-200      3.2.27-2
ii  libnuma1               2.0.11-2.1
ii  libselinux1            2.7-2+b1
ii  libvirt-clients        4.1.0-2
ii  libvirt-daemon         4.1.0-2
ii  libvirt0               4.1.0-2
ii  libxml2                2.9.4+dfsg1-6.1
ii  libyajl2               2.1.0-2+b3
ii  logrotate              3.11.0-0.1
ii  lsb-base               9.20170808
ii  policykit-1            0.105-18

Versions of packages libvirt-daemon-system recommends:
ii  bridge-utils  1.5-15
ii  dmidecode     3.1-1
ii  dnsmasq-base  2.78-3
ii  ebtables      2.0.10.4-3.5+b1
ii  iproute2      4.15.0-3
ii  parted        3.2-20

Versions of packages libvirt-daemon-system suggests:
ii  apparmor    2.12-4
ii  auditd      1:2.8.2-1
pn  nfs-common  <none>
ii  pm-utils    1.4.1-17
pn  radvd       <none>
ii  systemd     238-2
pn  systemtap   <none>
pn  zfsutils    <none>

-- Configuration Files:
/etc/libvirt/nwfilter/allow-arp.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/allow-arp.xml'
/etc/libvirt/nwfilter/allow-dhcp-server.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/allow-dhcp-server.xml'
/etc/libvirt/nwfilter/allow-dhcp.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/allow-dhcp.xml'
/etc/libvirt/nwfilter/allow-incoming-ipv4.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/allow-incoming-ipv4.xml'
/etc/libvirt/nwfilter/allow-ipv4.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/allow-ipv4.xml'
/etc/libvirt/nwfilter/clean-traffic.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/clean-traffic.xml'
/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml'
/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml'
/etc/libvirt/nwfilter/no-arp-spoofing.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-arp-spoofing.xml'
/etc/libvirt/nwfilter/no-ip-multicast.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-ip-multicast.xml'
/etc/libvirt/nwfilter/no-ip-spoofing.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-ip-spoofing.xml'
/etc/libvirt/nwfilter/no-mac-broadcast.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-mac-broadcast.xml'
/etc/libvirt/nwfilter/no-mac-spoofing.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-mac-spoofing.xml'
/etc/libvirt/nwfilter/no-other-l2-traffic.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-other-l2-traffic.xml'
/etc/libvirt/nwfilter/no-other-rarp-traffic.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/no-other-rarp-traffic.xml'
/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml'
/etc/libvirt/nwfilter/qemu-announce-self.xml [Errno 13] Permission non accordée: '/etc/libvirt/nwfilter/qemu-announce-self.xml'
/etc/libvirt/qemu.conf [Errno 13] Permission non accordée: '/etc/libvirt/qemu.conf'
/etc/libvirt/qemu/networks/default.xml [Errno 13] Permission non accordée: '/etc/libvirt/qemu/networks/default.xml'

-- debconf information excluded
-------------- next part --------------
diff -Nru libvirt-4.1.0/debian/rules libvirt-4.1.0/debian/rules
--- libvirt-4.1.0/debian/rules	2018-03-18 10:51:37.000000000 +0100
+++ libvirt-4.1.0/debian/rules	2018-03-19 11:05:48.000000000 +0100
@@ -138,8 +138,10 @@
 LIBVIRT_SYSTEM_SERVICES = \
 	libvirt-guests.service \
 	virtlogd.socket \
+	virtlogd-admin.socket \
 	virtlogd.service \
 	virtlockd.socket \
+	virtlockd-admin.socket \
 	virtlockd.service \
 	$(NULL)
 
@@ -149,7 +151,7 @@
 EXAMPLES_DIR = $(CURDIR)/debian/libvirt-doc/usr/share/doc/libvirt-doc/examples/
 
 %:
-	dh $@ --builddirectory=$(DEB_BUILDDIR) --parallel --with autoreconf
+	dh $@ --builddirectory=$(DEB_BUILDDIR) --parallel --with autoreconf --with systemd
 
 override_dh_auto_configure:
 	dh_auto_configure -- $(DEB_CONFIGURE_EXTRA_ARGS)
@@ -218,11 +220,12 @@
 
 
 override_dh_installinit:
-	dh_systemd_enable
 	dh_installinit -p libvirt-daemon-system --name=virtlogd --no-restart-on-upgrade
 	dh_installinit -p libvirt-daemon-system --name=libvirtd --restart-after-upgrade -- defaults 28 72
 	dh_installinit -p libvirt-daemon-system --name=libvirt-guests --no-restart-on-upgrade -- defaults 29 71
-	dh_systemd_start -p libvirt-daemon-system --restart-after-upgrade libvirtd.service
+
+override_dh_systemd_start:
+	dh_systemd_start -p libvirt-daemon-system --restart-after-upgrade libvirtd.service 
 	dh_systemd_start -p libvirt-daemon-system --no-restart-on-upgrade $(LIBVIRT_SYSTEM_SERVICES)
 
 override_dh_installdocs:


More information about the Pkg-libvirt-maintainers mailing list