[Pkg-libvirt-maintainers] Bug#915030: virt-viewer: leaves alternatives after purge: /usr/bin/spice-xpi-client

[Andreas Beckmann]

Package: virt-viewer
Version: 7.0-1
Severity: important
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-removal-and-or-configuration-purging

The leftover files are actually alternatives that were installed by the
package but have not been properly removed.

While there is ongoing discussion how to remove alternatives correctly
(see https://bugs.debian.org/71621 for details) the following strategy
should work for regular cases:
* 'postinst configure' always installs the alternative
* 'prerm remove' removes the alternative
* 'postrm remove' and 'postrm disappear' remove the alternative
In all other cases a maintainer script is invoked (e.g. upgrade,
deconfigure) the alternatives are not modified to preserve user
configuration.
Removing the alternative in 'prerm remove' avoids having a dangling link
once the actual file gets removed, but 'prerm remove' is not called in
all cases (e.g. unpacked but not configured packages or disappearing
packages) so the postrm must remove the alternative again
(update-alternatives gracefully handles removal of non-existing
alternatives).

Note that the arguments for adding and removing alternatives differ, for
removal it's 'update-alternatives --remove <name> <path>'.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

>From the attached log (scroll to the bottom...):

1m42.4s INFO: Warning: Package purging left files on system:
  /etc/alternatives/spice-xpi-client -> /usr/bin/spice-xpi-client-remote-viewer	 not owned
  /usr/bin/spice-xpi-client -> /etc/alternatives/spice-xpi-client	 not owned

This was observed after an upgrade from stretch to buster.
If the alternatives are no longer used in the current version,
the obsolete ones should be cleaned up in the postinst.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virt-viewer_7.0-1.log.gz
Type: application/gzip
Size: 78995 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20181129/98383534/attachment-0001.gz>