[Pkg-libvirt-maintainers] Bug#905772: Bug#905772: libvirtd upgrade broken stretch->buster

[Niels Thykier]

On Mon, 15 Apr 2019 22:27:57 +0200 Guido =?iso-8859-1?Q?G=FCnther?=
<agx at sigxcpu.org> wrote:
> Hi,
> On Mon, Apr 15, 2019 at 10:18:18PM +0200, Michael Biebl wrote:
> > Hi Sam
> > 
> > Am 15.04.2019 um 20:38 schrieb Sam Hartman:
> > > control: severity -1 serious
> > > 
> > > justification: libvirtd upgrades from stretch to buster break causing
> > > apt to fail and requiring the admin to get the systemd units into a
> > > consistent state before things can continue
> > > 
> > > 
> > > Unfortunately based on discussion so far this is a complex bug to fix.
> > > Ubuntu's solution is to drop the sysv scripts and to drop  Also= lines
> > > in some of the units.
> > > 
> > > The systemd maintainers proposed that dropping Also as well as some
> > > changes to move toward dh_systemd_start being used even when sysvinit
> > > scripts are present would help this situation.  Unfortunately it at
> > > least doesn't look like those changes are in debhelper for buster.
> > > Systemd folks, do you have any suggestions  on how to approach this for
> > > buster?
> > 
> > Using debhelper compat level 12, you are able to completely decouple
> > dh_installinit and dh_installsystemd which would give you the ability to
> > implement what you want afaics.
> 
> So let's move libvirt from 8 to 12 for stretch? I'm all for it but it'll
> be a couple of days until I can set time aside for this.
> cheers,
>  -- Guido
> 
> [...]
Hi,

I think we should keep libvirt at compat 8 in general for now and then
leave a full bump to compat 12 for bullseye.  The reason here being that
the compat changes documented in debhelper(7) amounts to 3-4 screens
worth of changes across all of debhelper's tools.

Instead, we can do a mixed compat setup, where the package remains at
compat 8 in general but we force selected tools to run in compat 12.  I
have made a PoC of that in
https://salsa.debian.org/libvirt-team/libvirt/merge_requests/21/diffs

Note that change set is only meant as inspiration; I have not tried to
understand the problem nor the solution fully (nor have I tested that it
actually still builds).

Thanks,
~Niels