[Pkg-libvirt-maintainers] Bug#905613: jansson dependency needs to be added explcitly

[Guido Günther]

Version: libvirt/6.0.0-1

Hi,
marking as fixed too.
 -- Guido

On Tue, Aug 07, 2018 at 08:13:51AM +0200, Christian Ehrhardt wrote:
> Package: libvirt
> Version: 4.6.0-1
> Severity: normal
> 
> Debian has taken:
>   * [d53b4b1] Use jansson instead of yajl.  The later is no longer supported
>     upstream
> Which is following upsteram fine.
> 
> But Upstream: ce3c6ef6 util: avoid symbol clash between json libraries
>   Had:
>   --- a/libvirt.spec.in
>   +++ b/libvirt.spec.in
> @@ -898,6 +898,8 @@ Requires: ncurses
>  Requires: gettext
>  # Needed by virt-pki-validate script.
>  Requires: gnutls-utils
> +# We dlopen(libjansson.so.4), so need an explicit dep
> +Requires: jansson
>  %if %{with_bash_completion}
>  Requires: %{name}-bash-completion = %{version}-%{release}
>  %endif
> 
> This is special since this is intentionally "black dlopen magic" to avoid
> the issues around the symbol collision that was discussed on -rc2.
> 
> Build log [1] and a debian-sid container show it as missing.
> So you could end up with a dlopen to a nonexisting file.
> This will not be found by shlibs and co.
> 
> I tested on sid if there is a hidden
> 
> Fix looks like a normal dependency add.
> I'm slightly unsure where exactly, but the old libyajl2 dependencies were
> on libvirt0, libvirt-daemon and libnss-libvirt which is I think the set we
> should go for.
> 
> [1]:
> https://buildd.debian.org/status/fetch.php?pkg=libvirt&arch=amd64&ver=4.6.0-1&stamp=1533592540&raw=0
> 
> -- 
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd