[Pkg-libvirt-maintainers] Bug#944890: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/foo → /run/libvirt/foo; please update the unit file accordingly.

[Michael Biebl]

On Sun, 17 Nov 2019 12:28:38 +0100 Laurent Bigonville <bigon at debian.org>
wrote:
> Package: libvirt-daemon-system
> Version: 5.6.0-2
> Severity: minor
> 
> Hello,
> 
> During boot, systemd complains that the .service and .socket files are
> pointing to /var/run instead of /run:
> 
> systemd[1]: /lib/systemd/system/virtlockd.socket:6: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/virtlockd-sock → /run/libvirt/virtlockd-sock; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/virtlockd-admin.socket:8: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/virtlockd-admin-sock → /run/libvirt/virtlockd-admin-sock; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/libvirtd-admin.socket:8: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/libvirt-admin-sock → /run/libvirt/libvirt-admin-sock; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/libvirtd-ro.socket:8: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/libvirt-sock-ro → /run/libvirt/libvirt-sock-ro; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/libvirtd.socket:6: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/libvirt-sock → /run/libvirt/libvirt-sock; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/virtlogd.socket:6: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/virtlogd-sock → /run/libvirt/virtlogd-sock; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/virtlogd-admin.socket:8: ListenStream= references a path below legacy directory /var/run/, updating /var/run/libvirt/virtlogd-admin-sock → /run/libvirt/virtlogd-admin-sock; please update the unit file accordingly.
> 
> 
> /run is supported in debian for quite some times, that can be used I
> guess.


I've updated the code to use runstatedir.
What remains is to use --runstatedir=/run in debian/rules.

I then noticed that upstream made similar changes as well. So once we
get a newer release of libvirt, this should be supported ootb.


But since I already did the work, I'm attaching the patches, just in
case you decide to keep 5.6 in unstable for a while longer.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Search-and-replace-to-use-runstatedir-instead-locals.patch
Type: text/x-patch
Size: 25582 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20200115/704dcb60/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-Makefiles-to-use-runstatedir.patch
Type: text/x-patch
Size: 9818 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20200115/704dcb60/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-remaining-parts-of-the-source-code-to-use-RUNSTA.patch
Type: text/x-patch
Size: 7008 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20200115/704dcb60/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Update-virPidFileConstructPath-to-use-runstatedir.patch
Type: text/x-patch
Size: 2570 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20200115/704dcb60/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20200115/704dcb60/attachment-0001.sig>