[Pkg-libvirt-maintainers] Bug#954291: Bug#954291: libvirt-daemon-system-sysv: upgrading kills VMs

[Guido Günther]

Hi,
On Thu, Mar 19, 2020 at 08:18:04PM +0100, Thorsten Glaser wrote:
> Package: libvirt-daemon-system-sysv
> Version: 6.0.0-3
> Severity: critical
> Justification: causes serious data loss
> 
> Just a regular dist-upgrade doing this:
> 
> 
> Unpacking libvirt-daemon-system-sysv (6.0.0-3) over (6.0.0-1) ...
> […]
> Setting up libvirt-daemon-system-sysv (6.0.0-3) ...
> Restarting libvirt logging daemon: /usr/sbin/virtlogd.
> Restarting libvirt management daemon: /usr/sbin/libvirtd.
> 
> Running guests on default URI: MirBSD
> Shutting down guests on default URI...
> Starting shutdown on guest: MirBSD
> Waiting for guest MirBSD to shut down, 300 seconds left

Looks like a regression from the sysv split since this worked before,
could you check if this fixes it:

   https://salsa.debian.org/libvirt-team/libvirt/-/commit/d7df842ce8649d88c9b242b9f4866c43016554b7

Cheers,
 -- Guido

> […]
> 
> 
> It’s inacceptable for a regular package upgrade to shut down
> any running VMs without warning. The VMs may be necessary, or
> might need to be shut down manually (qemu’s guest agent still
> doesn’t work without native virtio in the guest even though a
> serial (IIRC) control channel is specified), and killing such
> a VM will introduce guest filesystem corruption.
> 
> At least issue a debconf thing like glibc does when you want
> to upgrade from 2.29 to 2.30, which offers me some time to
> shut down the VM manually or abort the upgrade.
> 
> 
> To add insult to injury, it didn’t even shut it down cleanly:
> 
> tglase at tglase:~ $ virsh -c qemu:///system list
>  Id   Name     State
> ----------------------------
>  3    MirBSD   in shutdown
> 
> 
> “virsh destroy 3” to the “rescue”…
> 
> 
> -- System Information:
> Debian Release: bullseye/sid
>   APT prefers unreleased
>   APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable'), (100, 'experimental')
> Architecture: x32 (x86_64)
> Foreign Architectures: i386, amd64
> 
> Kernel: Linux 5.4.0-4-amd64 (SMP w/4 CPU cores)
> Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
> Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/lksh
> Init: sysvinit (via /sbin/init)
> 
> Versions of packages libvirt-daemon-system-sysv depends on:
> ii  init-system-helpers  1.57
> ii  lsb-base             11.1.0
> 
> libvirt-daemon-system-sysv recommends no packages.
> 
> libvirt-daemon-system-sysv suggests no packages.
> 
> -- no debconf information
> _______________________________________________
> Pkg-libvirt-maintainers mailing list
> Pkg-libvirt-maintainers at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-libvirt-maintainers