[Pkg-libvirt-maintainers] Bug#991776: virt-viewer: Cannot connect to display with IPv6 literal as host

[Kevin Otte]

Package: virt-viewer
Version: 7.0-2
Severity: important

Dear Maintainer,

When attempting to connect to a remote display, and socat is present on the
remote system, I am unable to connect:

-
kjotte at mystic:~$ virt-viewer -vv -c qemu+ssh://agamemnon.home.nivex.net/system icarus
Opening connection to libvirt with URI qemu+ssh://agamemnon.home.nivex.net/system
Guest icarus is running, determining display
Guest icarus has a spice display
Opening indirect TCP connection to display at ::1:5901
Setting up SSH tunnel via agamemnon.home.nivex.net
2021/08/01 11:22:00 socat[54337] E TCP: wrong number of parameters (4 instead of 2)

(virt-viewer:159986): GSpice-WARNING **: 11:22:00.585: incomplete link header (0/16)
-

This is likely because the IPv6 literal "::1" is being passed directly to socat
without being wrapped in brackets (eg: [::1]).

The problem does not occur if socat is not present on the remote system as it
falls back to netcat.


-- System Information:
Debian Release: 11.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-8-amd64 (SMP w/4 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages virt-viewer depends on:
ii  libatk1.0-0                 2.36.0-2
ii  libc6                       2.31-13
ii  libcairo-gobject2           1.16.0-5
ii  libcairo2                   1.16.0-5
ii  libgdk-pixbuf2.0-0          2.40.2-2
ii  libglib2.0-0                2.66.8-1
ii  libgovirt2                  0.3.7-2
ii  libgtk-3-0                  3.24.24-4
ii  libgtk-vnc-2.0-0            1.0.0-1
ii  libgvnc-1.0-0               1.0.0-1
ii  libpango-1.0-0              1.46.2-3
ii  libpangocairo-1.0-0         1.46.2-3
ii  librest-0.7-0               0.8.1-1.1
ii  libsoup2.4-1                2.72.0-2
ii  libspice-client-glib-2.0-8  0.39-1
ii  libspice-client-gtk-3.0-5   0.39-1
ii  libvirt-glib-1.0-0          3.0.0-1
ii  libvirt0                    7.0.0-3
ii  libxml2                     2.9.10+dfsg-6.7

virt-viewer recommends no packages.

Versions of packages virt-viewer suggests:
ii  netcat-openbsd [netcat]      1.217-3
ii  netcat-traditional [netcat]  1.10-46

-- no debconf information