[Pkg-libvirt-maintainers] Bug#973188: virt-top: FTBFS: Error: Cannot find file camlheader_pic

[Kentaro Hayashi]

> > File "opt_csv.ml", line 36, characters 1-13:
> > 36 | 	Csv.save_out chan [row];
> >       ^^^^^^^^^^^^
> > Alert deprecated: Csv.save_out
> > Save Csv.t to a channel
> > ocamlfind ocamlc -package unix,extlib,curses,str,libvirt -package gettext-stub -package xml-light -package csv -g -warn-error CDEFLMPSUVYZX-3 -ccopt '-g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security' -linkpkg -runtime-variant _pic -cclib '-Wl,-z,relro' \
> >   -o virt-top version.cmo opt_gettext.cmo utils.cmo types.cmo collect.cmo screen.cmo redraw.cmo csv_output.cmo stream_output.cmo top.cmo opt_xml.cmo opt_csv.cmo main.cmo
> > File "_none_", line 1:
> > Error: Cannot find file camlheader_pic
> > make[2]: *** [Makefile:87: virt-top] Error 2
> 
> The full build log is available from:
>    http://qa-logs.debian.net/2020/10/27/virt-top_1.0.9-1_unstable.log
> 
> A list of current common problems and possible solutions is available at


Hi,

It seems that this is caused by missing /usr/lib/ocaml/camlheader_pic.

$ find /usr/lib -name 'camlheader*'
/usr/lib/ocaml/camlheader_ur
/usr/lib/ocaml/camlheader
/usr/lib/ocaml/camlheaderd
/usr/lib/ocaml/camlheaderi

The following patch may solve above compile error because
-runtime-variant explicitly to _pic.

$ cat virt-top-1.0.9/debian/patches/fix-missing-camlheader_pic.patch 
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -65,7 +65,7 @@
 XOBJS		:= $(OBJS:.cmo=.cmx)
 
 OCAMLCFLAGS	:= -g -warn-error CDEFLMPSUVYZX-3 -ccopt '@CFLAGS@'
-OCAMLCLIBS	:= -linkpkg -runtime-variant _pic -cclib '@LDFLAGS@'
+OCAMLCLIBS	:= -linkpkg -cclib '@LDFLAGS@'
 
 OCAMLOPTPACKAGES := $(OCAMLCPACKAGES)
 OCAMLOPTFLAGS	:= $(OCAMLCFLAGS)

Additionally, it may requires the following Depends.

% diff -u virt-top-1.0.9.orig/debian/control virt-top-1.0.9/debian/control
--- virt-top-1.0.9.orig/debian/control  2021-03-21 13:43:49.915299308 +0900
+++ virt-top-1.0.9/debian/control       2021-03-21 14:18:30.499744371 +0900
@@ -20,7 +20,13 @@
 
 Package: virt-top
 Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}
+Depends:
+ ocaml-base-nox | ocaml-base | ocaml-nox | ocaml,
+ libcurses-ocaml,
+ libgettext-ocaml,
+ libvirt-ocaml,
+ ${misc:Depends},
+ ${shlibs:Depends}
 Description: show stats of virtualized domains
  virt-top is a top-like utility for showing stats of virtualized domains. Many
  keys and command line options are the same as for ordinary top.

Regards,