[Pkg-libvirt-maintainers] Bug#1056988: libvirt0: Wrong usage of ${binary:Version}

[Andrea Bolognani]

On Thu, Oct 17, 2024 at 12:06:04PM +0200, Andrea Bolognani wrote:
> On Mon, Nov 27, 2023 at 04:33:59PM +0100, Laurent Bigonville wrote:
> > Source: libvirt
> > Version: 9.9.0-1
> > Severity: normal
> > 
> > Hello,
> > 
> > libvirt0 Recommends libvirt-l10n with the version equal to
> > ${binary:Version}
> > 
> > But libvirt-l10n is an arch:all package, the version should be
> > equal to ${source:Version}
> 
> Hi,
> 
> you seem to be correct, and in fact we even have a similar dependency
> already:
> 
>   Package: libvirt-daemon-system
>   Architecture: any
>   Depends:
>    libvirt-daemon-config-network (= ${source:Version}),
> 
> Additionally, we have a number of dependencies that go in the
> opposite direction, for example:
> 
>   Package: libvirt-clients-qemu
>   Architecture: all
>   Depends:
>    libvirt0 (<< ${source:Version}.1~),
>    libvirt0 (>= ${source:Version}),
> 
> Is the dependency you've identified the only one that looks out of
> place? Would you mind going through the control file again (it has
> changed quite a bit since you filed the bug) and double checking that
> we got the rest right? I'll do the same myself, but an additional
> pair of eyes is always good to have :)

I spotted another issue. The tenative patch is at [1], please take a
look.

Unfortunately I was unable to create a proper MR because, when I try,
salsa raises an error that clearly doesn't make any sense (source
branch "arch-deps" does not exist). Hopefully it's just a temporary
glitch that will sort itself out soon.


[1] https://salsa.debian.org/abologna/libvirt/-/commit/8249afcbfc0068b4977b2c4bdd1552dcbd11556c
-- 
Andrea Bolognani <eof at kiyuko.org>
Resistance is futile, you will be garbage collected.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20241017/e27db397/attachment.sig>