[Pkg-libvirt-maintainers] Bug#1118069: Bug#1118069: libvirt FTBFS with wireshark 4.6

[Andrea Bolognani]

Control: tags -1 upstream fixed-upstream

On Tue, Oct 14, 2025 at 07:44:24PM +0300, Adrian Bunk wrote:
> Source: libvirt
> Version: 11.8.0-1
> Severity: serious
> Tags: ftbfs
> 
> https://buildd.debian.org/status/logs.php?pkg=libvirt&ver=11.8.0-1%2Bb1
> 
> ...
> ../../tools/wireshark/src/packet-libvirt.c: In function ‘dissect_xdr_opaque’:
> ../../tools/wireshark/src/packet-libvirt.c:173:42: error: implicit declaration of function ‘wmem_packet_scope’; did you mean ‘wmem_file_scope’? [-Wimplicit-function-declaration]
>   173 |         const char *s = tvb_bytes_to_str(wmem_packet_scope(), tvb, start, len);
>       |                                          ^~~~~~~~~~~~~~~~~
>       |                                          wmem_file_scope
> ../../tools/wireshark/src/packet-libvirt.c:173:42: warning: nested extern declaration of ‘wmem_packet_scope’ [-Wnested-externs]
> ../../tools/wireshark/src/packet-libvirt.c:173:42: error: passing argument 1 of ‘tvb_bytes_to_str’ makes pointer from integer without a cast [-Wint-conversion]
>   173 |         const char *s = tvb_bytes_to_str(wmem_packet_scope(), tvb, start, len);
>       |                                          ^~~~~~~~~~~~~~~~~~~
>       |                                          |
>       |                                          int
> ...

This should have been addressed upstream by the following series:

  https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ZL4UIEB5DSCFQ7XZ7GMEHJEPKBOHTCCC/

Merged into master as:

  b42a12174c wireshark: Adapt to wireshark-4.6.0
  002b9f559d wireshark: Don't leak column strings
  ba2c4bdd5c wireshark: Introduce and use vir_val_to_str()
  1086888f95 wireshark: Don't special case retval of get_program_data() in dissect_libvirt_message()
  7374c4ecbd wireshark: Fix int type of some virNetMessageHeader members
  02a0e78bf5 wireshark: Move WIRESHARK_VERSION macro definition
  41d3b45797 wireshark: Switch header files to #pragma once
  b825bb556b wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt()

Do you think this warrants a quick 11.8.0-2 upload, or can it wait
~3 weeks for 11.9.0 to be released?

-- 
Andrea Bolognani <eof at kiyuko.org>
Resistance is futile, you will be garbage collected.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-libvirt-maintainers/attachments/20251015/e18a62e4/attachment.sig>