[Pkg-linaro-lava-devel] Bug#772319: lava-dispatcher: bashism in /bin/sh script

Sat Dec 6 13:06:55 UTC 2014

Package: lava-dispatcher
Severity: important
Version: 2014.09.1-1
User: debian-release at lists.debian.org
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".

checkbashisms' output:
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 36 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME started"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 43 ($FUNCNAME):
>	  _lava_lmp_debug "$FUNCNAME error command : " "$result"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 47 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME finished"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 51 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME save message to $LAVA_LMP_CACHE"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 59 ($FUNCNAME):
>	      _lava_lmp_debug "$FUNCNAME save $1 to $LAVA_LMP_CACHE"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 74 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME preparing"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 79 ($FUNCNAME):
>	  _lava_lmp_debug "$FUNCNAME waiting for ack"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 80 (read with option other than -r):
>	  read -t $MESSAGE_TIMEOUT line
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 89 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME finished"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 93 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME starting to wait"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 105 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME waiting over"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 109 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME starting to wait"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 127 ($FUNCNAME):
>     _lava_lmp_debug "$FUNCNAME waiting over"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 136 ($FUNCNAME):
>	  _lava_lmp_debug "$FUNCNAME not cache file $LAVA_LMP_CACHE !"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/lmp/lava-
> lmp.lib line 149 ($FUNCNAME):
>     echo "$FUNCNAME : wrong command $1"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 31 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME started"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 38 ($FUNCNAME):
>	  _lava_multi_node_debug "$FUNCNAME error messageID : " "$result"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 42 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME finished"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 48 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME save message to $LAVA_MULTI_NODE_CACHE"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 72 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME preparing"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 77 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME waiting for ack"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 78 (read with option other than -r):
>	  read -t $MESSAGE_TIMEOUT line
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 87 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME finished"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 93 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME starting to wait"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 105 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME waiting over"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 111 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME starting to wait"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 129 ($FUNCNAME):
> _lava_multi_node_debug "$FUNCNAME waiting over"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-multi-node.lib line 187 ($FUNCNAME):
>	  _lava_multi_node_debug "$FUNCNAME not cache file
> $LAVA_MULTI_NODE_CACHE !"
> possible bashism in
> ./usr/lib/python2.7/dist-
packages/lava_dispatcher/lava_test_shell/multi_nod
> e/lava-network line 58 ($FUNCNAME):
>	  _lava_multi_node_debug "$FUNCNAME Not enough arguments."

Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert