Bug#718721: libedit: Fix build system to use system instead of embeded functions

[Guillem Jover]

Package: libedit
Version: 3.1-20130712-1~exp1
Severity: normal
Tags: patch

On Fri, 2013-08-02 at 22:32:13 +0200, Guillem Jover wrote:
> On Fri, 2013-08-02 at 19:34:01 +0200, Sylvestre Ledru wrote:
> > I just uploaded in experimental a new upstream version of libedit
> > published here:
> > http://www.thrysoee.dk/editline/
> > 
> > It would be nice if you could test if your packages still behave the
> > same. I am not really worried but since it is an important package, I
> > would like confirmations.
> 
> I had just noticed that the version in experimental dropped the libbsd
> usage and started using its embedded function copies, with the
> consequence of exporting them as part of the shared library.
> 
> I'll try to send a patch, in case this does not get fixed in
> the meantime. Most probably adding to LDFLAGS the output of
> «pkg-config --libs libbsd-overlay» and to CFLAGS the output of
> «pkg-config --clags libbsd-overlay», and passing these to ./configure
> might be enough. The fix_gcc_warnings.diff patch should probably be
> dropped then too. Plus updating the symbols file.

Here's a patch that switches libedit back to use libbsd instead of
using the embedded code copies, it also fixes the build system to not
embed fgetln() and wcsdup() even if they are found on the system,
stops embedding wcsdup() when widechar support is not enabled, and to
not check for functions twice. Fixes the pkg-config file, to not make
users unnecessarily link against tinfo. Removes the obsolete patches
related to libbsd. And adds a missing symbol to the symbols file.

I could split the patch in logical pieces if you want, I just wanted
to get this out of the way for now, in case someone else was
considering taking a look.

Thanks,
Guillem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libedit-pkg.patch
Type: text/x-diff
Size: 9402 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-llvm-team/attachments/20130804/928f0023/attachment.patch>