libc++ 3.9.0 packaging improvements

[Sylvestre Ledru]

Le 01/11/2016 à 19:42, Pauli a écrit :
> On Tue, Nov 1, 2016 at 7:20 PM, Sylvestre Ledru <sylvestre at mozilla.com> wrote:
>> Le 01/11/2016 à 17:46, Pauli . a écrit :
>>> On Tue, Nov 1, 2016 at 6:29 PM, Pauli . <suokkos at gmail.com> wrote:
>>>
>>>>> In a chroot, tests are failing with:
>>>>> /usr/bin/ld: cannot find -lc++
>>>> -lc++ shouldn't be included for libc++abi. I didn't see that appearing
>>>> in my system. Full log could help figure out what went wrong.
>>>>
>>> Adding LIBCXXABI_LIBCXX_LIBRARY_PATH to libcxxabi cmake options would
>>> fix the issue. I didn't notice the test problem because I had libc++1
>>> installed when building and running tests.
>>>
>>> -DLIBCXXABI_LIBCXX_LIBRARY_PATH=$(abspath libcxx/$(BUILDDIR)/lib)\
>> So, you can easily reproduce it with:
>> dpkg-source -b -i trunk
>> sudo cowbuilder --build libc++_3.9.0-2.dsc
>>
>> Full log attached.
>>
>> Thanks again,
>> Sylvestre
>>
> I'm partially afk for a few hours this evening.
>
> Attached patch is updated version that managed to run test after I
> removed all libc++ packages from my system. I didn't yet figure how to
> setup cowbuilder correctly. I don't know if all build dependencies are
> correct for chroot build. It would help if I could to my computer and
> read the setup guide.
>
> Looking building actually works correctly but it was only the path
> issue for test runner. The runner isn't smart enough to build
> libc++abi tests without libc++. That requires configure option for
> libc++ build library path to allow testing work correctly.
>
> I hope it works in chroot now.
Works perfectly, many thanks!
S