Bug#876787: afl: FTBFS /usr/bin/ld: unrecognized option '--no-keep-files-mapped'

[Adrian Bunk]

Control: reassign -1 clang-3.9 1:3.9.1-16
Control: affects -1 src:afl
Control: clone -1 -2 -3
Control: reassign -2 clang-4.0 1:4.0.1-5
Control: reassign -3 clang-5.0 1:5.0-2

On Mon, Sep 25, 2017 at 10:47:22PM +0200, Daniel Stender wrote:
> Package: src:afl
> Version: 2.50b-1
> Severity: serious
> Justification: fails to build from source (but built successfully in the past)
> Control: block 873404 by -1
> 
> AFL begun to FTBFS recently with a clang error:
> 
> <cut>
> [+] All set and ready to build.
> clang-3.9  -Wall -D_FORTIFY_SOURCE=2 -g -Wno-pointer-sign -DAFL_PATH=\"/usr/lib/afl\" -DBIN_PATH=\"/usr/bin\" -DVERSION=\"2.50b\"  afl-clang-fast.c -o ../afl-clang-fast -Wl,-z,relro -Wl,-z,now
> ln -sf afl-clang-fast ../afl-clang-fast++
> clang++-3.9 `llvm-config-3.9 --cxxflags` -fno-rtti -fpic  -Wall -D_FORTIFY_SOURCE=2 -g -Wno-pointer-sign -DVERSION=\"2.50b\" -Wno-variadic-macros -shared afl-llvm-pass.so.cc -o ../afl-llvm-pass.so `llvm-config-3.9 --ldflags` -Wl,-z,relro -Wl,-z,now
> warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
> 1 warning generated.
> /usr/bin/ld: unrecognized option '--no-keep-files-mapped'
> /usr/bin/ld: use the --help option for usage information
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> Makefile:83: recipe for target '../afl-llvm-pass.so' failed
> </cut>
> 
> This seems to be a problem in the build toolchain (this is going to be
> reassigned). The same error appears also with clang-4.0 and clang-5.0, thus
> blocking the llvm-toolchain update of AFL.

The trigger is:

llvm-toolchain-3.9 (1:3.9.1-16) unstable; urgency=medium
...
  [ Matthias Klose ]
  * Link with --no-keep-files-mapped --no-map-whole-files when using gold.
...
 -- Sylvestre Ledru <sylvestre at debian.org>  Fri, 08 Sep 2017 11:57:07 +0200


But the actual bug is older:
	CXXFLAGS_EXTRA += -Wl,-fuse-ld=gold -Wl,--no-keep-files-mapped -Wl,--no-map-whole-files

-Wl,-fuse-ld=gold is wrong, this should be -fuse-ld=gold
(it cannot work to tell the linker which linker to use).


> DS

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed