Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any

[Sylvestre Ledru]

Le 03/02/2019 à 23:55, Svante Signell a écrit :
> On Sun, 2019-02-03 at 23:39 +0100, Sylvestre Ledru wrote:
>> Le 03/02/2019 à 17:21, Sylvestre Ledru a écrit :
>>> Le 03/02/2019 à 15:28, Svante Signell a écrit :
>>>> Source: llvm-toolchain-7
>>>> Version: 7_7.0.1-4
>>>> Severity: important
>>>> Tags: ftbfs, patch
>>>> User: debian-kbsd at lists.debian.org
>>>> Usertags: kfreebsd
>>>>
>>>> Hello,
>>>>
>>>> Currently llvm-toolchain-7 FTBFS on GNU/kFreeBSD dues to a missing
>>>> port to that
>>>> architecture. Attached are 14 patches...
>>>> clang_lib_Basic_Targets.diff
>>>> CMakeLists.txt.diff
>>>> compiler-rt_lib.diff
>>>> include_llvm_ADT_Triple.h.diff
>>>> kfreebsd-libcxx-threads-detection.diff
>>>> kfreebsd-openmp.diff
>>>> kfreebsd-threads-build.diff
>>>> kfreebsd-triple-clang.diff
>>>> kfreebsd-triple.diff
>>>> lib_Support.diff
>>>> lib_Target_X86.diff
>>>> lldb_source_Host_freebsd_Host.cpp.diff
>>>> lldb_source_Plugins_Process_FreeBSD.diff
>>>> tools_llvm-shlib_CMakeLists.txt.diff
>>>>
>>>> Additionally, the install file for liblldb-7 needs a separate file:
>>>> liblldb-
>>>> 7.install.kfreebsd. Adding [!kfreebsd-any] to the last row of
>>>> liblldb-7.install
>>>> (or liblldb-X.Y.install.in) did not work.
>>>>
>>>> I will submit these patches to upstream too, in due time.
>>> Wahou, impressive!
>>>
>>> Don't hesitate to submit a MR next time!
>>>
>>> S
>>>
>> I tried to build it on amd64 but it fails with
>>
>> /build/llvm-toolchain-7-7.0.1/projects/compiler-
>> rt/lib/fuzzer/FuzzerUtilPosix.cpp:122:28:
>> error:
>>         use of undeclared identifier 'LIBFUZZER_KFREEBSD'
>>         LIBFUZZER_OPENBSD || LIBFUZZER_KFREEBSD) {
>>
>>
>> Index: llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
>> ===================================================================
>> --- llvm-toolchain-7-7.0.1.orig/compiler-rt/lib/fuzzer/FuzzerDefs.h
>> +++ llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
>> @@ -28,6 +28,7 @@
>>    #define LIBFUZZER_LINUX 1
>>    #define LIBFUZZER_NETBSD 0
>>    #define LIBFUZZER_FREEBSD 0
>> +#define LIBFUZZER_KFREEBSD 0
>>    #define LIBFUZZER_OPENBSD 0
>>    #define LIBFUZZER_WINDOWS 0
>>    #elif __APPLE__
>>
>>
>> It fixed it (and it has to be replicated for the other archs)
> Sorry, I was a little sloppy defining LIBFUZZER_KFREEBSD. Do you want an updated
> patch?
>
No need, I fixed it, thanks!

S