Bug#948109: z3: FTBFS on riscv64, needs -latomic, blocks rustc:riscv64

[Aurelien Jarno]

On 2020-01-04 12:37, Ximin Luo wrote:
> Aurelien Jarno:
> > On 2020-01-04 01:56, Ximin Luo wrote:
> >> Source: z3
> >> Version: 4.8.7-2
> >> Severity: important
> >> Tags: patch
> >>
> >> Dear Maintainer,
> >>
> >> Please apply the attached patch to fix the FTBFS on riscv64.
> >>
> > 
> > Thanks for the patch. I however do not get why it disables java
> > support. Both javahelper and default-jdk are available on riscv64.
> > 
> > In addition to that there is no need to add a depends on libatomic1, it
> > is (indirectly) part of build-essential.
> > 
> 
> Mirroring our IRC discussion on #debian-ports for the record:
> 
> - I disabled java on riscv64 because I couldn't make it work when cross-building from amd64 to riscv64, but it was during an early part of my experimentation and perhaps you are right and it doesn't have to be disabled.

I have actually found that while the dependencies are there, the
java packages are not built. I have verified they build fine on riscv64.
Please find the patch attached.

> - You are working on a better way to fix this, using -pthread instead of -lpthread -latomic. In any case the cross-compiling patch from my OP should still be useful, as it allows one to test with a regular schroot rather than qemu-riscv64.

I confirm this approach work. By using -pthread instead of -lpthread,
threads support is enabled, including linking with libatomic if
necessary, instead of just linking with the thread library.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                 http://www.aurel32.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: z3.riscv64.java.diff
Type: text/x-diff
Size: 1238 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-llvm-team/attachments/20200105/b4d4b01a/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: z3.riscv64.ftbfs.diff
Type: text/x-diff
Size: 1912 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-llvm-team/attachments/20200105/b4d4b01a/attachment-0003.diff>