Bug#948109: z3: FTBFS on riscv64, needs -latomic, blocks rustc:riscv64

[Ximin Luo]

Aurelien Jarno:
> On 2020-01-07 23:54, Fabian Wolff wrote:
>> Thank you all for your patches and the ensuing discussion.
>>
>> I am currently working on porting the z3 Debian package to use the
>> CMake build scripts; I think this will simplify things for all parties
>> involved now and in the future. In the process, I will drop the OCaml
>> bindings; they are currently broken, anyways, have no reverse
>> dependencies, and the upstream CMake scripts don't support building
>> them.
>>
>> There is still some work that needs to be done (e. g. setting the
>> SONAME correctly), but you can have a look at my current progress
>> here: https://salsa.debian.org/pkg-llvm-team/z3/tree/cmake
>>

@Fabian:

For SONAME/SOVERSION it is best to co-ordinate this with upstream, see here for an example:

https://github.com/herumi/mcl/commit/77418a94c19f00d9b7858a46c23ea83eb841091a

>> Is it enough to add -latomic to DEB_LDFLAGS_MAINT_APPEND in
>> debian/rules
> 
> If possible it is actually better to link with -pthread to ensure full
> thread support instead of using -lpthread. In that case it will work out
> of the box on riscv64.
> 
> If it is not possible to do that, then it should indeed be linked with
> -latomic on riscv64.
> 

Note -pthread (good) not -lpthread (bad), a subtle difference. 

>> and disable the Java bindings on riscv64?
> 
> Please do not disable Java bindings, they actually work when built
> natively. Ximin disabled them to be able to cross-compile the package.
> 

I eventually got them to work when cross-compiling but you have to add extra :native and :all annotations to the Build-Depends, please see d/control in my patch for details.

The other stuff from that patch you can drop, assuming they are totally obsoleted by CMake.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git