Bug#1070909: llvm-toolchain-18: FTBFS on riscv64: dh_install: warning: llvm-18-linker-tools missing files: usr/lib/llvm-18/lib/LLVMgold.so

[Aurelien Jarno]

On 2024-05-11 15:46, Sebastian Ramacher wrote:
> Source: llvm-toolchain-18
> Version: 1:18.1.5-2
> Severity: serious
> Tags: ftbfs
> Justification: fails to build from source (but built successfully in the past)
> X-Debbugs-Cc: sramacher at debian.org
> 
> riscv64 is now a release architecture and llvm-toolchain-18 built
> previously.
> 
> https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-18&arch=riscv64&ver=1%3A18.1.5-2&stamp=1715249422&raw=0
> 
>    debian/rules override_dh_install
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_install -p libpolly-18-dev usr/lib/llvm-18/lib/cmake/polly/*.cmake usr/lib/llvm-18/lib/cmake/polly
> rm -rf debian/tmp/usr/lib/llvm-18/lib/cmake/polly/*.cmake
> dh_install --fail-missing 
> dh_install: warning: Please use dh_missing --list-missing/--fail-missing instead
> dh_install: warning: This feature will be removed in compat 12.
> dh_install: warning: Cannot find (any matches for) "usr/lib/llvm-18/lib/LLVMgold.so" (tried in ., debian/tmp)
> 
> dh_install: warning: llvm-18-linker-tools missing files: usr/lib/llvm-18/lib/LLVMgold.so
> dh_install: error: missing files, aborting
> make[1]: *** [debian/rules:1432: override_dh_install] Error 255

I believe this should be fixed by the following patch. I have launched a
local build and I will confirm that when it is done.

diff -Nru llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.install.in llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.install.in
--- llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.install.in	2024-04-29 11:11:01.000000000 +0200
+++ llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.install.in	2024-05-11 19:31:14.000000000 +0200
@@ -2,4 +2,4 @@
 
 usr/lib/llvm- at LLVM_VERSION@/lib/libLTO.so. at LLVM_VERSION@.1
 [!powerpc !powerpcspe] usr/lib/llvm- at LLVM_VERSION@/lib/LLVMPolly.so
-[!powerpc !powerpcspe] usr/lib/llvm- at LLVM_VERSION@/lib/LLVMgold.so
+[!powerpc !powerpcspe !riscv64] usr/lib/llvm- at LLVM_VERSION@/lib/LLVMgold.so
diff -Nru llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.links.in llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.links.in
--- llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.links.in	2024-03-06 09:19:46.000000000 +0100
+++ llvm-toolchain-18-18.1.5/debian/llvm-X.Y-linker-tools.links.in	2024-05-11 19:33:50.000000000 +0200
@@ -1,3 +1,3 @@
 #!/usr/bin/dh-exec
 
-[!powerpc !powerpcspe] usr/lib/llvm- at LLVM_VERSION@/lib/LLVMgold.so usr/lib/bfd-plugins/LLVMgold- at LLVM_VERSION@.so
+[!powerpc !powerpcspe !riscv64] usr/lib/llvm- at LLVM_VERSION@/lib/LLVMgold.so usr/lib/bfd-plugins/LLVMgold- at LLVM_VERSION@.so

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net