[pkg-lua-devel] Bug#1066552: lua-rexlib: FTBFS: src/tre/ltre_w.c:256:13: error: implicit declaration of function ‘iswdigit’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: lua-rexlib
Version: 2.9.2-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /<<PKGBUILDDIR>>/debian/.dh_lua-libtool/libtool --tag=CC --mode=compile x86_64-linux-gnu-gcc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DVERSION="\"2.9.2\"" -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/lua5.1  -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -Wextra -o /<<PKGBUILDDIR>>/5.1-rex.tre/src/tre/ltre_w.lo src/tre/ltre_w.c 
> libtool: compile:  x86_64-linux-gnu-gcc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DVERSION=\"2.9.2\" -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/lua5.1 -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra src/tre/ltre_w.c  -fPIC -DPIC -o /<<PKGBUILDDIR>>/5.1-rex.tre/src/tre/.libs/ltre_w.o
> src/tre/ltre_w.c: In function ‘bufferZ_putrepstringW’:
> src/tre/ltre_w.c:256:13: error: implicit declaration of function ‘iswdigit’ [-Werror=implicit-function-declaration]
>   256 |         if (iswdigit (*q)) {
>       |             ^~~~~~~~
> src/tre/ltre_w.c:63:1: note: include ‘<wctype.h>’ or provide a declaration of ‘iswdigit’
>    62 | #include "../algo.h"
>   +++ |+#include <wctype.h>
>    63 | 
> src/tre/ltre_w.c:256:23: warning: ‘iswdigit’ argument 1 promotes to ‘wchar_t’ {aka ‘int’} where ‘unsigned int’ is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch]
>   256 |         if (iswdigit (*q)) {
>       |                       ^~
> <built-in>: note: built-in ‘iswdigit’ declared here
> cc1: some warnings being treated as errors
> make[2]: *** [/usr/share/dh-lua/make/dh-lua.Makefile.single:446: /<<PKGBUILDDIR>>/5.1-rex.tre/src/tre/ltre_w.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/lua-rexlib_2.9.2-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.