[pkg-lua-devel] Bug#1117098: lua-lgi: Uses dbus-x11 (dbus-launch) for tests

[Simon McVittie]

Source: lua-lgi
Version: 0.9.2-4
Severity: normal
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

This package build-depends on dbus-x11, and seems to be relying on X11 
autolaunching to get a D-Bus session bus for its build-time tests: it 
does not seem to explicitly invoke dbus-launch or dbus-run-session.

It also depends on dbus-x11 for autopkgtests (debian/tests/awesome), and 
this time it explicitly invokes dbus-launch.

D-Bus X11 autolaunching is a poorly-understood legacy code path which 
should be avoided where possible. Instead, please build-depend on 
dbus-daemon and invoke a temporary D-Bus session bus explicitly, more 
like this (untested):

override_dh_auto_test:
	make -C tests all
	GI_TYPELIB_PATH=tests LD_LIBRARY_PATH=tests \
		xvfb-run -a \
		dbus-run-session -- \
		dh_auto_test

This only requires a B-D on dbus-daemon <!nocheck>, which is a smaller 
dependency than dbus-x11 and contains more robust code.

Similarly, for the autopkgtest, please depend on dbus-daemon and use 
something more like (untested):

xvfb-run -s '-screen 0 1024x768x24' dbus-run-session -- awesome -c "$CONFIG"

Thanks,
    smcv