[pkg-lxc-devel] Bug#844086: lxc: On "sysv-init", fail to initialize cgroup since "cgmanager" support dropped.

[Evgeni Golov]

Hi,

On Thu, Jan 12, 2017 at 01:44:12PM +0100, Thibaut Cheze wrote:
> >> I reopen this because I have seen another side effect.
> >> The LXC containers fail to start automatically during boot.
> > I'd argue that it is a slightly different (but totally related) bug.
> > But as you already merged this with #850212, let's handle it as one.
> I was a little too "enthusiastic", sorry.

No worries, no harm done.

> > ...
> >> -# Required-Start: $syslog $remote_fs
> >> -# Required-Stop: $syslog $remote_fs
> >> +# Required-Start: $syslog $remote_fs cgroupfs-mount
> >> +# Required-Stop: $syslog $remote_fs cgroupfs-mount
> >>  # Should-Start:
> >>  # Should-Stop:
> >>  # Default-Start: 2 3 4 5
> > I'd add it to Should-*, not Required-*, as it is perfectly fine to have
> > a different cgroupfs initializer.
> > Will discuss with upstream and include in the next upload.
> >
> >
> I thought like you, but:
>  - "cgroupfs-mount" was developed in such a way that it does nothing
> when it detects that another initializer is at work (fstab way
> included).
>  - It was added as a dependency of "liblxc1", not a recommend.
> But no problems, it will work fine.

It is a dependency if there is no systemd, yeah.
What I wanted to avoid is a system with no cgroupfs-mount installed
(possible with the current depends line) and sysvinit used with some
other means of mounting cgroupfs. I know, it's quite constructed, but oh
well :)

> Otherwise, to be perfectly clean, what do you think of adding
> "cgroupfs-mount" in recommends (or dependencies if in "required") on
> "lxc" package ?

given it's a noop on systemd systems it should be safe, but I kinda
dislike pulling in packages we do not really need. we could add the same
cgroupfs-mount | systemd construct as in liblxc1, but what result do you
expect from that? the (weak) dependency is there anyways.